1442422 - Update webrender to 0da6c839b3a0e165f1115fb9fe286be7540c24ed

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1440664 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 6f6573e7d0662a553902a808d0f837f4c0491244

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a12dd662893f9377b798c6d92425a9b2e066c3e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8d00eba36e1f0a473d083c58df5341cf5f99913

Many windows webgl mochitest failures

WR @ fc7f59280caf0c18b4de9d5bd480f8ae2c995695

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7c95dde3137e4125c17debe4c07fc51016db2a6
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15d9d028956dd09c61c57b3ebb9dc406d4294fe3

Same

These mochitest failures actually seem to have been introduced by something in the last WR update but have gotten worse here. See for example https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=5f7fa97d431be663aedbceca2e83f4839f3f5f05&filter-searchStr=qr%20windows&group_state=expanded&fromchange=a1330e4089ad73ec22d89b3162bf50bfa534feb8 - the windows webgl mochitests were pretty green (with some blue) until the WR update landed and then we started getting a sprinkling of orange with more heavy blue. But in the above try pushes they're a lot more orange/blue than before.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

For the record the move to use a workspace in m-c (bug 1381576) broke my script to do WR updates so that's why there haven't been any pushes since Friday.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ fc7f59280caf0c18b4de9d5bd480f8ae2c995695

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df871e54a4515a503643d6c9a7cf6b7477a6ce07
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7621e79c4f37cecdcb27e9e1c00a9a8093c8002

Linux seems green, windows seems to have issues. This looks a lot like the mochitest-webgl problems we were having before but this try push includes the workaround patch (which otherwise gets clobbered by the WR update) so in theory it shouldn't have this problem. Not sure what's going on.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ c6ea7526e8fbbcf0596ccd4abf3eb20c9661ebcb

https://treeherder.mozilla.org/#/jobs?repo=try&revision=21e43f6e6158527b5021087dda42285ab852878d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=33977be843840f460ad00c682299648daab02785

More of the same. Some linux oranges too.


I'm starting to suspect this is coming from servo/webrender#2474. I did a couple more try pushes to check:

Here's one at the same revision currently in m-c, just as a sanity check to make sure the baseline is still good with my script fixes + reapplying the workaround patch
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b135a8dec7be4c1a0b95ed0722388ae22ad14f7

And here's a push with servo/webrender#2474 applied:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ec9e7f574303963d342633dcf266ba0a78b1dfb

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Yeah the try pushes seem to indicate that servo/webrender#2474 is the culprit.

WR @ 9c9b97a5950899cdc57837e9237e9c020f1aee83

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0acdefb5bf2b99402cc2e739a0c418f3fc15ce2
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca01d388940caed92217b03649767b04e7860dd0

More of the same

Comment 6

[Kartikaya Gupta (email:[e-mail])]

WR @ 4df61ef1eec002c26641e24e5d9a1988d3444793

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf5a1da36ae4673e1bc1fee77ea8ce6a5739ae30
https://treeherder.mozilla.org/#/jobs?repo=try&revision=970343e9236790d0440150b764e6e83e001a3a9a

About the same. Doing a try push now with nical's proper fix from bug 1442748 which should make things green again.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 4df61ef1eec002c26641e24e5d9a1988d3444793 with nical's fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1312cbd74e2de8f54289dc7bfabf51e3d586794
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc4486ccd01fb31c2d659952887825c216fb2211

Looking good so far!

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ 6611df9fdf930db4fb93a00ce2c2d3163c0bb1a1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5e9358a568255de6d90005bc75245660dc4a228
https://treeherder.mozilla.org/#/jobs?repo=try&revision=62de3fb4c4c3596a4e5d9326156591b8b3a51eeb

Green

Comment 9

[Kartikaya Gupta (email:[e-mail])]

WR @ 0da6c839b3a0e165f1115fb9fe286be7540c24ed

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3091a42a093284c01627c40ff759aebc154ca950
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18685804c5e91deacb48043b20d350f49d78b7a8

Green enough (so far).

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1442422 - Update webrender to commit 0da6c839b3a0e165f1115fb9fe286be7540c24ed.

Review commit: https://reviewboard.mozilla.org/r/225792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225792/

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8956836 [details]
Bug 1442422 - Update webrender to commit 0da6c839b3a0e165f1115fb9fe286be7540c24ed.

https://reviewboard.mozilla.org/r/225792/#review231664

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7faa8401a434
Update webrender to commit 0da6c839b3a0e165f1115fb9fe286be7540c24ed. r=jrmuizel

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7faa8401a434