1440664 - Update webrender to 22b831c02479eea31821f49a0fac7dd699083557

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1439565 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 992dbd3f07b143f35581012082aa59fbda7c387e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4916bd1bb3e9470ea106ebf45859b68b2a1b474c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=31247c22defe4c347e80165d3abb81877eb63802

Same as before (big pile of oranges coming from servo/webrender#2362 - see bug 1439565 comment 8 onwards)

WR @ 0b711f2e514107361deef4297c3c7da794d4835c

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cbf4580d196e5997b2ca7f8ce4fa26b49e47b0f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e7f362c9afc4185b5dd60eb1f7e41d2eb4cde19
https://treeherder.mozilla.org/#/jobs?repo=try&revision=acee78655668384140079c14a5218b8edc12a390
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b67442aad33fcd21c55e644d1c82c4d69a4b698

Seems to be the same set of oranges, but I didn't check closely.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Oh there's some new reftest failures. R1 failure is definitely from servo/webrender#2443. There's an R8 failure that shows up on debug only so far [1][2]. And there's an R5 debug intermittent [3] that looks like font/glyph raciness similar to what has been plaguing me on windows.

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=163871539&repo=try&lineNumber=12925
[2] https://treeherder.mozilla.org/logviewer.html#?job_id=163908514&repo=try&lineNumber=12930
[3] https://treeherder.mozilla.org/logviewer.html#?job_id=163908500&repo=try&lineNumber=12898

Comment 3

[Kartikaya Gupta (email:[e-mail])]

The R5 debug thing seems to be bug 1238222 which is pre-existing, so I'm going to ignore it.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

And the R8 failure seems to be bug 1439035 which might be qr-only but is also not new.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 8e2672e52a5a80eba40030601653fe0c1ae223a1 with Martin's gecko-side build fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=317d1d2871553263a57c6928fdc10087a7a47542
https://treeherder.mozilla.org/#/jobs?repo=try&revision=56562eb544a3582e22689de83433483b9a66dcb3

Looks about the same as before.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

WR @ 1f8cdb4f3fb5de8bf40fc2d9c0d8c355476ccd86

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41d4de115b4ef7f98a74e820422b6b12cc84a5f9
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e180e5a469fcbd9fbef95592280fb5d75f646c6b

WR @ c4cd1c8bfa6b1904ba813d7c1ebd6df2e186f87e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=846a8a65810a3e67818c9216beeef8f4af3c1e53
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a12fe6013a598c85a7b61a3aa01bff7a3984194e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e4727e5e93c17bfe22041ad1be427111c19d23d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=af41945c97e45de6eef2112e7df0be74503aa5ad

They look about the same as before, hard to tell if there's any new regressions.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 681e181d254e867efb07b91436daf5a6aea71d34

https://treeherder.mozilla.org/#/jobs?repo=try&revision=683c1393f6a3b351520532deb2cb6189a7de962e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0129b30e029c6203d6c54ffc802672ea3a090465

WR @ 4b905a0179c4ce43c8b4a536d249976b0df45963

https://treeherder.mozilla.org/#/jobs?repo=try&revision=43dd3fa418305a712d4c2f770ec13671e86d2e47
https://treeherder.mozilla.org/#/jobs?repo=try&revision=946cfe5fd535bcaea7516e1d7d3e04b4d1199135
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1ec87eb12078070ff7446a142dcfe909cb66f63
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ec540b1b20ea5a0bd96d3f5160f8589f6e2f5f7

About the same

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ 4b905a0179c4ce43c8b4a536d249976b0df45963

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eef9473ccc0b04cab9372c9609f2aa320d8363df
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0cb88160a17f1c121d9822a0f68af7c536322b1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0225f74b0cfd53384e79193dd963c5e77f71718
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e466b072a863e529e3d372fcee9a2144383df201

Same old

WR @ 3505979af2cfabb35729e6a73217405b638ac2f9

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbcfaf58dd9510bf5c2883c5a4e24d89242ec826
https://treeherder.mozilla.org/#/jobs?repo=try&revision=898c12b554ba0cc270c991857592f4774e51fb48
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e55452fcc15d5375bbd1dd98a211e01de9675c03
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa1cf38da943027f92697a1298fa1a70fd117f1e

Looks about the same, this has nical's fix from servo/webrender#2461 but it doesn't seem to have helped much.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

I did some bisection try pushes. This is the set of patches and try pushes I did at certain revisions:

| * | 69939456 Split DocumentMsg into SceneMsg and FrameMsg.
| * | c3fb6561 Address review comments.
| * | 272d8dbd Apply frame messages after building the scene in the sync path.
| * | be67702b Move the scene builder to its own file.
| * | 392c62b2 Rename prefix/postfix messages into scene/frame messages.
| * | b09c8e45 Keep track of the pending and built scenes separately on the render backend.
    -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2c71afa2fd4046d5b5f32bc28a6ed8d8d13f2b7
       pretty broken
| * | edf064a4 Move dynamic properties into Document.
| * | 61bb29a4 Address some review comments.
| * | e39e0e7c Don't use the scene builder thread by default (yet).
| * | 5df631e1 Refactor transactions and forward them to the scene builder thread.
    -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=1483f9ecc41a7da268534e5404b23eea25d5e3e2
       pretty broken, with panics
| * | c8ee8586 Handle removed pipelines.
| * | 4bd50525 Handle the pipeline epoch map properly.
| * | a481a202 Wake the render backend up after building the scene.
| * | a89270ac Move window_size from frame context to frame builder and update the clip scroll tree.
    -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=926d271d51bc03defe5b5f65b835062a351252d2
       pretty broken, with panics
| * | 111cc480 Use Arc instead of Rc for clip chain nodes to make the clip scroll tree sendable.
| * | b4e030dc Begin patching the necessary information to the scene builder thread.
    -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb964e91889b364dbdfa4f9e0a89f98a46da61d5
       build broken
| * | 5423ee16 Arc scene pipelines to get read access on both the render backend and scene builder threads.
    -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=b98e2677246ebe330f12e319424b5d626c660997
       looks green (the reftest failures can be ignored, it's because this patch was based on a previous WR revision)
| * | 42b9bc2d Add the plumbing for a scene building thread.

So the problems seem to have started in 5423ee16..a89270ac but it might be a different problem what the final problem is at the end of the patchset.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

WR @ 4e374f0c5139ca81ee8de99afe2fc3bc53e3632e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3894fc62b9052a377b1e0a0287f44722751fbb4d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a60d91750dd92b06c1f442205566cbb676fb9218

WR @ b53cf7799a0f5861dfa928ee0ccc66e8d0b78758

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d115c4c11850c1b1d0b1c847eefc3d959efe0b12
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1281633213074c981619ed66e3e48d1c440578b2
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a98748c36bb544788daea30cd5333c9b2b6b79a7
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a32831e6efc89b56e0ec37d18f5f23fff684344

Things are about the same on linux, with some more possibly-intermittent debug reftest failures. Not sure why they don't show up on opt. And windows infra is melting so nothing good there.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

WR @ d7735c7da9844775d4a3e6ec8b6cea25fb0b0486

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0783332a9975f2866d2f6e76c1f1a31664f435bc
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c95e99322ac5cc3565fd15d57fa9c8bcb0cf91c8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ce2e628b536a287e6bf830a20afa856321bb15a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=864d9a91c6a5f3d65fe08d8e40c9a9567634b61c

About the same. windows hw is still backlogged, linux still has oranges.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

WR @ d7735c7da9844775d4a3e6ec8b6cea25fb0b0486

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b40a669299a09518cdbc422d2bf57fc9f5794d4f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0123326f9a2ec3ee0d79246604eadd901f4cc9e

Windows is less backlogged now so that's an improvement. Linux still has the oranges.

WR @ f461a5b39fe2b35c542303d5f3128a7aff547806

https://treeherder.mozilla.org/#/jobs?repo=try&revision=186e548e48ffbfe68d3f21ac0b7c3223159f07e4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a68be3e9e128d1180900b71ce6959e9a5c5d5167

Same

Comment 13

[Kartikaya Gupta (email:[e-mail])]

WR @ 6d8609b79048384465863c1cd13e294fb26cae0f

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d43989a894394b208494e5c888a5efe4ffb3c450
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f22c69ea1933b6d3f9a484ba858f7dbc5d460c4

Same

I found the problem with the async scene building patches, and put in a fix (servo/webrender#2484). Try push with current master + that fix:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ec349cb57128e974f9ef56b0474a8731cfcda2f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3f9fe06d1dbd62d1d8856ac1f0a0ec4e36523b6

Looking pretty green so far, except for one R2 unexpected-pass. Looking back at the try pushes it looks like this used to be in R1, and before that it was in R6, showed up in the range 4e374f0c5139ca81ee8de99afe2fc3bc53e3632e..b53cf7799a0f5861dfa928ee0ccc66e8d0b78758 so probably from servo/webrender#2471.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

WR @ 22b831c02479eea31821f49a0fac7dd699083557

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e2f12e263c3482e5e0496e7a55ddd8be7d54550
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a04168f18cb26e477d46749a9bc68eba4ced5f3

Still in progress, but I'm expecting it to be green. I'll put the patches up but will wait for that try push before landing.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1440664 - Update webrender to commit 22b831c02479eea31821f49a0fac7dd699083557.

Review commit: https://reviewboard.mozilla.org/r/224462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224462/

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1440664 - Update gecko WR bindings for API changes in WR PR 2449.

Review commit: https://reviewboard.mozilla.org/r/224464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224464/

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1440664 - Update Cargo lockfiles and re-vendor rust dependencies.

Review commit: https://reviewboard.mozilla.org/r/224466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224466/

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1440664 - Re-generate FFI header.

Review commit: https://reviewboard.mozilla.org/r/224468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224468/

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1440664 - Update reftest annotation for WR PR 2443.

Review commit: https://reviewboard.mozilla.org/r/224470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224470/

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1440664 - Update reftest annotation for changes in WR PR 2471.

Review commit: https://reviewboard.mozilla.org/r/224472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224472/

Comment 21

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8955313 [details]
Bug 1440664 - Update gecko WR bindings for API changes in WR PR 2449.

https://reviewboard.mozilla.org/r/224464/#review230428

Comment 22

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8955315 [details]
Bug 1440664 - Re-generate FFI header.

https://reviewboard.mozilla.org/r/224468/#review230442

Comment 23

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8955314 [details]
Bug 1440664 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/224466/#review230440

Comment 24

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8955312 [details]
Bug 1440664 - Update webrender to commit 22b831c02479eea31821f49a0fac7dd699083557.

https://reviewboard.mozilla.org/r/224462/#review230438

Comment 25

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8955316 [details]
Bug 1440664 - Update reftest annotation for WR PR 2443.

https://reviewboard.mozilla.org/r/224470/#review230444

Comment 26

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8955317 [details]
Bug 1440664 - Update reftest annotation for changes in WR PR 2471.

https://reviewboard.mozilla.org/r/224472/#review230446

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f54af02c2e6
Update webrender to commit 22b831c02479eea31821f49a0fac7dd699083557. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c066c419e378
Update gecko WR bindings for API changes in WR PR 2449. r=kats
https://hg.mozilla.org/integration/autoland/rev/a5991299ebd0
Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6098d2c015d7
Re-generate FFI header. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/507a25c3afd0
Update reftest annotation for WR PR 2443. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/81f389c2524e
Update reftest annotation for changes in WR PR 2471. r=jrmuizel

Comment 28

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6f54af02c2e6
https://hg.mozilla.org/mozilla-central/rev/c066c419e378
https://hg.mozilla.org/mozilla-central/rev/a5991299ebd0
https://hg.mozilla.org/mozilla-central/rev/6098d2c015d7
https://hg.mozilla.org/mozilla-central/rev/507a25c3afd0
https://hg.mozilla.org/mozilla-central/rev/81f389c2524e

Comment 29

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This started frequent Windows QR webgl failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&fromchange=81f389c2524e58b4b95844667719cc1642573019&tochange=0d73894a5fc45ca86b7498a1da0de719516b654e

Comment 30

[Kartikaya Gupta (email:[e-mail])]

Yeah I was noticing that too. I think I'll turn off the windows webgl QR tests (which I only enabled recently in bug 1426118) while we investigate, because I really don't want to back out this WR update. I'll just back out bug 1426118.

Comment 31

[Kartikaya Gupta (email:[e-mail])]

Backout is in https://hg.mozilla.org/integration/mozilla-inbound/rev/d3b20e603c5fe0c96c0d4a0b58a5b189dc7467b8

Comment 32

[Ionuț Goldan [:igoldan]]

This boosted our performance:

== Change summary for alert #11897 (as of Thu, 01 Mar 2018 20:51:53 GMT) ==

Improvements:

  5%  Strings PerfHasRTLCharsRU osx-10-10 opt      982,541.38 -> 937,867.50
  3%  Strings PerfHasRTLCharsDE osx-10-10 opt      983,657.83 -> 952,768.42

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11897

Comment 33

[Milan Sreckovic [:milan] (needinfo for best results)]

Doesn't make much sense, but that's OK.

Comment 34

[Eric Rahm [:erahm]]

It looks like this regressed libxul size by 72k.

https://treeherder.mozilla.org/perf.html#/graphs?timerange=7776000&series=mozilla-inbound,1299711,1,2&series=autoland,1338582,1,2&zoom=1519941094415.6768,1519947594545.842,121917321.59787875,122175580.86334915&selected=autoland,1338582,311807,422355511,2

Comment 35

[Kartikaya Gupta (email:[e-mail])]

If that's something that needs addressing, please file a new bug. Otherwise I'm just going to treat it as an interesting data point that I don't need to care about.