Intermittent writing-mode/1175789-underline-overline-1.html == writing-mode/1175789-underline-overline-1-ref.html | image comparison, max difference: 255, number of differing pixels: 70

REOPENED
Unassigned

Status

()

defect
P3
normal
REOPENED
Last year
11 months ago

People

(Reporter: intermittent-bug-filer, Unassigned, NeedInfo)

Tracking

(Depends on 1 bug, {intermittent-failure, leave-open})

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 disabled)

Details

(Whiteboard: gfx-noted[stockwell disabled])

Attachments

(1 attachment, 4 obsolete attachments)

In the reftest screenshot of the reference case, the letter "u" is missing from the lang="ja-JP" section.

--> instance of bug 1392106.
Component: Layout → Graphics: Text
Whiteboard: gfx-noted
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → INCOMPLETE
New failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=171238693&repo=mozilla-inbound&lineNumber=33537
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Update: 
There have been 64 failures in the last week.
This is failing a lot on opt and pgo, with one fail on debug on April 7th.

Failures per platforms:
Windows 7 - 61
windows7-32-nightly - 3

Summary: Intermittent writing-mode/1175789-underline-overline-1.html == writing-mode/1175789-underline-overline-1-ref.html | image comparison, max difference: 255, number of differing pixels: 70

Recent log file: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=172463376&lineNumber=44756
Depends on: 1392106
Flags: needinfo?(milan)
Posted patch Disable on Windows (obsolete) — Splinter Review
Attachment #8968431 - Flags: review?(jmaher)
If we're going to disable tests that frequently get hit by bug 1392106, this should be done on Win7 only, right? Failures on any other platform (including Win10) are not the same issue.
Comment on attachment 8968431 [details] [diff] [review]
Disable on Windows

Review of attachment 8968431 [details] [diff] [review]:
-----------------------------------------------------------------

I have proposed solution in bug 1392106, but there is not a lot of interest in making that bug active.  What :jfkthame says is true though, we should only disable this on win7.

This is an example of filtering on win7:
https://searchfox.org/mozilla-central/source/dom/canvas/crashtests/crashtests.list#19

of course you don't need the isDebugBuild piece of it.
Attachment #8968431 - Flags: review?(jmaher) → review-
Posted patch Disable on Windows 7 (obsolete) — Splinter Review
Attachment #8968565 - Flags: review?(jmaher)
Attachment #8968431 - Attachment is obsolete: true
Comment on attachment 8968565 [details] [diff] [review]
Disable on Windows 7

Review of attachment 8968565 [details] [diff] [review]:
-----------------------------------------------------------------

I would change the commit message to:
Bug 1442637 - Disable on Windows 7 - Intermittent writing-mode/1175789-underline-overline-1.html for frequent failures. r=jmaher

::: layout/reftests/writing-mode/reftest.list
@@ +142,4 @@
>  == 1163238-orthogonal-auto-margins.html 1163238-orthogonal-auto-margins-ref.html
>  == 1174450-intrinsic-sizing.html 1174450-intrinsic-sizing-ref.html
>  == 1175789-underline-overline-1.html 1175789-underline-overline-1-ref.html
> +skip-if(winWidget&&/^Windows\x20NT\x206\.1/.test(http.oscpu)) == 1175789-underline-overline-1.html 1175789-underline-overline-1-ref.html # bug 1442637y

we do not need a new line with skip if, etc.- we need to modify the existing line (line 144)
Attachment #8968565 - Flags: review?(jmaher) → review-
Comment on attachment 8968583 [details] [diff] [review]
Modified the commit message and added the "skip-if" on the same line

Review of attachment 8968583 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/writing-mode/reftest.list
@@ +141,4 @@
>  == 1158549-1-vertical-block-size-constraints.html 1158549-1-vertical-block-size-constraints-ref.html
>  == 1163238-orthogonal-auto-margins.html 1163238-orthogonal-auto-margins-ref.html
>  == 1174450-intrinsic-sizing.html 1174450-intrinsic-sizing-ref.html
> +skip-if(winWidget&&/^Windows\x20NT\x206\.1/.test(http.oscpu)) == 1175789-underline-overline-1.html 1175789-underline-overline-1-ref.html | bug 1442637

so close, at the end you have:
| bug 1442637

and it should be:
# bug 1442637
Attachment #8968583 - Flags: review?(jmaher) → review-
Attachment #8968585 - Flags: review?(jmaher)
Attachment #8968565 - Attachment is obsolete: true
Attachment #8968583 - Attachment is obsolete: true
Comment on attachment 8968585 [details] [diff] [review]
Added # in front of the bug number

Review of attachment 8968585 [details] [diff] [review]:
-----------------------------------------------------------------

lets try again

::: layout/reftests/writing-mode/reftest.list
@@ +141,4 @@
>  == 1158549-1-vertical-block-size-constraints.html 1158549-1-vertical-block-size-constraints-ref.html
>  == 1163238-orthogonal-auto-margins.html 1163238-orthogonal-auto-margins-ref.html
>  == 1174450-intrinsic-sizing.html 1174450-intrinsic-sizing-ref.html
> +skip-if(winWidget&&/^Windows\x20NT\x206\.1/.test(http.oscpu)) == 1175789-underline-overline-1.html 1175789-underline-overline-1-ref.html | # bug 1442637

oops, we do not need the ' |'
Attachment #8968585 - Flags: review?(jmaher) → review-
Posted patch Removed "|"Splinter Review
Attachment #8968585 - Attachment is obsolete: true
Attachment #8968587 - Flags: review?(jmaher)
Comment on attachment 8968587 [details] [diff] [review]
Removed "|"

Review of attachment 8968587 [details] [diff] [review]:
-----------------------------------------------------------------

excellent
Attachment #8968587 - Flags: review?(jmaher) → review+
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f894b9798bc
Disable on Windows 7 - Intermittent writing-mode/1175789-underline-overline-1.html for frequent failures. r=jmaher
Keywords: leave-open
Whiteboard: gfx-noted[stockwell disable-recommended] → gfx-noted[stockwell disabled]
Whiteboard: gfx-noted[stockwell disabled] → gfx-noted[stockwell disabled][checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-beta/rev/3c1b04fa81a1ae9856f37e685e11f6558671d296
Whiteboard: gfx-noted[stockwell disabled][checkin-needed-beta] → gfx-noted[stockwell disabled]
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.