Closed
Bug 1442637
Opened 7 years ago
Closed 2 years ago
Intermittent writing-mode/1175789-underline-overline-1.html == writing-mode/1175789-underline-overline-1-ref.html | image comparison, max difference: 255, number of differing pixels: 70
Categories
(Core :: Graphics: Text, defect, P3)
Core
Graphics: Text
Tracking
()
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
firefox60 | --- | disabled |
People
(Reporter: intermittent-bug-filer, Unassigned)
References
Details
(Keywords: intermittent-failure, Whiteboard: gfx-noted[stockwell disabled])
Attachments
(1 file, 4 obsolete files)
1.13 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Filed by: philringnalda [at] gmail.com
https://treeherder.mozilla.org/logviewer.html#?job_id=165456267&repo=mozilla-inbound
https://queue.taskcluster.net/v1/task/LDNzyowPTQCcMyIANlWyyA/runs/0/artifacts/public/logs/live_backing.log
https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/LDNzyowPTQCcMyIANlWyyA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Comment 1•7 years ago
|
||
In the reftest screenshot of the reference case, the letter "u" is missing from the lang="ja-JP" section.
--> instance of bug 1392106.
Component: Layout → Graphics: Text
Depends on: missing-letter-win7
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: gfx-noted
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Comment 5•7 years ago
|
||
New failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=171238693&repo=mozilla-inbound&lineNumber=33537
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 9•7 years ago
|
||
Update:
There have been 64 failures in the last week.
This is failing a lot on opt and pgo, with one fail on debug on April 7th.
Failures per platforms:
Windows 7 - 61
windows7-32-nightly - 3
Summary: Intermittent writing-mode/1175789-underline-overline-1.html == writing-mode/1175789-underline-overline-1-ref.html | image comparison, max difference: 255, number of differing pixels: 70
Recent log file: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=172463376&lineNumber=44756
Depends on: 1392106
Flags: needinfo?(milan)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 14•7 years ago
|
||
In the last 7 days there are 57 failures on this bug.
They occur on Windows 7 and the affected builds type are opt, debug and pgo.
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=173661968&lineNumber=39540
Reftest analyzer: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/JMpiFFGaToOZKRasjoWWLw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 18•7 years ago
|
||
Attachment #8968431 -
Flags: review?(jmaher)
Comment 19•7 years ago
|
||
If we're going to disable tests that frequently get hit by bug 1392106, this should be done on Win7 only, right? Failures on any other platform (including Win10) are not the same issue.
Comment 20•7 years ago
|
||
Comment on attachment 8968431 [details] [diff] [review]
Disable on Windows
Review of attachment 8968431 [details] [diff] [review]:
-----------------------------------------------------------------
I have proposed solution in bug 1392106, but there is not a lot of interest in making that bug active. What :jfkthame says is true though, we should only disable this on win7.
This is an example of filtering on win7:
https://searchfox.org/mozilla-central/source/dom/canvas/crashtests/crashtests.list#19
of course you don't need the isDebugBuild piece of it.
Attachment #8968431 -
Flags: review?(jmaher) → review-
Comment 21•7 years ago
|
||
Attachment #8968565 -
Flags: review?(jmaher)
Updated•7 years ago
|
Attachment #8968431 -
Attachment is obsolete: true
Comment 22•7 years ago
|
||
Comment on attachment 8968565 [details] [diff] [review]
Disable on Windows 7
Review of attachment 8968565 [details] [diff] [review]:
-----------------------------------------------------------------
I would change the commit message to:
Bug 1442637 - Disable on Windows 7 - Intermittent writing-mode/1175789-underline-overline-1.html for frequent failures. r=jmaher
::: layout/reftests/writing-mode/reftest.list
@@ +142,4 @@
> == 1163238-orthogonal-auto-margins.html 1163238-orthogonal-auto-margins-ref.html
> == 1174450-intrinsic-sizing.html 1174450-intrinsic-sizing-ref.html
> == 1175789-underline-overline-1.html 1175789-underline-overline-1-ref.html
> +skip-if(winWidget&&/^Windows\x20NT\x206\.1/.test(http.oscpu)) == 1175789-underline-overline-1.html 1175789-underline-overline-1-ref.html # bug 1442637y
we do not need a new line with skip if, etc.- we need to modify the existing line (line 144)
Attachment #8968565 -
Flags: review?(jmaher) → review-
Comment 23•7 years ago
|
||
Attachment #8968583 -
Flags: review?(jmaher)
Comment 24•7 years ago
|
||
Comment on attachment 8968583 [details] [diff] [review]
Modified the commit message and added the "skip-if" on the same line
Review of attachment 8968583 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/reftests/writing-mode/reftest.list
@@ +141,4 @@
> == 1158549-1-vertical-block-size-constraints.html 1158549-1-vertical-block-size-constraints-ref.html
> == 1163238-orthogonal-auto-margins.html 1163238-orthogonal-auto-margins-ref.html
> == 1174450-intrinsic-sizing.html 1174450-intrinsic-sizing-ref.html
> +skip-if(winWidget&&/^Windows\x20NT\x206\.1/.test(http.oscpu)) == 1175789-underline-overline-1.html 1175789-underline-overline-1-ref.html | bug 1442637
so close, at the end you have:
| bug 1442637
and it should be:
# bug 1442637
Attachment #8968583 -
Flags: review?(jmaher) → review-
Comment 25•7 years ago
|
||
Attachment #8968585 -
Flags: review?(jmaher)
Updated•7 years ago
|
Attachment #8968565 -
Attachment is obsolete: true
Updated•7 years ago
|
Attachment #8968583 -
Attachment is obsolete: true
Comment 26•7 years ago
|
||
Comment on attachment 8968585 [details] [diff] [review]
Added # in front of the bug number
Review of attachment 8968585 [details] [diff] [review]:
-----------------------------------------------------------------
lets try again
::: layout/reftests/writing-mode/reftest.list
@@ +141,4 @@
> == 1158549-1-vertical-block-size-constraints.html 1158549-1-vertical-block-size-constraints-ref.html
> == 1163238-orthogonal-auto-margins.html 1163238-orthogonal-auto-margins-ref.html
> == 1174450-intrinsic-sizing.html 1174450-intrinsic-sizing-ref.html
> +skip-if(winWidget&&/^Windows\x20NT\x206\.1/.test(http.oscpu)) == 1175789-underline-overline-1.html 1175789-underline-overline-1-ref.html | # bug 1442637
oops, we do not need the ' |'
Attachment #8968585 -
Flags: review?(jmaher) → review-
Comment 27•7 years ago
|
||
Attachment #8968585 -
Attachment is obsolete: true
Attachment #8968587 -
Flags: review?(jmaher)
Comment 28•7 years ago
|
||
Comment on attachment 8968587 [details] [diff] [review]
Removed "|"
Review of attachment 8968587 [details] [diff] [review]:
-----------------------------------------------------------------
excellent
Attachment #8968587 -
Flags: review?(jmaher) → review+
Comment 29•7 years ago
|
||
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f894b9798bc
Disable on Windows 7 - Intermittent writing-mode/1175789-underline-overline-1.html for frequent failures. r=jmaher
Updated•7 years ago
|
Keywords: leave-open
Whiteboard: gfx-noted[stockwell disable-recommended] → gfx-noted[stockwell disabled]
Comment hidden (Intermittent Failures Robot) |
Comment 31•7 years ago
|
||
bugherder |
Updated•7 years ago
|
Whiteboard: gfx-noted[stockwell disabled] → gfx-noted[stockwell disabled][checkin-needed-beta]
Comment 32•7 years ago
|
||
uplift |
status-firefox60:
--- → disabled
Whiteboard: gfx-noted[stockwell disabled][checkin-needed-beta] → gfx-noted[stockwell disabled]
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Priority: -- → P3
Updated•5 years ago
|
Flags: needinfo?(milaninbugzilla)
Updated•2 years ago
|
Severity: normal → S3
Comment hidden (Intermittent Failures Robot) |
Comment 35•2 years ago
|
||
not worry about win7
Status: REOPENED → RESOLVED
Closed: 7 years ago → 2 years ago
Keywords: leave-open
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•