1442914 - Access logs should be in "mozlog" json schema

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement)

Description

[Steven MacLeod [:smacleod]]

Lando currently logs its custom logging calls in "mozlog"[1] but log messages from flask are using the default format. Lando's logging should be updated so that the access logs that come from flask are in mozlog format.

[1] https://wiki.mozilla.org/Firefox/Services/Logging

Comment 1

[Phabricator Automation]

Attachment: logging: make logging calls have conventional signatures (Bug 1442914).

The mozlogging package made it so our calls to `logging.<level>()` would
have a strange signature, not following the standard convention of the
`logging` module. This change introduces an updated logging formatter
that expects `logging` calls to use the standard arguments. Logged
messages now adhere to Dockerflow and each field in the log message is
semantically correctly. The access logging messages have been updated to
be Dockerflow compliant, using the 'request.summary' message schema.

The pytest library has also been updated to allow for use of the
`caplog` fixture going forward. This should make testing logging
messages easier. Also, logging is no longer disabled during test runs,
making test failures much easier to diagnose (pytest will write the
logged messages out for the failed test).

Comment 2

[Phabricator Automation]

Comment on attachment 8973824 [details]
logging: make logging calls have conventional signatures (Bug 1442914).

Byron Jones ‹:glob› has approved the revision.

https://phabricator.services.mozilla.com/D1157

Comment 3

[Phabricator Automation]

Attachment: logging: log all requests in mozlog format (1442914).

The access logging messages have been updated to be Dockerflow
compliant, using the `request.summary` message schema. As part of this
Flask/Werkzeug access logging has been disabled, meaning all log
messages should be mozlog.

The mozlogging package made it so our calls to `logging.<level>()` would
have a strange signature, not following the standard convention of the
`logging` module. This change introduces an updated logging formatter
that expects `logging` calls to use the standard arguments. Logged
messages now adhere to Dockerflow and each field in the log message is
semantically correctly.

Logging is also no longer disabled during test runs, making test
failures much easier to diagnose.

Comment 4

[Phabricator Automation]

Comment on attachment 8976654 [details]
logging: log all requests in mozlog format (1442914).

Israel Madueme [:imadueme] has approved the revision.

https://phabricator.services.mozilla.com/D1303

Comment 5

[Steven MacLeod [:smacleod]]

This should now be fixed in both lando-api and lando-ui