Update eslint-plugin-no-unsanitized to 3.0.0

RESOLVED FIXED in Firefox -esr60

Status

enhancement
RESOLVED FIXED
Last year
7 months ago

People

(Reporter: freddyb, Assigned: standard8)

Tracking

3 Branch
mozilla61

Firefox Tracking Flags

(firefox-esr60 fixed, firefox61 fixed)

Details

Attachments

(2 attachments)

This bug is to make the change to bump the eslint-plugin-no-unsanitized version from ^2.0.1 to ^3.0.0 in tools/lint/eslint/eslint-plugin-mozilla/package.json

The change is rather small, but might cause breakage in the tree for uses of createContextualFragment.

Hence the major version bump.
Upgrading this causes eslint-plugin-mozilla to fail with:

    An error occurred running eslint. Please check the following error messages:
     
    Cannot find module 'escope'
    Error: Cannot find module 'escope'
        at Function.Module._resolveFilename (module.js:555:15)
        at Function.Module._load (module.js:482:25)
        at Module.require (module.js:604:17)
        at require (internal/module.js:11:18)
        at Object.<anonymous> (/Users/mark/dev/gecko/tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js:14:16)
        at Module._compile (module.js:660:30)
        at Object.Module._extensions..js (module.js:671:10)
        at Module.load (module.js:573:32)
        at tryModuleLoad (module.js:513:12)
        at Function.Module._load (module.js:505:3)
    A failure occurred in the eslint linter.
    ✖ 1 problem (0 errors, 0 warnings, 1 failure) 

What's happened here is that ESLint switched from escope to eslint-scope between 3.x and 4.x: https://github.com/eslint/eslint/commit/4673f6e2f348e98a1288a2da5ec42e313826ebdb#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

eslint-plugin-mozilla has been getting the escope dependency via eslint-plugin-no-unsanitized v2 as that’s had eslint 3.x as a dependency up until this version bump.

I have a patch locally to switch eslint-plugin-mozilla from escope to eslint-scope.
Assignee: nobody → standard8
Attachment #8960125 - Flags: review?(dtownsend)
Note: the out-of-tree tooltool.py was out of date (didn't support python 3), and hence broke uploading.

Adding --url to the tooltool.py scripts is due to bug 1396937.
Comment on attachment 8960124 [details]
Bug 1443093 - Update eslint-plugin-no-unsanitized to 3.0.0 / eslint to 4.18.2.

https://reviewboard.mozilla.org/r/228928/#review234724
Attachment #8960124 - Flags: review?(dtownsend) → review+
Comment on attachment 8960125 [details]
Bug 1443093 - Change the update.sh scripts to use in-tree tooltool.py and update the node_modules bundles on the servers.

https://reviewboard.mozilla.org/r/228930/#review234734
Attachment #8960125 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64c5f14f196b
Update eslint-plugin-no-unsanitized to 3.0.0 / eslint to 4.18.2. r=mossop
https://hg.mozilla.org/integration/autoland/rev/d1bb57364f35
Change the update.sh scripts to use in-tree tooltool.py and update the node_modules bundles on the servers. r=mossop
https://hg.mozilla.org/mozilla-central/rev/64c5f14f196b
https://hg.mozilla.org/mozilla-central/rev/d1bb57364f35
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.