1443093 - Update eslint-plugin-no-unsanitized to 3.0.0

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Frederik Braun [:freddy] (OOO until August 18th)]

This bug is to make the change to bump the eslint-plugin-no-unsanitized version from ^2.0.1 to ^3.0.0 in tools/lint/eslint/eslint-plugin-mozilla/package.json

The change is rather small, but might cause breakage in the tree for uses of createContextualFragment.

Hence the major version bump.

Comment 1

[Mark Banner (:standard8)]

Upgrading this causes eslint-plugin-mozilla to fail with:

    An error occurred running eslint. Please check the following error messages:
     
    Cannot find module 'escope'
    Error: Cannot find module 'escope'
        at Function.Module._resolveFilename (module.js:555:15)
        at Function.Module._load (module.js:482:25)
        at Module.require (module.js:604:17)
        at require (internal/module.js:11:18)
        at Object.<anonymous> (/Users/mark/dev/gecko/tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js:14:16)
        at Module._compile (module.js:660:30)
        at Object.Module._extensions..js (module.js:671:10)
        at Module.load (module.js:573:32)
        at tryModuleLoad (module.js:513:12)
        at Function.Module._load (module.js:505:3)
    A failure occurred in the eslint linter.
    ✖ 1 problem (0 errors, 0 warnings, 1 failure) 

What's happened here is that ESLint switched from escope to eslint-scope between 3.x and 4.x: https://github.com/eslint/eslint/commit/4673f6e2f348e98a1288a2da5ec42e313826ebdb#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

eslint-plugin-mozilla has been getting the escope dependency via eslint-plugin-no-unsanitized v2 as that’s had eslint 3.x as a dependency up until this version bump.

I have a patch locally to switch eslint-plugin-mozilla from escope to eslint-scope.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1443093 - Update eslint-plugin-no-unsanitized to 3.0.0 / eslint to 4.18.2.

Also change eslint-plugin-mozilla's globals.js to use eslint-scope rather than escope as
ESLint 4.x changed to eslint-scope. This avoids dependency issues that were masked by the
depedencies of eslint-plugin-no-unsanitized's previous version.

Review commit: https://reviewboard.mozilla.org/r/228928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228928/

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1443093 - Change the update.sh scripts to use in-tree tooltool.py and update the node_modules bundles on the servers.

Review commit: https://reviewboard.mozilla.org/r/228930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228930/

Comment 4

[Mark Banner (:standard8)]

Note: the out-of-tree tooltool.py was out of date (didn't support python 3), and hence broke uploading.

Adding --url to the tooltool.py scripts is due to bug 1396937.

Comment 5

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Comment on attachment 8960124 [details]
Bug 1443093 - Update eslint-plugin-no-unsanitized to 3.0.0 / eslint to 4.18.2.

https://reviewboard.mozilla.org/r/228928/#review234724

Comment 6

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Comment on attachment 8960125 [details]
Bug 1443093 - Change the update.sh scripts to use in-tree tooltool.py and update the node_modules bundles on the servers.

https://reviewboard.mozilla.org/r/228930/#review234734

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64c5f14f196b
Update eslint-plugin-no-unsanitized to 3.0.0 / eslint to 4.18.2. r=mossop
https://hg.mozilla.org/integration/autoland/rev/d1bb57364f35
Change the update.sh scripts to use in-tree tooltool.py and update the node_modules bundles on the servers. r=mossop

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/64c5f14f196b
https://hg.mozilla.org/mozilla-central/rev/d1bb57364f35

Comment 9

[Tom Prince [:tomprince]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/3ec08b5745f0