Closed Bug 1443267 Opened 3 years ago Closed 3 years ago

Remove unneeded menuitem-non-iconic class in calendar-alarm-widget.xml

Categories

(Calendar :: Dialogs, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1440146 removes the menuitem-non-iconic binding. Calendar uses this in one place.
I tried it without this class and saw no difference.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8956184 - Flags: review?(philipp)
Comment on attachment 8956184 [details] [diff] [review]
menuitem-non-iconic.patch

Review of attachment 8956184 [details] [diff] [review]:
-----------------------------------------------------------------

This class used to leave an empty space if the menu contained both items with and without icons. I think it was removed in Firefox though so lets make it go away here as well.
Attachment #8956184 - Flags: review?(philipp) → review+
Thanks.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a1566833de20
Remove unneeded menuitem-non-iconic class in calendar-alarm-widget.xml. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.2
You need to log in before you can comment on or make changes to this bug.