Closed
Bug 1443267
Opened 7 years ago
Closed 7 years ago
Remove unneeded menuitem-non-iconic class in calendar-alarm-widget.xml
Categories
(Calendar :: Dialogs, enhancement)
Calendar
Dialogs
Tracking
(Not tracked)
RESOLVED
FIXED
6.2
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
|
1.53 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Bug 1440146 removes the menuitem-non-iconic binding. Calendar uses this in one place.
|
Assignee | |
Comment 1•7 years ago
|
||
I tried it without this class and saw no difference.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8956184 -
Flags: review?(philipp)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8956184 [details] [diff] [review]
menuitem-non-iconic.patch
Review of attachment 8956184 [details] [diff] [review]:
-----------------------------------------------------------------
This class used to leave an empty space if the menu contained both items with and without icons. I think it was removed in Firefox though so lets make it go away here as well.
Attachment #8956184 -
Flags: review?(philipp) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a1566833de20
Remove unneeded menuitem-non-iconic class in calendar-alarm-widget.xml. r=philipp
|
||
Updated•7 years ago
|
Target Milestone: --- → 6.2
You need to log in
before you can comment on or make changes to this bug.
Description
•