1443318 - Intermittent browser_check_identity_state.js,browser_urlbarAboutHomeLoading.js,browser_remoteness_flip_on_restore.js | Uncaught exception - at chrome://global/content/bindings/tabbox.xml:384 - TypeError: this.tabbox is undefined

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/logviewer.html#?job_id=166063779&repo=autoland&lineNumber=3475

TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_check_identity_state.js | Uncaught exception - at chrome://global/content/bindings/tabbox.xml:384 - TypeError: this.tabbox is undefined
Stack trace:
    set_selectedIndex@chrome://global/content/bindings/tabbox.xml:384:15
    set_selectedItem@chrome://global/content/bindings/tabbox.xml:420:34
    set_selectedTab@chrome://global/content/bindings/tabbox.xml:100:15
    set selectedTab@chrome://browser/content/tabbrowser.js:296:5
    openNewForegroundTab/promises<@resource://testing-common/BrowserTestUtils.jsm:196:44
    switchTab@resource://testing-common/BrowserTestUtils.jsm:237:7
    openNewForegroundTab@resource://testing-common/BrowserTestUtils.jsm:190:9
    pbModeTest@chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_check_identity_state.js:381:22
    async*test_pb_mode@chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_check_identity_state.js:409:9
    Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1067:21
    Tester_execTest@chrome://mochikit/content/browser-test.js:1058:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:958:9
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

I expect this is due the "tabbox" property being set in the TabBrowser constructor directly rather than lazily. Alas, just accessing DOM node like this invokes XBL.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

browser_urlbarAboutHomeLoading.js: https://treeherder.mozilla.org/logviewer.html#?job_id=166209440&repo=try
browser_remoteness_flip_on_restore.js: https://treeherder.mozilla.org/logviewer.html#?job_id=166209453&repo=try

Comment 3

[Intermittent Failures Robot]

63 failures in 116 pushes (0.543 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-central: 20
* autoland: 19
* mozilla-inbound: 16
* try: 7
* mozilla-beta: 1

Platform breakdown:
* linux32-stylo-disabled: 12
* osx-10-10: 11
* linux32: 11
* linux64: 8
* linux64-stylo-disabled: 7
* windows10-64-ccov: 6
* linux64-ccov: 5
* linux32-devedition: 2
* linux32-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1443318&startday=2018-03-06&endday=2018-03-06&tree=all

Comment 4

[Oriol Brufau [:Oriol]]

Recently I have been getting this "TypeError: this.tabbox is undefined" error when using Nightly.

It happens sometimes when I open a new window, then the tabbar doesn't work properly. I can click another tab but the content window does not change.

Doesn't always happen and I don't have more precise steps to reproduce. When it happens, closing the bad window and opening a new one does not fix the problem, but restarting the browser usually does.

Comment 5

[Intermittent Failures Robot]

56 failures in 160 pushes (0.35 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 27
* mozilla-inbound: 14
* mozilla-central: 10
* try: 5

Platform breakdown:
* linux64: 12
* osx-10-10: 10
* linux32-stylo-disabled: 10
* linux32: 8
* windows10-64-ccov: 6
* linux64-stylo-disabled: 6
* linux64-ccov: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1443318&startday=2018-03-07&endday=2018-03-07&tree=all

Comment 6

[Dão Gottwald [:dao]]

gBrowser.init currently sets tabContainer before tabbox. But the tabContainer constructor needs the tabbox:

https://searchfox.org/mozilla-central/rev/33cc9e0331da8d9ff3750f1e68d72d61201176cb/toolkit/content/widgets/tabbox.xml#240

So I think an easy fix is to set tabbox before tabContainer. I will still pursue bug 1443849 regardless.

Comment 7

[Dão Gottwald [:dao]]

Attachment: Bug 1443318 - Set tabbox before tabContainer in gBrowser.init since the tabContainer's XBL constructor needs the tabbox.

Review commit: https://reviewboard.mozilla.org/r/226058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226058/

Comment 8

[Dão Gottwald [:dao]]

Try with 10 test runs looking good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=375d69305a8461d0dba1e7a9b886bb142106452a

Comment 9

[:Gijs (he/him)]

Comment on attachment 8957116 [details]
Bug 1443318 - Set tabbox before tabContainer in gBrowser.init since the tabContainer's XBL constructor needs the tabbox.

https://reviewboard.mozilla.org/r/226058/#review232004

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3934ce46a591
Set tabbox before tabContainer in gBrowser.init since the tabContainer's XBL constructor needs the tabbox. r=Gijs

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3934ce46a591

Comment 13

[Intermittent Failures Robot]

36 failures in 126 pushes (0.286 failures/push) were associated with this bug yesterday.    

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. ** 

Repository breakdown:
* autoland: 16
* mozilla-central: 13
* mozilla-inbound: 5
* try: 2

Platform breakdown:
* linux32-stylo-disabled: 7
* windows10-64-ccov: 6
* linux64: 6
* linux64-ccov: 5
* linux32: 5
* osx-10-10: 4
* linux64-stylo-disabled: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1443318&startday=2018-03-08&endday=2018-03-08&tree=all

Comment 14

[Intermittent Failures Robot]

168 failures in 747 pushes (0.225 failures/push) were associated with this bug in the last 7 days. 

This is the #3 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* autoland: 67
* mozilla-central: 50
* mozilla-inbound: 33
* try: 15
* mozilla-beta: 3

Platform breakdown:
* linux32-stylo-disabled: 30
* osx-10-10: 26
* linux32: 26
* linux64: 25
* windows10-64-ccov: 19
* linux64-stylo-disabled: 19
* linux64-ccov: 18
* macosx64-devedition: 2
* macosx64-nightly: 1
* linux32-nightly: 1
* linux32-devedition: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1443318&startday=2018-03-05&endday=2018-03-11&tree=all