1443837 - Set the "hasadjacentnewtabbutton" attribute in the tabbrowser-tabs binding rather than gBrowser

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Dão Gottwald [:dao]]

Notably, gBrowser.init isn't really the right time and place to set the attribute initially. I think right now it probably doesn't matter much since gBrowser.init likely triggers the binding to be constructed by touching this.tabContainer, but maybe we can avoid doing that in the future.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1443837 - Set the "hasadjacentnewtabbutton" attribute in the tabbrowser-tabs binding rather than gBrowser.

Review commit: https://reviewboard.mozilla.org/r/225820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225820/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8956869 [details]
Bug 1443837 - Set the "hasadjacentnewtabbutton" attribute in the tabbrowser-tabs binding rather than gBrowser.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/225820/diff/1-2/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8956869 [details]
Bug 1443837 - Set the "hasadjacentnewtabbutton" attribute in the tabbrowser-tabs binding rather than gBrowser.

https://reviewboard.mozilla.org/r/225820/#review231712

I think moving this is a good idea, so rs=me for that. Trying to figure out why this helps with the intermittent on IRC. :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45f906f12b8a
Set the "hasadjacentnewtabbutton" attribute in the tabbrowser-tabs binding rather than gBrowser. r=Gijs

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/45f906f12b8a