Closed Bug 1443837 Opened 2 years ago Closed 2 years ago

Set the "hasadjacentnewtabbutton" attribute in the tabbrowser-tabs binding rather than gBrowser

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Notably, gBrowser.init isn't really the right time and place to set the attribute initially. I think right now it probably doesn't matter much since gBrowser.init likely triggers the binding to be constructed by touching this.tabContainer, but maybe we can avoid doing that in the future.
Blocks: 1443318
Comment on attachment 8956869 [details]
Bug 1443837 - Set the "hasadjacentnewtabbutton" attribute in the tabbrowser-tabs binding rather than gBrowser.

https://reviewboard.mozilla.org/r/225820/#review231712

I think moving this is a good idea, so rs=me for that. Trying to figure out why this helps with the intermittent on IRC. :-)
Attachment #8956869 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45f906f12b8a
Set the "hasadjacentnewtabbutton" attribute in the tabbrowser-tabs binding rather than gBrowser. r=Gijs
Blocks: 1443849
No longer blocks: 1443318
https://hg.mozilla.org/mozilla-central/rev/45f906f12b8a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.