1443432 - Snap: Can't publish to candidate channel because of missing scope

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Johan Lorenzo [:jlorenzo]]

[1] didn't fetch any secrets, because scopes are missing. That's an oversight of bug 1411559.

[1] https://tools.taskcluster.net/groups/S3Ygsrn8QfuFvBXK5nAXlw/tasks/Vm39Y8PeR8-d7PzXcNIwbA/runs/0/logs/public%2Flogs%2Flive_backing.log#L9306

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1443432 - Set scopes to push to Snap store's candidate channel

Review commit: https://reviewboard.mozilla.org/r/225248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225248/

Comment 3

[Johan Lorenzo [:jlorenzo]]

This patch made authentication working[1]. The task failed because of an internal error of the snapcraft binary. I'm talking to Canonical to get this sorted out. Another fix will come.

[1] https://tools.taskcluster.net/groups/S3Ygsrn8QfuFvBXK5nAXlw/tasks/GzujpZ9vTgqQcXtJaReq5g/runs/0/logs/public%2Flogs%2Flive_backing.log#L9325

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8956380 [details]
Bug 1443432 - Set scopes to push to Snap store's candidate channel

https://reviewboard.mozilla.org/r/225248/#review231232

Lgtm!

Comment 5

[Johan Lorenzo [:jlorenzo]]

I talked to Canonical. I confirmed the error in comment 3 is not a problem on our end. For reference, here is it:
> [0;32mRevision 62 of 'firefox' created.[0m
> Error in sys.excepthook:
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/snapcraft/cli/_errors.py", line 55, in exception_handler
>     echo.error(str(exception))
>   File "/usr/lib/python3/dist-packages/snapcraft/internal/errors.py", line 33, in __str__
>     return self.fmt.format([], **self.__dict__)
> KeyError: '"status"'
> 
> Original exception was:
> Traceback (most recent call last):
>   File "/usr/bin/snapcraft", line 9, in <module>
>     load_entry_point('snapcraft==2.39.3+really2.35', 'console_scripts', 'snapcraft')()
>   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 542, in load_entry_point
>     return get_distribution(dist).load_entry_point(group, name)
>   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2569, in load_entry_point
>     return ep.load()
>   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2229, in load
>     return self.resolve()
>   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2235, in resolve
>     module = __import__(self.module_name, fromlist=['__name__'], level=0)
>   File "/usr/lib/python3/dist-packages/snapcraft/cli/__main__.py", line 19, in <module>
>     run(prog_name='snapcraft')
>   File "/usr/lib/python3/dist-packages/click/core.py", line 716, in __call__
>     return self.main(*args, **kwargs)
>   File "/usr/lib/python3/dist-packages/click/core.py", line 696, in main
>     rv = self.invoke(ctx)
>   File "/usr/lib/python3/dist-packages/click/core.py", line 1060, in invoke
>     return _process_result(sub_ctx.command.invoke(sub_ctx))
>   File "/usr/lib/python3/dist-packages/click/core.py", line 889, in invoke
>     return ctx.invoke(self.callback, **ctx.params)
>   File "/usr/lib/python3/dist-packages/click/core.py", line 534, in invoke
>     return callback(*args, **kwargs)
>   File "/usr/lib/python3/dist-packages/snapcraft/cli/store.py", line 118, in push
>     snapcraft.push(snap_file, channel_list)
>   File "/usr/lib/python3/dist-packages/snapcraft/_store.py", line 438, in push
>     release(snap_name, result['revision'], release_channels)
>   File "/usr/lib/python3/dist-packages/snapcraft/_store.py", line 534, in release
>     channels = store.release(snap_name, revision, release_channels)
>   File "/usr/lib/python3/dist-packages/snapcraft/storeapi/__init__.py", line 240, in release
>     self.sca.snap_release, snap_name, revision, channels)
>   File "/usr/lib/python3/dist-packages/snapcraft/storeapi/__init__.py", line 181, in _refresh_if_necessary
>     return func(*args, **kwargs)
>   File "/usr/lib/python3/dist-packages/snapcraft/storeapi/__init__.py", line 627, in snap_release
>     raise errors.StoreReleaseError(data['name'], response)
> snapcraft.storeapi.errors.StoreReleaseError: <exception str() failed>

As you can see the snapcraft version is "2.39.3+really2.35". Canonical released "2.39.3" yesterday, but there was a regression, so they rolled back to "2.35". I've been told, debian version number must always be higher. This explains why the version is labelled "2.39.3+really2.35". 
They confirmed it's a bug on the client, which was fixed in between 2.35 and 2.39. They'll release 2.40 as soon as they can. Therefore, I don't think there's anything else to do on our end, before next RC. We automatically pick the latest version Canonical provides.

In case they don't release 2.40 before Thursday, the workaround is:
* let the task run and see what revision number is created (in the logs above, it was revision 62)
* on the dashboard[1], pick the revision, click on the "Release" link (it's a link, not a button), choose "Candidate" and validate.

[1] https://dashboard.snapcraft.io/snaps/firefox/

Comment 6

[Johan Lorenzo [:jlorenzo]]

Landed on release at: https://hg.mozilla.org/releases/mozilla-release/rev/517fe68440b3c9b31611a83e3208793e287dc56a

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8956380 [details]
Bug 1443432 - Set scopes to push to Snap store's candidate channel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/225248/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e86684e2bf6
Set scopes to push to Snap store's candidate channel r=mtabara

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4e86684e2bf6