Closed Bug 1443585 Opened 5 years ago Closed 5 years ago

No need to use fake devices in test_pc_trackDisabling.html

Categories

(Core :: WebRTC: Audio/Video, defect, P2)

60 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(2 files)

test_peerConnection_trackDisabling.html is requesting fake devices from gUM, but based on the audio/video tests it's doing that shouldn't be necessary.

Instead it would be good to increase coverage of track disabling with the real device backend.
Rank: 19
Priority: -- → P2
Comment on attachment 8956550 [details]
Bug 1443585 - Remove fake:true from test_pc_trackDisabling.html.

https://reviewboard.mozilla.org/r/225456/#review231380

Lgtm.
Attachment #8956550 - Flags: review?(jib) → review+
Comment on attachment 8956551 [details]
Bug 1443585 - Remove fake:true from test_pc_trackDisabling_clones.html.

https://reviewboard.mozilla.org/r/225458/#review231740
Attachment #8956551 - Flags: review?(jib) → review+
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/626de98f9025
Remove fake:true from test_pc_trackDisabling.html. r=jib
https://hg.mozilla.org/integration/autoland/rev/22c86b366942
Remove fake:true from test_pc_trackDisabling_clones.html. r=jib
https://hg.mozilla.org/mozilla-central/rev/626de98f9025
https://hg.mozilla.org/mozilla-central/rev/22c86b366942
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.