Closed Bug 1443614 Opened 3 years ago Closed 3 years ago

Stop reporting legacy Telemetry component `Telemetry Log`

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: chutten, Assigned: janerik, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

This bug is for stopping TelemetryLog from being reported, and updating any documentation and tests.

To stop the reporting, we ought to be able to just have TelemetrySession report null for payload.log.

There are a few places where it is tested and documented.

This may have interesting interactions with the Telemetry Experiments part of this project, as they are the only user of TelemetryLog.
Blocks: 1443615
Mentor: chutten
Priority: -- → P3
Assignee: nobody → jrediger
Priority: P3 → --
Priority: -- → P1
This patch only removes the data from the ping payload data. Internally it's still collected, just never exposed.

There's still one user left: Experiments.jsm
Their tests use the interal `TelemetryLog.entries` API, which continues to work for now.

Do we need to migrate them over to some other reporting mechanism first?
Attachment #8960505 - Flags: review?(chutten)
Fixed a small mistake in chosing the right documentation header
Attachment #8960511 - Flags: review?(chutten)
Attachment #8960505 - Attachment is obsolete: true
Attachment #8960505 - Flags: review?(chutten)
Comment on attachment 8960511 [details] [diff] [review]
Stop reporting legacy Telemetry component `Telemetry Log`

Review of attachment 8960511 [details] [diff] [review]:
-----------------------------------------------------------------

When you tackle bug 1443608 you'll probably end up removing the offending test. It may or may not make more sense to deal with it first.

As for the patch, looks good. Can you put an obsolete notice on the "main" ping docs like we did for threadHangStats?
Attachment #8960511 - Flags: review?(chutten) → review+
Attachment #8960511 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6a1f3a9e679
Stop reporting legacy Telemetry component `Telemetry Log`. r=chutten
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e6a1f3a9e679
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.