Closed
Bug 1443659
Opened 3 years ago
Closed 3 years ago
Rename GeckoSession.openWindow() to open(), similarly closeWindow() -> close()
Categories
(GeckoView :: General, enhancement)
GeckoView
General
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: snorp, Assigned: snorp)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The "window" naming is weird.
Comment hidden (mozreview-request) |
Comment 2•3 years ago
|
||
mozreview-review |
Comment on attachment 8956636 [details] Bug 1443659 - Rename GeckoSession.openWindow and closeWindow https://reviewboard.mozilla.org/r/225598/#review231454 r+, but it would be good to add docs for open/close here if we don't already have an open bug for that.
Attachment #8956636 -
Flags: review?(droeh) → review+
Comment 3•3 years ago
|
||
mozreview-review |
Comment on attachment 8956636 [details] Bug 1443659 - Rename GeckoSession.openWindow and closeWindow https://reviewboard.mozilla.org/r/225598/#review231844
Attachment #8956636 -
Flags: review?(esawin) → review+
Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c8275e1f531e Rename GeckoSession.openWindow and closeWindow r=esawin,droeh
Comment 5•3 years ago
|
||
Backed out 3 changesets (bug 1443660, bug 1443659, bug 1443658) for android-checkstyle bustage on a CLOSED TREE Push with the failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c8275e1f531edac26f613b99499714708af3b01e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Log failure example: https://treeherder.mozilla.org/logviewer.html#?job_id=166634548&repo=mozilla-inbound Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/dd3beebf0ce3dda4f359907379aaa372449b022d
Flags: needinfo?(snorp)
Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1504df1d9c9e Rename GeckoSession.openWindow and closeWindow r=esawin,droeh
Comment 7•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1504df1d9c9e
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•3 years ago
|
Assignee: nobody → snorp
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(snorp)
Updated•2 years ago
|
Product: Firefox for Android → GeckoView
Updated•2 years ago
|
Target Milestone: Firefox 60 → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•