1443659 - Rename GeckoSession.openWindow() to open(), similarly closeWindow() -> close()

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

The "window" naming is weird.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1443659 - Rename GeckoSession.openWindow and closeWindow

Review commit: https://reviewboard.mozilla.org/r/225598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225598/

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8956636 [details]
Bug 1443659 - Rename GeckoSession.openWindow and closeWindow

https://reviewboard.mozilla.org/r/225598/#review231454

r+, but it would be good to add docs for open/close here if we don't already have an open bug for that.

Comment 3

[Eugen Sawin [:esawin] on leave until 25 September]

Comment on attachment 8956636 [details]
Bug 1443659 - Rename GeckoSession.openWindow and closeWindow

https://reviewboard.mozilla.org/r/225598/#review231844

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8275e1f531e
Rename GeckoSession.openWindow and closeWindow r=esawin,droeh

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (bug 1443660, bug 1443659, bug 1443658) for android-checkstyle bustage on a CLOSED TREE
 
Push with the failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c8275e1f531edac26f613b99499714708af3b01e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Log failure example: https://treeherder.mozilla.org/logviewer.html#?job_id=166634548&repo=mozilla-inbound

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/dd3beebf0ce3dda4f359907379aaa372449b022d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1504df1d9c9e
Rename GeckoSession.openWindow and closeWindow r=esawin,droeh

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1504df1d9c9e