Closed Bug 1443659 Opened 2 years ago Closed 2 years ago

Rename GeckoSession.openWindow() to open(), similarly closeWindow() -> close()

Categories

(GeckoView :: General, enhancement)

enhancement
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The "window" naming is weird.
Comment on attachment 8956636 [details]
Bug 1443659 - Rename GeckoSession.openWindow and closeWindow

https://reviewboard.mozilla.org/r/225598/#review231454

r+, but it would be good to add docs for open/close here if we don't already have an open bug for that.
Attachment #8956636 - Flags: review?(droeh) → review+
Comment on attachment 8956636 [details]
Bug 1443659 - Rename GeckoSession.openWindow and closeWindow

https://reviewboard.mozilla.org/r/225598/#review231844
Attachment #8956636 - Flags: review?(esawin) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8275e1f531e
Rename GeckoSession.openWindow and closeWindow r=esawin,droeh
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1504df1d9c9e
Rename GeckoSession.openWindow and closeWindow r=esawin,droeh
https://hg.mozilla.org/mozilla-central/rev/1504df1d9c9e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Assignee: nobody → snorp
Flags: needinfo?(snorp)
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.