1443937 - Autoscroller does not disengage when middle clicking anywhere other than the widget.

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[slew]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20100101



Actual results:

There's no easy way to stop autoscrolling in the latest nightly, left click interacts with the content below the cursor, middle click repositions the autoscroller at the place that was clicked, right clicking creates a context menu and interacts with the page.


Expected results:

Middle clicking anywhere while the autoscroller is showing should stop autoscrolling, not reposition and continue autoscrolling.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:ux regression

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 3

[Dão Gottwald [:dao]]

I can't seem to reproduce this with my trackpad on Ubuntu. Wondering if this is platform-dependent or can only be reproduced with a mouse...

Comment 4

[Alice0775 White]

(In reply to Dão Gottwald [::dao] from comment #3)
> I can't seem to reproduce this with my trackpad on Ubuntu. Wondering if this
> is platform-dependent or can only be reproduced with a mouse...

yep, I am able to reprodice on Ubuntu16.04.

So, this probrem seems to be reproducible on windows only.

Comment 5

[Alice0775 White]

oops,
s/I am able/I am NOT able/

Comment 6

[slew]

One more discovery, the autoscroller behaves as expected on internal pages (about:) but not on actual web pages or about:reader.

Comment 7

[George Billios]

I can also confirm it on Windows with 60b3 but not on Arch linux same version.

Comment 8

[Dão Gottwald [:dao]]

This regressed with bug 1442651 because that put the autoscroll popup in #mainPopupSet rather than some random place in the document, and now we hit this somewhat bogus-looking code path:

https://searchfox.org/mozilla-central/rev/8976abf9cab8eb4661665cc86bd355cd08238011/layout/xul/nsMenuPopupFrame.cpp#1851

Comment 10

[Dão Gottwald [:dao]]

Attachment: Bug 1443937 - Make the autoscroll popup explicitly consume outside clicks.

Review commit: https://reviewboard.mozilla.org/r/227982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227982/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94cf9a609d44
Make the autoscroll popup explicitly consume outside clicks. r=enn

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/94cf9a609d44

Comment 13

[George Billios]

Question as it appears to be targeting 61 for the patch, will it be included also in next 60betas?

Comment 16

[Dão Gottwald [:dao]]

(In reply to George Billios from comment #13)
> Question as it appears to be targeting 61 for the patch, will it be included
> also in next 60betas?

That's the goal but it hasn't landed in 60 yet.

Comment 17

[Dão Gottwald [:dao]]

Comment on attachment 8959111 [details]
Bug 1443937 - Make the autoscroll popup explicitly consume outside clicks.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1442651
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: yes, see comment 0
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix
[String changes made/needed]: /

Comment 18

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8959111 [details]
Bug 1443937 - Make the autoscroll popup explicitly consume outside clicks.

regression fix for beta60

Comment 19

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/86165d0549ce

Comment 20

[Hani Yacoub, Desktop QA]

Build ID: 20180320100122
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

Verified as fixed on Firefox Nightly 61.0a1 on Windows 10 x 64, Windows 7 x32.

Comment 21

[Julien Cristau [:jcristau] (back April 22)]

I'm assuming the 60 status reset was accidental.

Comment 22

[Hani Yacoub, Desktop QA]

Updated by mistake status-firefox60.

Comment 23

[Hani Yacoub, Desktop QA]

Build ID: 20180322152034
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

Verified as fixed on Firefox Beta 60.0b6 on Windows 10 x 64, Windows 7 x32.