1444026 - update lando's "tree" and "destination" fields in its requests to autoland-transplant

Status: RESOLVED INVALID

(Conduit :: Lando, defect)

Description

[:glob ✱]

as per bug 1443540 comment #5:
> (In reply to Israel Madueme [:imadueme] from comment #4)
> > We do pass this in as the "tree" and the destination is currently set to
> > always be "upstream"
> > (https://github.com/mozilla-conduit/lando-api/blob/master/landoapi/
> > transplant_client.py#L55).
> 
> it took a while to unravel things because the names of these fields are
> deceptive, and it pans i was wrong in my earlier assessments; sorry about
> that.
> 
> i wrote up my findings at
> https://docs.google.com/document/d/15mFRONQySDHgOfSf8ieHqbx_b1tLJYANO-
> mwXrhwGk4
> 
> 
> `tree` needs to be the name, and `destination` the _push_ url.
> eg.
>   "tree": "phabricator-qa-dev",
>   "destination": "ssh://hg.mozilla.org/automation/phabricator-qa-dev",

Comment 1

[Steven MacLeod [:smacleod]]

(In reply to Byron Jones ‹:glob› from comment #0)
> > ...and `destination` the _push_ url.

This is something we discussed a while back and decided on "upstream" being fine. Please see comment at https://github.com/mozilla-conduit/lando-api/blob/81c32dbf6b0b434e99741f99b72afdcaf0cc8f2e/landoapi/transplant_client.py#L65 which you reviewed at https://phabricator.services.mozilla.com/D324

The tree argument is currently being set, so I think this bug is a no-op. Going to resolve, please re-open if I've missed something.