1444138 - onLocationChange() sometimes gives URIs for non-toplevel frames

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

+++ This bug was initially created as a clone of Bug #1439013 +++

comment #4 in bug 1439013 indicates that we are firing onLocationChange() for iframes or something. That's bad.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Only report top-level location changes

If we only want to report top-level location changes, this patch should do the trick. Otherwise we could change the API and pass isTopLevel to onLocationChange, if there's some reason that info might be interesting to a consumer.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8961540 [details] [diff] [review]
Only report top-level location changes

Review of attachment 8961540 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a91e917151b
Only report top-level location changes via NavigationDelegate.onLocationChange() r=snorp

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5a91e917151b