1444500 - Add an about:library page Firefox

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ursula Sarracini (:ursula)]

It depends on the approach here we'll probably want to add the about:library view before we can link to it via Activity Stream

Comment 1

[Ursula Sarracini (:ursula)]

Attachment: Bug 1444500 - Add an about:library page to Firefox

Review commit: https://reviewboard.mozilla.org/r/234658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234658/

Comment 2

[Ursula Sarracini (:ursula)]

Comment on attachment 8965824 [details]
Bug 1444500 - Add an about:library page to Firefox

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/234658/diff/1-2/

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8965824 [details]
Bug 1444500 - Add an about:library page to Firefox

https://reviewboard.mozilla.org/r/234658/#review241084

::: browser/components/library/moz.build:8
(Diff revision 2)
> +# This Source Code Form is subject to the terms of the Mozilla Public
> +# License, v. 2.0. If a copy of the MPL was not distributed with this
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +JAR_MANIFESTS += ['jar.mn']
> +FINAL_LIBRARY = 'browsercomps'

Probably worth adding a BUG_COMPONENT section in here -- see https://searchfox.org/mozilla-central/source/browser/components/search/moz.build

::: browser/themes/shared/aboutLibrary.css:7
(Diff revision 2)
> +    background-image: url("chrome://browser/content/illustrations/under-construction.svg");
> +    background-repeat: no-repeat;
> +    background-position: center;
> +    min-height: 300px;
> +    min-width: 300px;
> +    margin-top: -10%;

A comment in the CSS about why the margin-top is necessary would be helpful.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8965824 [details]
Bug 1444500 - Add an about:library page to Firefox

https://reviewboard.mozilla.org/r/234658/#review241084

This code looks good, I'm in the process of generating a test build (mmm, full builds! :-).  I've suggested just a couple of simple nit-fixes, and I would like one more quick look before it lands.

Comment 5

[Ursula Sarracini (:ursula)]

Comment on attachment 8965824 [details]
Bug 1444500 - Add an about:library page to Firefox

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/234658/diff/2-3/

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8965824 [details]
Bug 1444500 - Add an about:library page to Firefox

https://reviewboard.mozilla.org/r/234656/#review241168

Looks good to me; r=dmose

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8965824 [details]
Bug 1444500 - Add an about:library page to Firefox

https://reviewboard.mozilla.org/r/234658/#review241172

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/596ffab7446c
Add an about:library page to Firefox r=dmose

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/596ffab7446c

Comment 10

[:Gijs (he/him)]

Should we unship this? Looks like none of the deps ever got any traction, and shipping this one file with "under construction" on it (as an image, without any text) is not really useful...

Comment 11

[Ursula Sarracini (:ursula)]

We still plan on doing this in the mid to near future, unfortunately about:library has been de-prioritized lately in favour of working on other things. This won't land for 63 or probably 64 but its still on the roadmap for us in this half of year. What are your concerns with keeping this patch in? Is is mostly just code cleanliness or is it more about bundle size, or something else?

Comment 12

[:Gijs (he/him)]

(In reply to Ursula Sarracini (:ursula) from comment #11)
> What are your concerns with keeping this patch
> in? Is is mostly just code cleanliness or is it more about bundle size

Both of these things. :-)

I'm assuming, given it's end of November, that this is now not happening this year. If we don't have concrete plans to ship this very very soon, it doesn't really hurt to unship this - if necessary we can resurrect the code in hg if we do end up shipping it, right?

Comment 13

[Ursula Sarracini (:ursula)]

Yeah I unnderstand, this keeps getting de-prioritized, so it's starting to make sense to unship this. I'll bring it up with the team, and we can file a bug for it. Thanks Gijs.