Closed Bug 1444549 Opened 7 years ago Closed 7 years ago

Crash in java.lang.NumberFormatException: For input string: "@<addr>64" at java.lang.Integer.parseInt(Integer.java)

Categories

(Firefox for Android Graveyard :: General, defect, P1)

Product:
Firefox for Android Graveyard
Component:
General
Version:
Firefox 59
Platform:
ARM
Android
Type:
defect

Tracking

(relnote-firefox 59+, firefox58 unaffected, firefox59+ verified, firefox60 verified, firefox61 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
relnote-firefox --- 59+
firefox58 --- unaffected
firefox59 + verified
firefox60 --- verified
firefox61 --- verified

People

(Reporter: philipp, Assigned: vlad.baicu)

References

Details

(Keywords: crash, regression, Whiteboard: [Leanplum] [60])

Crash Data

Attachments

(1 file, 1 obsolete file)

Bug 1444549: Remove unused IconTabWidget XML attr.
59 bytes, text/x-review-board-request
mcomella
: review+
RyanVM
: approval-mozilla-beta+
RyanVM
: approval-mozilla-release+
Details
This bug was filed from the Socorro interface and is report bp-c1d0254b-3e72-415f-bbb3-307b50180309. ============================================================= Java Stack Trace java.lang.NumberFormatException: For input string: "@2131427964" at java.lang.Integer.parseInt(Integer.java:608) at com.android.internal.util.XmlUtils.convertValueToInt(XmlUtils.java:133) at android.content.res.TypedArray.getInt(TypedArray.java:375) at org.mozilla.gecko.widget.IconTabWidget.<init>(IconTabWidget.java:33) at java.lang.reflect.Constructor.newInstance0(Native Method) at java.lang.reflect.Constructor.newInstance(Constructor.java:334) at android.view.LayoutInflater.createView(LayoutInflater.java:647) at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:790) at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:730) at android.view.LayoutInflater.rInflate(LayoutInflater.java:863) at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:824) at android.view.LayoutInflater.rInflate(LayoutInflater.java:866) at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:824) at android.view.LayoutInflater.rInflate(LayoutInflater.java:866) at android.view.LayoutInflater.inflate(LayoutInflater.java:489) at android.view.LayoutInflater.inflate(LayoutInflater.java:423) at android.view.LayoutInflater.inflate(LayoutInflater.java:374) at org.mozilla.gecko.tabs.TabsPanel.inflateLayout(TabsPanel.java:144) at org.mozilla.gecko.tabs.TabsPanel.<init>(TabsPanel.java:139) at java.lang.reflect.Constructor.newInstance0(Native Method) at java.lang.reflect.Constructor.newInstance(Constructor.java:334) at android.view.LayoutInflater.createView(LayoutInflater.java:647) at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:790) at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:730) at android.view.LayoutInflater.inflate(LayoutInflater.java:492) at android.view.LayoutInflater.inflate(LayoutInflater.java:423) at android.view.ViewStub.inflateViewNoAdd(ViewStub.java:269) at android.view.ViewStub.inflate(ViewStub.java:302) at org.mozilla.gecko.BrowserApp.ensureTabsPanelExists(BrowserApp.java:2356) at org.mozilla.gecko.BrowserApp.handleMessage(BrowserApp.java:1895) at org.mozilla.gecko.EventDispatcher$2.run(EventDispatcher.java:341) at android.os.Handler.handleCallback(Handler.java:790) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:164) at android.app.ActivityThread.main(ActivityThread.java:6494) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:440) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807) ============================================================= this crash is showing up in the very early rollout of 59.0 fennec release (#2 top crasher, 5% of crashes) - wasn't present before on beta. the input string in the crash always seems to be "@2131427964". Android model facet 1 SM-G935F 8 21.62 % 2 ONE E1003 7 18.92 % 3 ONE E1005 6 16.22 % 4 ONEPLUS A5010 5 13.51 % 5 Pixel 4 10.81 % 6 ONEPLUS A3000 2 5.41 % 7 Pixel 2 XL 2 5.41 % 8 SM-G935S 2 5.41 % 9 Redmi Note 4 1 2.70 %
it mostly appears to be a startup crash hitting users repeatedly - by the number of installs the signature is only the #7 top crash at this point.
the user comment at bp-850ddf63-91eb-4b32-bdbd-0275f0180310 says: "App crashes on latest update when trying to open on the tab overview"
Hi Susheel, this seems to be a new top crasher (see comment 1) in 59. Could you please help find an owner who can investigate and perhaps get a fix ready for a potential dot release ride-along? Thanks!
Flags: needinfo?(sdaswani)
FYI, this crash is a newfound one, due to the RC build being pushed to 5% of release users on GP. This is something new that relman team implemented during 59 cycle.
Top crasher on startup on release build: P1.
Priority: -- → P1
Tracking to keep an eye on this during the 59 release. It's the #6 crash right now out of a few thousand crash reports for 59 on the release channel.
tracking-firefox59: ? → +
snorp, can you take a look? Thanks!
Flags: needinfo?(snorp)
I don't see anything super obvious to cause this: - IconTabWidget hasn't changed in forever - The XML that inflates it last changed in October (but maybe that's how long it took for 59 to get released?) https://hg.mozilla.org/mozilla-central/log/tip/mobile/android/app/src/main/res/layout/tabs_panel_default.xml - We don't pass in a weird value for the icon, but maybe it's getting set somewhere else that I haven't looked.
tracking-firefox59: + → ?
Accidentally cleared tracking-ff59: Liz can you fix it? I don't have permissions.
Flags: needinfo?(lhenry)
I think this may be another instance of APK corruption that we hit seemingly at random. Not really actionable unless we have STR or other some other data that will help us diagnose.
Flags: needinfo?(snorp)
ok, it looks like will ship a newer build (20180310203435) to release in the end anyway. i will monitor how that one behaves - perhaps the apk corruption is not present there and the crash fades again...
(In reply to [:philipp] from comment #11) > ok, it looks like will ship a newer build (20180310203435) to release in the > end anyway. i will monitor how that one behaves - perhaps the apk corruption > is not present there and the crash fades again... OK I'll keep my NI on this until we determine a fix is not needed - I'm still begging to get the contractors started by next Monday.
We already shipped 20180310203435 to release at a 5% update rate - tomorrow morning we just turn it up higher (to 25% unless there is a blocking issue)
Flags: needinfo?(lhenry)
the crash is reported from users of the final 59 release version (build 20180310203435) as well.
Several of the URLs have about:home?panel=, but there are some others as well. I tried reproducing using the first build with my device, and although I got one crash I wasn't able to get it submitted to see if it was the same issue.
Flags: needinfo?(sdaswani)
Whiteboard: [Leanplum] [60]
Lots of common devices in the mix, but no specific correlation data. Ioana - Can we try to reproduce with one of the devices listed (Pixel, Pixel 2, Nexus 6, Pixel XL?)
Flags: needinfo?(ioana.chiorean)
Some URLs in case it helps with repro: *http://knowyourmeme.com/memes/my-disappointment-is-immeasurable *moz-extension://28db68f7-0d30-4481-8a11-b2f10e8fe247/firstRun.html *http://www.dunelm.com/stores/nottingham *https://maker-faire.de/hannover/call-for-makers/ *https://play.google.com/store/apps/details?id=com.sixtostart.zombiesrunclient Comments: *Just crashes with seconds of starting. This time was afyer clearing cache and data *Staryed it tapped on address bar. Well, this doesn't bide well. Can't evem reach a page. *Firefox keeps closing everytime I open the site Firefox keeps closing *searching "before we die" on duckduck go. coming from a Google play entry. *I think this is related to an overlay I'm using so it's a problem on my end. No worries!
It appears that the attributes used by the widget are redundant since it always uses the icon. Furthermore, the implementation with the text seems to be unmaintained because setting the widget to display text instead of icon crashes due to a class cast issue.
Assignee: nobody → vlad.baicu
Status: NEW → ASSIGNED
I have checked for all usages of IconTabWidget as well as its functions and it is never used in order to add tabs with texts, only icons. After setting the attribute in xml specifically to "text" the app will crash with a ClassCastException in IconTabWidget.java line:47. This leads me to expect that this piece of code hasn't been maintained and used for anything other than icons in a while. If we remove this redundant piece of code, the crash gets fixed in the process as well.
Thanks Vlad. I'll have Mike review. Mike, this is a pretty targeted patch, hopefully the review won't take long.
Flags: needinfo?(michael.l.comella)
Comment on attachment 8961393 [details] [diff] [review] Possible_fix_for__1444549_redundant_attributes.patch Review of attachment 8961393 [details] [diff] [review]: ----------------------------------------------------------------- lgtm: this patch addresses the crash by removing the code that was crashing (in the Android framework). This code was okay to remove because it is unused. It's unclear why this is crashing but this is a great speculative fix. Thanks for the quick turn around Vlad! :) nit: In the splinter interface, this patch is missing the bug number, a description of what was changed, and a reviewer (i.e. "Bug #xxx: Changed the thing. r=mcomella"): please add it. fwiw, we've moved to mozreview/reviewboard for review, which would catch issues like the commit message ^, the ability to push multiple changesets from the command line (with hg bookmarks), provide one-click landing functionality, a better review interface, etc. It'd be great if you could use it in the future: https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview.html
Attachment #8961393 - Flags: review+
Susheel, this is r+ once it gets a fix to the commit message. I assume Vlad won't see this until tomorrow due to time zones - should I handle fixing it up, landing it, and submitting approval for release/beta so we can get this in ASAP? If so, please Slack me about it.
Flags: needinfo?(michael.l.comella) → needinfo?(sdaswani)
I've been requested to expedite via email/slack: on it.
Flags: needinfo?(sdaswani)
Comment on attachment 8961393 [details] [diff] [review] Possible_fix_for__1444549_redundant_attributes.patch Review of attachment 8961393 [details] [diff] [review]: ----------------------------------------------------------------- Also, I can't apply this patch from the command line (which is the usual workflow; though I was able to apply it with Intellij) - this is another reason to use reviewboard next time. :)
Comment on attachment 8961534 [details] Bug 1444549: Remove unused IconTabWidget XML attr. https://reviewboard.mozilla.org/r/230330/#review235896 This commit was written by Vlad, which I r+'d so carrying my r+ forward. I pushed to mozreview in order to autoland and modify the patch to include a commit summary. I set the patch's author information to Vlad's bugzilla info.
Attachment #8961534 - Flags: review?(michael.l.comella) → review+
Pushed by michael.l.comella@gmail.com: https://hg.mozilla.org/integration/autoland/rev/479e52127d91 Remove unused IconTabWidget XML attr. r=mcomella
Comment on attachment 8961534 [details] Bug 1444549: Remove unused IconTabWidget XML attr. Approval Request Comment [Feature/Bug causing the regression]: Unknown - crash rate spiked for an unknown reason. [User impact if declined]: A top crasher on release [Is this code covered by automated tests?]: We have UI tests that should inflate this widget, but I don't know if anything tests this directly. [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: Can't - we don't have steps to reproduce the crash. However, I never ran this patch locally so it might be ideal for someone to build and run it to make sure it works as expected (i.e. the Tab widget doesn't change in appearance at all). [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: Low. [Why is the change risky/not risky?]: We're removing the unused XML options, their entry point in the code, and the few uncomplicated branches they use in the code. Overall, pretty straightforward. [String changes made/needed]: None
Attachment #8961534 - Flags: approval-mozilla-release?
Attachment #8961534 - Flags: approval-mozilla-beta?
Please note again that this is a speculative fix!
https://hg.mozilla.org/mozilla-central/rev/479e52127d91
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Ioana, can you please do some exploratory testing with the 2018-03-23 Android nightly containing this fix to ensure that there are no obvious regressions caused by it? It would be great to see some level of testing of this fix before uplifting it all the way to 59.0.2 :-)
Flags: qe-verify+
We tested on several devices the nightly build ( myself, Levente and Bogdan) and we are not seeing this. We tried both with clean install and also updating it. Samsung Galaxy S8 (Android 7.0) Samsung Galaxy S7 Edge (Android 7.0 Pixel 2 (Android 8.1.0) Pixel XL (Android 8.0.0) I think it is safe to push it further and watch the stats.
Flags: needinfo?(ioana.chiorean)
Comment on attachment 8961534 [details] Bug 1444549: Remove unused IconTabWidget XML attr. Thanks for testing, Ioana! Let's give this a shot for 60.0b7 and 59.0.2 then.
Attachment #8961534 - Flags: approval-mozilla-release?
Attachment #8961534 - Flags: approval-mozilla-release+
Attachment #8961534 - Flags: approval-mozilla-beta?
Attachment #8961534 - Flags: approval-mozilla-beta+
Status: RESOLVED → VERIFIED
See Also: → 1449177
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: