Inline the msgCompSMIMEOverlay.xul

RESOLVED FIXED in Thunderbird 60.0

Status

defect
RESOLVED FIXED
Last year
Last year

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 60.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

The last one in the mail/extensions/smime directory.
This patch needs bug 1444598 and bug 1444601 applied first.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8957799 - Flags: review?(jorgk)
I haven't renamed the JS files. They do have still "Overlay" in their names. Do you think, we should remove the overlay in the names? If yes, I do this in a new bug.
Yes, and what about .css, .dtd and .properties?
Comment on attachment 8957799 [details] [diff] [review]
msgCompSMIMEOverlay.patch

This doesn't work. There is a funny artefact to the left of the security item in the toolbar. Also, I get two lock icons in the status bar and two seal icons. Also, the seal is cut off. Would you like to see a screen shot?
Attachment #8957799 - Flags: review?(jorgk)
Posted image screenshot.png
(In reply to Jorg K (GMT+1) from comment #4)
> Comment on attachment 8957799 [details] [diff] [review]
> msgCompSMIMEOverlay.patch
> 
> This doesn't work. There is a funny artefact to the left of the security
> item in the toolbar. Also, I get two lock icons in the status bar and two
> seal icons. Also, the seal is cut off. Would you like to see a screen shot?

This is how it looks on my system, and also on Win 7.

I think, in your obj-dir is still the msgCompSMIMEOverlay.xul file and in the manifest the overlay. A problem when not clobbered. Could you try to remove the msgCompSMIMEOverlay.xul file manually in your obj-dir and test again? You will get a error about the missing file for the overlay, but this only because of the missing clobber. You could also delete the messenger.manifest and all should be good.
Comment on attachment 8957799 [details] [diff] [review]
msgCompSMIMEOverlay.patch

OK, removing msgCompSMIMEOverlay.xul and messenger.manifest helped.

This envelope is about the ugliest thing I've seen in a while, it's cut off at the bottom :-(
Attachment #8957799 - Flags: review+
Oh, what is mailnews/extensions/smime/content/msgCompSMIMEOverlay.xul? That's almost the same as the mail/ one we're removing now, the difference is that the mail/ one has some faulty </image> tags, see:
https://dxr.mozilla.org/comm-central/rev/04e68359ee5160785d01a2e22f7b9229688333d1/mail/extensions/smime/content/msgCompSMIMEOverlay.xul#69
and
https://dxr.mozilla.org/comm-central/rev/04e68359ee5160785d01a2e22f7b9229688333d1/mailnews/extensions/smime/content/msgCompSMIMEOverlay.xul#69
Equally there are still mailnews versions of msgReadSMIMEOverlay.xul and msgHdrViewSMIMEOverlay.xul.
(In reply to Jorg K (GMT+1) from comment #7)
> Oh, what is mailnews/extensions/smime/content/msgCompSMIMEOverlay.xul?
> That's almost the same as the mail/ one we're removing now, the difference
> is that the mail/ one has some faulty </image> tags, see:
> https://dxr.mozilla.org/comm-central/rev/
> 04e68359ee5160785d01a2e22f7b9229688333d1/mail/extensions/smime/content/
> msgCompSMIMEOverlay.xul#69

It's not faulty, it's there to show the icon. it's to not use a removed binding, see bug 1417198.

(In reply to Jorg K (GMT+1) from comment #8)
> Equally there are still mailnews versions of msgReadSMIMEOverlay.xul and
> msgHdrViewSMIMEOverlay.xul.

They are still used by SM to overlay other files in SM.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/12da106483e8
Inline the msgCompSMIMEOverlay.xul. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.