1444684 - WebExtension's popup does not open in overflow menu

Status: RESOLVED DUPLICATE of bug 1445787

(WebExtensions :: Frontend, defect)

Description

[magicp]

Steps to reproduce:
1. Launch Nightly on macOS
2. Install any add-ons which have a popup window (e.g. "Nightly Tester Tools" https://addons.mozilla.org/en-US/firefox/addon/nightly-tester-tools)
3. Right click on the add-on button
4. Select "Pin to Overflow Menu" in the context menu
5. Click "More tools..." button (#nav-bar-overflow-button)
6. Click the add-on button in the overflow menu
7. Click "More tools..." button again


Actual results:
In step 6, the add-on popup does not open.
In step 7, "More tools..." button does not work.
I cannot reproduce this on Windows and Ubuntu.


Expected results:
Works fine in step 6 to 7.


Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3eef48c0a0d9530f463d4f38dfc271925ca4d5d6&tochange=79044302abd1165ed375708201090281972d32d8

Comment 1

[David Durst [:ddurst]]

added P1 because of relationship to OOP on MacOS shipping.

Comment 2

[Albert Scheiner [:alberts]]

Related to or dup of bug 1445787?

Comment 3

[:shell escalante]

I just tested with the Nightly Tester Tools add-on on it worked OK.  Also tried with Personas Plus (a much wider UX) and saw some layout issues.  

Attaching screenshot of opening Personas Plus from the toolbar looks like versus opening Personas Plus from "More Tools...".

Steps to recreate are 
1.  installing Personas Plus https://addons.mozilla.org/en-US/firefox/addon/personas-plus/
2. Opening from Toolbar > works fine
3. Right click and "Pin to Overflow Menu"
4. Click the ">>" to see More Tools
5. Click Personas Plus

Expected:
See the same thing as opening from Toolbar location

Actual:
Saw only a narrow column that I could scroll through.

Not sure on priority - depending what else this might impact.  What I tested seems like a less common use case (using Overflow Menu with a add-on with a bigger UX), and I could fix just removing from overflow menu, or scrolling (though scrolling was ugly).

Comment 4

[:shell escalante]

Attachment: Personas plus opening normally from toolbar.png

Comment 5

[:shell escalante]

Attachment: Personas plus opening too narrow from overflow menu.png

Comment 6

[Markus Stange [:mstange]]

(In reply to Albert Scheiner [:alberts] from comment #2)
> Related to or dup of bug 1445787?

Looks like a dup. I'm marking it as such.

(In reply to :shell escalante from comment #3)
> I just tested with the Nightly Tester Tools add-on on it worked OK.  Also
> tried with Personas Plus (a much wider UX) and saw some layout issues.  

Thanks, I've filed this as a new bug: bug 1454032