1444758 - Convert more mochitests to xpcshell

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Kris Maglione [:kmag]]

Our mochitest run time, especially when running in multiple configurations, makes development more difficult than it needs to be. Many of our plain mochitests can easily be converted to xpcshell tests, which can run in parallel, and using fewer resources.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 1: Add console message matching helper to AddonTestUtils.

Several of our existing plain mochitests use the message matching features of
SimpleTest.monitorConsole. Having a similar utility for xpcshell tests would
make it much easier to migrate these tests to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226884/

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 2: Migrate test_ext_sandbox_var to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226886/

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 3 - Migrate test_ext_schema to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226888/

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 4 - Migrate test_ext_background_api_injection to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226890/

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 5 - Migrate test_ext_contentscript_api_injection to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226892/

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 6 - Migrate test_ext_content_security_policy to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226894/

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 7 - Migrate test_ext_contentscript_async_loading to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226896/

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 8 - Migrate test_ext_contentscript_context to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226898/

Comment 9

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 9 - Migrate test_ext_contentscript_css to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226900/

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 10 - Migrate test_ext_contentscript_create_iframe to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226902/

Comment 11

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 11 - Migrate test_ext_contentscript_exporthelpers to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226904/

Comment 12

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 12a - Migrate test_ext_contentscript_teardown to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226906/

Comment 13

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 12b - Migrate test_ext_background_teardown to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226908/

Comment 14

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 12c - Migrate test_ext_tab_teardown to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226910/

Comment 15

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 13 - Migrate test_ext_xhr_capabilities to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226912/

Comment 16

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 14 - Migrate test_ext_unload_frame to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226914/

Comment 17

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 15 - Migrate test_ext_geturl to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226924/

Comment 18

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 16 - Migrate test_ext_storage_content to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226926/

Comment 19

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 17 - Migrate test_ext_storage_tab to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226928/

Comment 20

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 18 - Migrate test_ext_runtime_id to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226930/

Comment 21

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 19 - Migrate test_ext_permissions_xhr to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226932/

Comment 22

[Kris Maglione [:kmag]]

Comment on attachment 8957972 [details]
Bug 1444758: Part 1: Add console message matching helper to AddonTestUtils.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226884/diff/1-2/

Comment 23

[Kris Maglione [:kmag]]

Comment on attachment 8957973 [details]
Bug 1444758: Part 2: Migrate test_ext_sandbox_var to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226886/diff/1-2/

Comment 24

[Kris Maglione [:kmag]]

Comment on attachment 8957974 [details]
Bug 1444758: Part 3 - Migrate test_ext_schema to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226888/diff/1-2/

Comment 25

[Kris Maglione [:kmag]]

Comment on attachment 8957975 [details]
Bug 1444758: Part 4 - Migrate test_ext_background_api_injection to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226890/diff/1-2/

Comment 26

[Kris Maglione [:kmag]]

Comment on attachment 8957976 [details]
Bug 1444758: Part 5 - Migrate test_ext_contentscript_api_injection to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226892/diff/1-2/

Comment 27

[Kris Maglione [:kmag]]

Comment on attachment 8957977 [details]
Bug 1444758: Part 6 - Migrate test_ext_content_security_policy to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226894/diff/1-2/

Comment 28

[Kris Maglione [:kmag]]

Comment on attachment 8957978 [details]
Bug 1444758: Part 7 - Migrate test_ext_contentscript_async_loading to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226896/diff/1-2/

Comment 29

[Kris Maglione [:kmag]]

Comment on attachment 8957979 [details]
Bug 1444758: Part 8 - Migrate test_ext_contentscript_context to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226898/diff/1-2/

Comment 30

[Kris Maglione [:kmag]]

Comment on attachment 8957980 [details]
Bug 1444758: Part 9 - Migrate test_ext_contentscript_css to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226900/diff/1-2/

Comment 31

[Kris Maglione [:kmag]]

Comment on attachment 8957981 [details]
Bug 1444758: Part 10 - Migrate test_ext_contentscript_create_iframe to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226902/diff/1-2/

Comment 32

[Kris Maglione [:kmag]]

Comment on attachment 8957982 [details]
Bug 1444758: Part 11 - Migrate test_ext_contentscript_exporthelpers to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226904/diff/1-2/

Comment 33

[Kris Maglione [:kmag]]

Comment on attachment 8957983 [details]
Bug 1444758: Part 12a - Migrate test_ext_contentscript_teardown to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226906/diff/1-2/

Comment 34

[Kris Maglione [:kmag]]

Comment on attachment 8957984 [details]
Bug 1444758: Part 12b - Migrate test_ext_background_teardown to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226908/diff/1-2/

Comment 35

[Kris Maglione [:kmag]]

Comment on attachment 8957985 [details]
Bug 1444758: Part 12c - Migrate test_ext_tab_teardown to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226910/diff/1-2/

Comment 36

[Kris Maglione [:kmag]]

Comment on attachment 8957986 [details]
Bug 1444758: Part 13 - Migrate test_ext_xhr_capabilities to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226912/diff/1-2/

Comment 37

[Kris Maglione [:kmag]]

Comment on attachment 8957987 [details]
Bug 1444758: Part 14 - Migrate test_ext_unload_frame to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226914/diff/1-2/

Comment 38

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 20 - Migrate test_ext_background_generated_url to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226934/

Comment 39

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Part 21 - Migrate test_ext_eventpage_warning to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/226936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226936/

Comment 40

[Kris Maglione [:kmag]]

Attachment: Bug 1444758: Follow-up: Fix some flakiness when tests are run in parallel.

When we run tests in parallel (and probably occasionally when we don't), we
sometimes wind up getting a DOMContentLoaded event for about:blank before we
actually start loading the background page, which causes tests which rely on
the background page being loaded to fail.

This also fixes some noisy warnings from XPIProvider which make actual issues
more difficult to diagnose.

Review commit: https://reviewboard.mozilla.org/r/226942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226942/

Comment 41

[Andrew Swan [:aswan]]

Comment on attachment 8957972 [details]
Bug 1444758: Part 1: Add console message matching helper to AddonTestUtils.

https://reviewboard.mozilla.org/r/226884/#review232934

::: toolkit/mozapps/extensions/internal/AddonTestUtils.jsm:1291
(Diff revision 2)
> +   *
> +   * @param {Array<object>} messages
> +   *        The array of console messages to match.
> +   * @param {object} options
> +   *        Options describing how to perform the match.
> +   * @param {Array<ConsoleMessagePattern>} [expected = []]

Shouldn't this be `options.expected` (same with forbidden and forbidUnexpected)

Comment 42

[Kris Maglione [:kmag]]

Comment on attachment 8957972 [details]
Bug 1444758: Part 1: Add console message matching helper to AddonTestUtils.

https://reviewboard.mozilla.org/r/226884/#review232934

> Shouldn't this be `options.expected` (same with forbidden and forbidUnexpected)

Yes. Weird that ESLint didn't complain...

Comment 43

[Kris Maglione [:kmag]]

Comment on attachment 8957972 [details]
Bug 1444758: Part 1: Add console message matching helper to AddonTestUtils.

https://reviewboard.mozilla.org/r/226884/#review232934

> Shouldn't this be `options.expected` (same with forbidden and forbidUnexpected)

Yes. Weird that ESLint didn't complain...

Comment 44

[Andrew Swan [:aswan]]

Comment on attachment 8957973 [details]
Bug 1444758: Part 2: Migrate test_ext_sandbox_var to xpcshell.

https://reviewboard.mozilla.org/r/226886/#review232940

Comment 45

[Andrew Swan [:aswan]]

Comment on attachment 8957974 [details]
Bug 1444758: Part 3 - Migrate test_ext_schema to xpcshell.

https://reviewboard.mozilla.org/r/226888/#review232944

Comment 46

[Andrew Swan [:aswan]]

Comment on attachment 8957975 [details]
Bug 1444758: Part 4 - Migrate test_ext_background_api_injection to xpcshell.

https://reviewboard.mozilla.org/r/226890/#review232946

Comment 47

[Andrew Swan [:aswan]]

Comment on attachment 8957976 [details]
Bug 1444758: Part 5 - Migrate test_ext_contentscript_api_injection to xpcshell.

https://reviewboard.mozilla.org/r/226892/#review232950

Comment 48

[Andrew Swan [:aswan]]

Comment on attachment 8957977 [details]
Bug 1444758: Part 6 - Migrate test_ext_content_security_policy to xpcshell.

https://reviewboard.mozilla.org/r/226894/#review232954

Comment 49

[Andrew Swan [:aswan]]

Comment on attachment 8957978 [details]
Bug 1444758: Part 7 - Migrate test_ext_contentscript_async_loading to xpcshell.

https://reviewboard.mozilla.org/r/226896/#review232958

Comment 50

[Andrew Swan [:aswan]]

Comment on attachment 8957979 [details]
Bug 1444758: Part 8 - Migrate test_ext_contentscript_context to xpcshell.

https://reviewboard.mozilla.org/r/226898/#review232966

Comment 51

[Andrew Swan [:aswan]]

Comment on attachment 8957980 [details]
Bug 1444758: Part 9 - Migrate test_ext_contentscript_css to xpcshell.

https://reviewboard.mozilla.org/r/226900/#review232968

Comment 52

[Andrew Swan [:aswan]]

Comment on attachment 8957981 [details]
Bug 1444758: Part 10 - Migrate test_ext_contentscript_create_iframe to xpcshell.

https://reviewboard.mozilla.org/r/226902/#review232970

Comment 53

[Andrew Swan [:aswan]]

Comment on attachment 8957982 [details]
Bug 1444758: Part 11 - Migrate test_ext_contentscript_exporthelpers to xpcshell.

https://reviewboard.mozilla.org/r/226904/#review232972

Comment 54

[Andrew Swan [:aswan]]

Comment on attachment 8957983 [details]
Bug 1444758: Part 12a - Migrate test_ext_contentscript_teardown to xpcshell.

https://reviewboard.mozilla.org/r/226906/#review232976

Comment 55

[Andrew Swan [:aswan]]

Comment on attachment 8957984 [details]
Bug 1444758: Part 12b - Migrate test_ext_background_teardown to xpcshell.

https://reviewboard.mozilla.org/r/226908/#review232982

Comment 56

[Andrew Swan [:aswan]]

Comment on attachment 8957985 [details]
Bug 1444758: Part 12c - Migrate test_ext_tab_teardown to xpcshell.

https://reviewboard.mozilla.org/r/226910/#review232984

Was there some reason this used to test browser.tabs.create and window.open separately?

Comment 57

[Kris Maglione [:kmag]]

Comment on attachment 8957985 [details]
Bug 1444758: Part 12c - Migrate test_ext_tab_teardown to xpcshell.

https://reviewboard.mozilla.org/r/226910/#review232984

Possibly, but I think it was massive overkill. They both open tab pages. The lifecycle is the same.

Comment 58

[Andrew Swan [:aswan]]

Comment on attachment 8957986 [details]
Bug 1444758: Part 13 - Migrate test_ext_xhr_capabilities to xpcshell.

https://reviewboard.mozilla.org/r/226912/#review233016

Comment 59

[Andrew Swan [:aswan]]

Comment on attachment 8957997 [details]
Bug 1444758: Part 15 - Migrate test_ext_geturl to xpcshell.

https://reviewboard.mozilla.org/r/226924/#review233042

Comment 60

[Andrew Swan [:aswan]]

Comment on attachment 8957987 [details]
Bug 1444758: Part 14 - Migrate test_ext_unload_frame to xpcshell.

https://reviewboard.mozilla.org/r/226914/#review233044

Comment 61

[Andrew Swan [:aswan]]

Comment on attachment 8957998 [details]
Bug 1444758: Part 16 - Migrate test_ext_storage_content to xpcshell.

https://reviewboard.mozilla.org/r/226926/#review233046

Comment 62

[Andrew Swan [:aswan]]

Comment on attachment 8957999 [details]
Bug 1444758: Part 17 - Migrate test_ext_storage_tab to xpcshell.

https://reviewboard.mozilla.org/r/226928/#review233048

Comment 63

[Andrew Swan [:aswan]]

Comment on attachment 8958000 [details]
Bug 1444758: Part 18 - Migrate test_ext_runtime_id to xpcshell.

https://reviewboard.mozilla.org/r/226930/#review233050

Comment 64

[Andrew Swan [:aswan]]

Comment on attachment 8958001 [details]
Bug 1444758: Part 19 - Migrate test_ext_permissions_xhr to xpcshell.

https://reviewboard.mozilla.org/r/226932/#review233054

Comment 65

[Andrew Swan [:aswan]]

Comment on attachment 8958001 [details]
Bug 1444758: Part 19 - Migrate test_ext_permissions_xhr to xpcshell.

https://reviewboard.mozilla.org/r/226932/#review233054

Comment 66

[Andrew Swan [:aswan]]

Comment on attachment 8958006 [details]
Bug 1444758: Part 20 - Migrate test_ext_background_generated_url to xpcshell.

https://reviewboard.mozilla.org/r/226934/#review233056

I think I would also r+ a simple removal of this test...

Comment 67

[Andrew Swan [:aswan]]

Comment on attachment 8958008 [details]
Bug 1444758: Part 21 - Migrate test_ext_eventpage_warning to xpcshell.

https://reviewboard.mozilla.org/r/226936/#review233058

Comment 68

[Andrew Swan [:aswan]]

Comment on attachment 8958010 [details]
Bug 1444758: Follow-up: Fix some flakiness when tests are run in parallel.

https://reviewboard.mozilla.org/r/226942/#review233060

Comment 69

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6390ec7df035a339d043cdd6079b416dacec19d7
Bug 1444758: Part 1: Add console message matching helper to AddonTestUtils. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c5ec164a4150bfd9e1cfe1488dd3c83ac62f37d
Bug 1444758: Part 2: Migrate test_ext_sandbox_var to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/aad0eb5b49f8f72f090d8050f214c083e2e60489
Bug 1444758: Part 3 - Migrate test_ext_schema to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/423b15cb3b3cc3896f3ecd8c36a5f85a95529391
Bug 1444758: Part 4 - Migrate test_ext_background_api_injection to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/d025331387095a92eccc0d809a9211a8f1281408
Bug 1444758: Part 5 - Migrate test_ext_contentscript_api_injection to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/79288785b4fa5c96d9f1a81e5ead8acf7bc3c492
Bug 1444758: Part 6 - Migrate test_ext_content_security_policy to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/8196ea8ba479d5a101db2e3931e43c89b7e8689e
Bug 1444758: Part 7 - Migrate test_ext_contentscript_async_loading to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/f927c4d64edbb2332a6b29d7e1249bd157aedb96
Bug 1444758: Part 8 - Migrate test_ext_contentscript_context to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/7698d507df9135738e8b944dbed57e383d7f35ed
Bug 1444758: Part 9 - Migrate test_ext_contentscript_css to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8820c9d6ee39ccd686f3eb4b70f3dcbe723d941
Bug 1444758: Part 10 - Migrate test_ext_contentscript_create_iframe to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb607c6c60a7467ebce866c6ae71a02a7ca68e35
Bug 1444758: Part 11 - Migrate test_ext_contentscript_exporthelpers to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/2da658cde8869439e839754481d9c5248c011940
Bug 1444758: Part 12a - Migrate test_ext_contentscript_teardown to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/97d0c1047cfab1d5ed1e000af5f4e7492eb41efa
Bug 1444758: Part 12b - Migrate test_ext_background_teardown to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/58e9f616332dc96835598f8aca025ab3973da47d
Bug 1444758: Part 12c - Migrate test_ext_tab_teardown to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/108ff2d828bb3c01d3a5d4e26e3dde56430e8201
Bug 1444758: Part 13 - Migrate test_ext_xhr_capabilities to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/546f73d3fc888160057bf544b072de3888bdb707
Bug 1444758: Part 14 - Migrate test_ext_unload_frame to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7a34b3beb82b55587bf7335063574a072bc4d9d
Bug 1444758: Part 15 - Migrate test_ext_geturl to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd302ace4a373d2bb27a819613a3c07fd6311e29
Bug 1444758: Part 16 - Migrate test_ext_storage_content to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/96e9a1bed72a109c8b6488a734e6217b14985db2
Bug 1444758: Part 17 - Migrate test_ext_storage_tab to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/db61caf2e434e819e3fac9ddf61d1d7944c1dd3c
Bug 1444758: Part 18 - Migrate test_ext_runtime_id to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca5ac83d40820d9d178cbfba14c4b6f04189bcec
Bug 1444758: Part 19 - Migrate test_ext_permissions_xhr to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea79fd9c2fe39af8ea1ba2a59913676563f0fe0b
Bug 1444758: Part 20 - Remove test_ext_background_generated_url. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/47b789279e13d4dbc3fca85f8e4d418ef23670d7
Bug 1444758: Part 21 - Migrate test_ext_eventpage_warning to xpcshell. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cbcfa64364bdf2f74e552f0d3e0cfafd7756ae6
Bug 1444758: Follow-up: Fix some flakiness when tests are run in parallel. r=aswan

Comment 70

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72fd699e5741cdaff9f4f688bf488dcef06260cc
Bug 1444758: Follow-up: Disable test_ext_unload_frame for too frequent intermittent failures. r=bustage DONTBUILD

Comment 71

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6390ec7df035
https://hg.mozilla.org/mozilla-central/rev/4c5ec164a415
https://hg.mozilla.org/mozilla-central/rev/aad0eb5b49f8
https://hg.mozilla.org/mozilla-central/rev/423b15cb3b3c
https://hg.mozilla.org/mozilla-central/rev/d02533138709
https://hg.mozilla.org/mozilla-central/rev/79288785b4fa
https://hg.mozilla.org/mozilla-central/rev/8196ea8ba479
https://hg.mozilla.org/mozilla-central/rev/f927c4d64edb
https://hg.mozilla.org/mozilla-central/rev/7698d507df91
https://hg.mozilla.org/mozilla-central/rev/b8820c9d6ee3
https://hg.mozilla.org/mozilla-central/rev/bb607c6c60a7
https://hg.mozilla.org/mozilla-central/rev/2da658cde886
https://hg.mozilla.org/mozilla-central/rev/97d0c1047cfa
https://hg.mozilla.org/mozilla-central/rev/58e9f616332d
https://hg.mozilla.org/mozilla-central/rev/108ff2d828bb
https://hg.mozilla.org/mozilla-central/rev/546f73d3fc88
https://hg.mozilla.org/mozilla-central/rev/d7a34b3beb82
https://hg.mozilla.org/mozilla-central/rev/bd302ace4a37
https://hg.mozilla.org/mozilla-central/rev/96e9a1bed72a
https://hg.mozilla.org/mozilla-central/rev/db61caf2e434
https://hg.mozilla.org/mozilla-central/rev/ca5ac83d4082
https://hg.mozilla.org/mozilla-central/rev/ea79fd9c2fe3
https://hg.mozilla.org/mozilla-central/rev/47b789279e13
https://hg.mozilla.org/mozilla-central/rev/2cbcfa64364b
https://hg.mozilla.org/mozilla-central/rev/72fd699e5741

Comment 72

[Rob Wu [:robwu]]

Comment on attachment 8957985 [details]
Bug 1444758: Part 12c - Migrate test_ext_tab_teardown to xpcshell.

https://reviewboard.mozilla.org/r/226910/#review232984

FYI:

The browser.tabs.create test was a sanity check,
the window.open test was a time-sensitive regression test for https://bugzil.la/1288901

The window.open case should have behaved identically to the reference test (sanity check), but it did not until that bug was fixed. In this refactor, the test coverage by the regression test is lost. This means that if there is the context destruction logic ever changes, that bug 1288901 might be re-introduced again.