Closed Bug 1445537 Opened 6 years ago Closed 6 years ago
Action popup channels disconnect when the frameloader is reparented
STR: 1. Start Firefox with new profile. 2. Install uBlock Origin. 3. Click uBlock icon in toolbar. 4. Click "Open the logger"(or "Open the dashboard") icon. ER: Logger(or Dashboard) tab opened. AR: Nothing happened. No tab opened. No messages in Browser Console. However, right-click on "Open the logger"(or "Open the dashboard") icon and click "Open Link in ..." does work. Logger(or Dashboard) opened. mozregression: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3e60aeb17f19c7f62c72db721e380598e02f9f09&tochange=2cbcfa64364bdf2f74e552f0d3e0cfafd7756ae6
"Enter element ..." icons are not working also...
There is a major regression for uMatrix and uBlock Origin with Nightly 61.0a1 (2018-03-14) (64-bit): https://github.com/gorhill/uMatrix/issues/968 https://github.com/gorhill/uBlock/issues/3605 There are no error messages at the console. Stepping into the code, I see that Port.postMessage() from the popup menu seems to no longer work, the receiving end (background page) is not receiving any message.
This specific commit seems of interest given my observation that Port.postMessage() appears broken: https://hg.mozilla.org/integration/mozilla-inbound/rev/546f73d3fc88
Reproduced with both uBlock and uMatrix on latest Nightly.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Link in arrow-panel of toolbar-icon doesn't work → browserAction popup channels disconnect when the frameloader is reparented
Comment on attachment 8959017 [details] Bug 1445537: Track frameloader swaps when monitoring for channel disconnections. https://reviewboard.mozilla.org/r/227884/#review233762 Any hope of testing this? ::: commit-message-18b2f:6 (Diff revision 1) > +Bug 1445537: Track frameloader swaps when monitoring for channel disconnections. r?aswan > + > +When we swap <browser> frameloaders, the message managers on the parent side > +also change. And since a frameloader swap is usually followed by the original > +<browser> and its message manager being destroyed, this leads us to think the > +message manager has disconneced earlier than it actually does. nit typo
Attachment #8959017 - Flags: review?(aswan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ed4300a066b74d9f7dc2a8c24062f6691c11edb Bug 1445537: Track frameloader swaps when monitoring for channel disconnections. r=aswan
Attachment #8959017 - Attachment is obsolete: true
Comment on attachment 8959062 [details] Bug 1445537: Follow-up: Add test. https://reviewboard.mozilla.org/r/227956/#review234054
Attachment #8959062 - Flags: review?(aswan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/96cc6b100b3d729900ef221675f74505da4a2a15 Bug 1445537: Follow-up: Add test. r=aswan
You need to log in before you can comment on or make changes to this bug.