1445537 - browserAction popup channels disconnect when the frameloader is reparented

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[atlanto]

STR:
1. Start Firefox with new profile.
2. Install uBlock Origin.
3. Click uBlock icon in toolbar.
4. Click "Open the logger"(or "Open the dashboard") icon.

ER:
Logger(or Dashboard) tab opened.

AR:
Nothing happened. No tab opened. No messages in Browser Console.
However, right-click on "Open the logger"(or "Open the dashboard") icon and click "Open Link in ..." does work. Logger(or Dashboard) opened.

mozregression:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3e60aeb17f19c7f62c72db721e380598e02f9f09&tochange=2cbcfa64364bdf2f74e552f0d3e0cfafd7756ae6

Comment 1

[atlanto]

"Enter element ..." icons are not working also...

Comment 2

[[e-mail]]

There is a major regression for uMatrix and uBlock Origin with Nightly 61.0a1 (2018-03-14) (64-bit):
https://github.com/gorhill/uMatrix/issues/968
https://github.com/gorhill/uBlock/issues/3605

There are no error messages at the console. Stepping into the code, I see that Port.postMessage() from the popup menu seems to no longer work, the receiving end (background page) is not receiving any message.

Comment 3

[[e-mail]]

This specific commit seems of interest given my observation that Port.postMessage() appears broken:
https://hg.mozilla.org/integration/mozilla-inbound/rev/546f73d3fc88

Comment 4

[Clément Lefèvre]

Reproduced with both uBlock and uMatrix on latest Nightly.

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1445537: Track frameloader swaps when monitoring for channel disconnections.

When we swap <browser> frameloaders, the message managers on the parent side
also change. And since a frameloader swap is usually followed by the original
<browser> and its message manager being destroyed, this leads us to think the
message manager has disconneced earlier than it actually does.

Review commit: https://reviewboard.mozilla.org/r/227884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227884/

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 8959017 [details]
Bug 1445537: Track frameloader swaps when monitoring for channel disconnections.

https://reviewboard.mozilla.org/r/227884/#review233762

Any hope of testing this?

::: commit-message-18b2f:6
(Diff revision 1)
> +Bug 1445537: Track frameloader swaps when monitoring for channel disconnections. r?aswan
> +
> +When we swap <browser> frameloaders, the message managers on the parent side
> +also change. And since a frameloader swap is usually followed by the original
> +<browser> and its message manager being destroyed, this leads us to think the
> +message manager has disconneced earlier than it actually does.

nit typo

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ed4300a066b74d9f7dc2a8c24062f6691c11edb
Bug 1445537: Track frameloader swaps when monitoring for channel disconnections. r=aswan

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1445537: Follow-up: Add test.

Review commit: https://reviewboard.mozilla.org/r/227956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227956/

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6ed4300a066b

Comment 10

[Andrew Swan [:aswan]]

Comment on attachment 8959062 [details]
Bug 1445537: Follow-up: Add test.

https://reviewboard.mozilla.org/r/227956/#review234054

Comment 11

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96cc6b100b3d729900ef221675f74505da4a2a15
Bug 1445537: Follow-up: Add test. r=aswan

Comment 12

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/96cc6b100b3d