Closed Bug 1445004 Opened 6 years ago Closed 6 years ago

In reply to status text is not cleared properly

Categories

(Thunderbird :: Instant Messaging, defect)

Product:
Thunderbird
Component:
Instant Messaging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr60 fixed, thunderbird60 wontfix, thunderbird61 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 61.0
Tracking Flags:
Tracking Status
thunderbird_esr60 --- fixed
thunderbird60 --- wontfix
thunderbird61 --- fixed

People

(Reporter: freaktechnik, Assigned: freaktechnik)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

bug1445004-v2.patch
995 bytes, patch
florian
: review+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review 
When emptying the input field when replying, the status text is set to null and not hidden, because .length is undefined on null.
Attached patch bug1445004-v1.patch (obsolete) — — Splinter Review 
I've opted to set it to the empty string instead of detecting a null/undefined on the view side. That'd be another possible approach for a fix.
Assignee: nobody → martin
Status: NEW → ASSIGNED
Attachment #8958195 - Flags: review?(florian)
Comment on attachment 8958195 [details] [diff] [review]
bug1445004-v1.patch

I would prefer making https://searchfox.org/comm-central/source/mail/components/im/content/imconversation.xml#1544
           this._statusText = aData || "";


Note: if we wanted to change this on the twitter.js side, I would have said "nit: double quotes".
Attachment #8958195 - Flags: review?(florian)
This is a regression from https://hg.mozilla.org/comm-central/rev/c1bac684acda#l7.12 so maybe we should uplift the fix.

        Attachment #8958195 -
        Attachment is obsolete: true

        Attachment #8961292 -
        Flags: review?(florian)

    
    

    
  
Comment on attachment 8961292 [details] [diff] [review]
bug1445004-v2.patch

Review of attachment 8961292 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

        Attachment #8961292 -
        Flags: review?(florian) → review+

    
  
Keywords: checkin-needed

    
    

    
  
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/66fb0dcc4dcf
Set status text to empty string to clear. r=florian
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Component: Twitter → Instant Messaging
Product: Chat Core → Thunderbird
Target Milestone: --- → Thunderbird 61.0
Version: trunk → unspecified

        Attachment #8961292 -
        Flags: approval-comm-esr60+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: