1445004 - In reply to status text is not cleared properly

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Martin Giger [:freaktechnik]]

When emptying the input field when replying, the status text is set to null and not hidden, because .length is undefined on null.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: bug1445004-v1.patch

I've opted to set it to the empty string instead of detecting a null/undefined on the view side. That'd be another possible approach for a fix.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8958195 [details] [diff] [review]
bug1445004-v1.patch

I would prefer making https://searchfox.org/comm-central/source/mail/components/im/content/imconversation.xml#1544
           this._statusText = aData || "";


Note: if we wanted to change this on the twitter.js side, I would have said "nit: double quotes".

Comment 3

[Florian Quèze [:florian]]

This is a regression from https://hg.mozilla.org/comm-central/rev/c1bac684acda#l7.12 so maybe we should uplift the fix.

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: bug1445004-v2.patch

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8961292 [details] [diff] [review]
bug1445004-v2.patch

Review of attachment 8961292 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/66fb0dcc4dcf
Set status text to empty string to clear. r=florian

Comment 7

[Jorg K (CEST = GMT+2)]

TB 60 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/2bd394f6795d2791b65545230c5a80a72b70d204