1445113 - Remove duplicate static atoms

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nicholas Nethercote [inactive]]

There are 148 static atoms that are duplicated, i.e. we end up with multiple handles to the same unique static. For example nsGkAtoms::set and nsGkAtoms::set_, or nsGkAtoms::abbr and nsHTMLTags::sTagAtomTable[eHTML_abbr].

This affects how static atoms are represented: it requires a level of indirection, so that two handles can point to the same actual atom. Eventually I want to avoid this indirection and just refer to static atoms directly with static addresses -- e.g. nsGkAtom::set is the actual atom, rather than a pointer to the atom, and we can just use &nsGkAtom::set directly. But that won't work if there are duplicates like &nsGkAtom::set_, because it would break atom pointer equality.

So I want to remove all the duplicates.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1445113 - Disallow duplicate static atoms.

This will allow us to work with direct pointers to static atoms that are
initialized at compile-time, rather than pointers to pointers to static atoms
that are initialized at runtime.

Review commit: https://reviewboard.mozilla.org/r/232196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232196/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8963291 [details]
Bug 1445113 - Disallow duplicate static atoms.

https://reviewboard.mozilla.org/r/232196/#review237696

\o/

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1f212076daf6ac0d55a7e7f2c8d1ffc7001f9ac
Bug 1445113 - Disallow duplicate static atoms. r=froydnj

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c1f212076daf