Closed Bug 1445113 Opened 3 years ago Closed 3 years ago
Remove duplicate static atoms
There are 148 static atoms that are duplicated, i.e. we end up with multiple handles to the same unique static. For example nsGkAtoms::set and nsGkAtoms::set_, or nsGkAtoms::abbr and nsHTMLTags::sTagAtomTable[eHTML_abbr]. This affects how static atoms are represented: it requires a level of indirection, so that two handles can point to the same actual atom. Eventually I want to avoid this indirection and just refer to static atoms directly with static addresses -- e.g. nsGkAtom::set is the actual atom, rather than a pointer to the atom, and we can just use &nsGkAtom::set directly. But that won't work if there are duplicates like &nsGkAtom::set_, because it would break atom pointer equality. So I want to remove all the duplicates.
Comment on attachment 8963291 [details] Bug 1445113 - Disallow duplicate static atoms. https://reviewboard.mozilla.org/r/232196/#review237696 \o/
Attachment #8963291 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1f212076daf6ac0d55a7e7f2c8d1ffc7001f9ac Bug 1445113 - Disallow duplicate static atoms. r=froydnj
You need to log in before you can comment on or make changes to this bug.