1445142 - Remove DefaultAtoms

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nicholas Nethercote [inactive]]

By moving initialization of nsGkAtoms earlier we can remove the need for DefaultAtoms.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1445142 - Move nsGkAtoms into xpcom/.

This list of atoms isn't particularly DOM-ish, and having it in xpcom/ will
help with the next patch.

Review commit: https://reviewboard.mozilla.org/r/227310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227310/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1445142 - Remove DefaultAtoms.

Now that nsGkAtoms is in xpcom/, we can call nsGkAtoms::AddRefAtoms() from
NS_InitAtomTable(), which removes the need for DefaultAtoms, and also removes a
duplicate static atom.

Review commit: https://reviewboard.mozilla.org/r/227312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227312/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8958359 [details]
Bug 1445142 - Move nsGkAtoms into xpcom/.

https://reviewboard.mozilla.org/r/227310/#review233576

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8958360 [details]
Bug 1445142 - Remove DefaultAtoms.

https://reviewboard.mozilla.org/r/227312/#review233578

Hooray!

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db6dd2cb13467174ed3e82e19e051369c98aec7a
Bug 1445142 - Move nsGkAtoms into xpcom/. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/eff7afcc10757825d16a89b7773a2c147524f8ff
Bug 1445142 - Remove DefaultAtoms. r=froydnj

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/db6dd2cb1346
https://hg.mozilla.org/mozilla-central/rev/eff7afcc1075

Comment 7

[Boris Zbarsky [:bzbarsky]]

Note that this broke HTML parser regeneration by not updating parser/html/java/Makefile's mention of nsGkAtoms.h.