1445189 - Port |Bug 1424281 - Use Visual Studio 2017 15.6.0 for Windows builds| to C-C

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Since we're still using vs2015 on buildbot, we'll be pretty busted on Windows x32.

Here I'm trying to port changes from
https://hg.mozilla.org/mozilla-central/rev/87b446c458d34e890ca43f6c181e3681eec0a4ab

Comment 1

[Frank-Rainer Grahl (:frg)]

This no longer is a problem?

https://hg.mozilla.org/comm-central/rev/4ff617d6bb34

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1445189-vs2017.patch

Of these 10 changes:
browser/config/tooltool-manifests/win32/releng.manifest **
browser/config/tooltool-manifests/win64/releng.manifest **
build/build-clang/build-clang.py
build/docs/toolchains.rst
build/moz.configure/toolchain.configure
build/win32/mozconfig.vs2017
build/win64/mozconfig.vs2017 **
build/windows_toolchain.py
js/src/devtools/automation/winbuildenv.sh
python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py

I'm only porting the three marked **

Comment 3

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/a8eecfe6de793af00e98cb1488515199c5fb73fb
Port bug 1424281: Use Visual Studio 2017 15.6.0 for Windows builds. rs=bustage-fix

Comment 4

[Jorg K (CEST = GMT+2)]

(In reply to Frank-Rainer Grahl (:frg) from comment #1)
> This no longer is a problem?
Yes, it is, therefore I didn't touch Windows 32 bit.

Comment 5

[Jorg K (CEST = GMT+2)]

Well, at least "Windows XP opt" built.

Comment 6

[Jorg K (CEST = GMT+2)]

Or so I thought.
Worked here: https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=a8eecfe6de793af00e98cb1488515199c5fb73fb&selectedJob=167639768
Failed here: https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=c3a61fde32601481c7be55ba15ed60814f093075&selectedJob=167686491
Failed here: https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=8853a3eec03cab09359883f74c1659aaf9241035&selectedJob=167715200

All on the same M-C revision 8f1b2f872f0ea358a0412eb8b8687f08d4

The log says:
ERROR: This version (19.00.24213) of the MSVC compiler is not supported.
You must install Visual C++ 2017 Update 6 or newer in order to build.

So perhaps something changed on buildbot, but I can't see anything in
https://hg.mozilla.org/build/buildbotcustom/pushloghtml
https://hg.mozilla.org/build/buildbot-configs/pushloghtml

So looks like we won't have any Windows 32bit builds for a while :-(

Comment 7

[Frank-Rainer Grahl (:frg)]

> version (19.00.24213)

This is VS2015 Update 3. Should report 19.13.26128

The VS2015 toolset in VS2017 15.6 reports 19.00.24231 but can't be used for comm-central.

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: 1445189-VS2017156x86.patch

This is probably needed for the x86 builds but if the buildbots still runs under XP it won't do you any good.

Comment 9

[Jorg K (CEST = GMT+2)]

Thanks, but the problem is not that we can't compile under vs2017, the problem is that those buildbots only have vs2015.

Comment 10

[Tom Prince [:tomprince]]

I think think this probably will be closed WONTFIX. :( If I remember correctly, the base OS of the windows buildbot build workers is too old to run vs2017. I don't think it is possible to get updated build machines.

Comment 11

[Jorg K (CEST = GMT+2)]

OK, marking this as fixed since I landed something in comment #3.

Comment 12

[Jorg K (CEST = GMT+2)]

So in summary, we won't have Windows 32bit builds on Buildbot any more and hence no Dailies until they are switched to TaskCluster. That's of course a huge problem.

Comment 13

[Wayne Mery (:wsmwk)]

Or make a full on push to migrate windows users to 64bit ;)
I think we are probably not far off from being able to do that.

Comment 14

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8958604 [details] [diff] [review]
1445189-VS2017156x86.patch

SeaMonkey uses a lonely loaner buildbot system which should be able to build x86 with VS2017. Would you be ok with a revised patch which just adds a build/win32/mozconfig.vs2017? I can then change the SeaMonkey configs to point to it. can still do it in suite but would prefer it in build.

And I agree with Wayne. The next version after 60 would be released somewhere around late 2019 or 2020 so it might be time to officially drop x86. If it weren't for the MAPI bug it is already somewhat overdue. XP and Vista which needed the x86 builds are already history unless you take Server 2008 into account. I don't know many people still running x86 7 or higher. Same for Linux. Most distributions now slowly switch to x64 only. With own infrastructure in the near future the CPU cycles might be better used for something else.

Btw. Does not mean we should block local x86 building.

Comment 15

[Jorg K (CEST = GMT+2)]

Well, since VS2015 has come to an end, we can just mirror the x64 config to the x86 config and take out all the vs2015 special stuff since it equally won't work.

It would be nice to then move TB Daily x86 builds to your loaner, but I have no idea how to do that.

Comment 16

[Wayne Mery (:wsmwk)]

FWIW I've gathered some stats on Windows users derived from crash-stats at https://public.etherpad-mozilla.org/p/thunderbird-windows32bit.  The upshot is roughly 15% of release and beta users appear to be on 32-bit OS (or running thunderbird restricted to 2GB).   Not a proper study, but probably in the ball park.

Comment 17

[Frank-Rainer Grahl (:frg)]

> It would be nice to then move TB Daily x86 builds to your loaner, but I have no idea how to do that.

ewong would need to comment on this but it is not integrated into the system and I think he has just set a Nightly cron job. Couldn't you use the Windows x64 slaves or are there none or already in TC?

I did an interim SeaMonkey fix in bug 1445415 but not yet checked if it works. ewong just pushed it 3h ago.

FRG

Comment 18

[Richard Marti (:Paenglab)]

What about using TaskCluster to create the 32 bit builds and Dailies? Then we could also stop using XP on buildbot.

We are now past ESR 60 and could switch to full TC builds without buildbot like FX.

Comment 19

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #18)
> What about using TaskCluster to create the 32 bit builds and Dailies? Then
> we could also stop using XP on buildbot.
Sure, that is the plan.

Comment 20

[Jorg K (CEST = GMT+2)]

Looks like bug 1445415 did exactly the right thing for SM, we would need the same if we had a machine to run this on.

Comment 22

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I'm not sure there is anything I can do here at the moment.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/95d82c629b61
Use VS2017 15.6 for Windows x86 builds. r=jorgk

Comment 24

[Jorg K (CEST = GMT+2)]

I used FRG's patch to kick out vs2015 altogether to enable further ports of M-C bugs, see bug 1453317 comment #10:

https://hg.mozilla.org/comm-central/rev/7bbcca9141e8
Port bug 1453317: Update VS2017 used in automation to version 15.6.6. rs=bustage-fix