1445374 - Port Bug 1443079: nsIScriptError::Init() has another argument now

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

mailnews/base/util/nsMsgDBFolder.cpp:3571:171: error: no matching function for call to 'nsIScriptError::Init(NS_ConvertUTF8toUTF16, const nsString&, const nsString&, int, int, nsIScriptError::<anonymous enum>, const char [9])'

Patch should be easy.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1445374-nsIScriptError.patch

Local compile running :-)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9bd75170c7ae
Port Bug 1443079: nsIScriptError::Init() has another argument now. rs=bustage-fix DONTBUILD

Comment 3

[Jorg K (CEST = GMT+2)]

I don't know where the default it set in JS if the argument is omitted, but TB doesn't do "private browsing" and the M-C changeset mostly uses 'false':
https://hg.mozilla.org/mozilla-central/rev/47a89fa7cfd2

Comment 4

[:aceman]

Comment on attachment 8958559 [details] [diff] [review]
1445374-nsIScriptError.patch

Review of attachment 8958559 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 5

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 8958559 [details] [diff] [review]
1445374-nsIScriptError.patch

Review of attachment 8958559 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. JS doesn't need a change since it is [optional]. The default for optional and unspecified args is undefined, which is falsey.