1445417 - Remove nsIDOMDragEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

It's an empty interface after bug 1444686 lands.  Should be able to kill it.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop using nsIDOMDragEvent in nsIDroppedLinkHandler

MozReview-Commit-ID: DzLXJaTe4vx

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Stop using nsIDOMDragEvent in nsIDragService

MozReview-Commit-ID: 1BW1ki7sdKZ

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Stop using ndIDOMDragEvent in docshell and dom code

MozReview-Commit-ID: 21JCx8OeaR5

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove nsIDOMDragEvent

MozReview-Commit-ID: 6hQ7mHLaLcx

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8958943 [details] [diff] [review]
part 4.  Remove nsIDOMDragEvent

Review of attachment 8958943 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/UIEvent.h
@@ +125,5 @@
>    NS_FORWARD_NSIDOMUIEVENT(UIEvent::)                       \
>    NS_FORWARD_TO_EVENT_NO_SERIALIZATION_NO_DUPLICATION       \
>    using Event::GetCurrentTarget;  /* Forwarding shadows */  \
> +  using UIEvent::GetRangeParent;                            \
> +  using UIEvent::RangeOffset;                               \

NS_FORWARD_TO_UIEVENT isn't used in DragEvent AFAICT?

Why do we need to add these usings here?

Comment 6

[Boris Zbarsky [:bzbarsky]]

> NS_FORWARD_TO_UIEVENT isn't used in DragEvent AFAICT?

It's not, but it's used in MouseEvent, which is the superclass of DragEvent and a subclass of UIEvent.

> Why do we need to add these usings here?

Because otherwise when people do dragEvent->GetRangeOffset() they will get the nsIDOMUIEvent version on MouseEvent, which shadows the nice webidl version defined on UIEvent.

I could have stuck this directly on dragEvent, but I figure it might become an issue for other MouseEvent subclasses too.

Really, I should try to kill off nsIDOMUIEvent.  Filed bug 1446527 on that.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/596e1e047df8
part 1.  Stop using nsIDOMDragEvent in nsIDroppedLinkHandler.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/6438f1ffd6cb
part 2.  Stop using nsIDOMDragEvent in nsIDragService.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/003c353b9112
part 3.  Stop using ndIDOMDragEvent in docshell and dom code.  r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9a38fcd2c59
part 4.  Remove nsIDOMDragEvent.  r=mystor

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/596e1e047df8
https://hg.mozilla.org/mozilla-central/rev/6438f1ffd6cb
https://hg.mozilla.org/mozilla-central/rev/003c353b9112
https://hg.mozilla.org/mozilla-central/rev/a9a38fcd2c59