Closed
Bug 1445417
Opened 7 years ago
Closed 7 years ago
Remove nsIDOMDragEvent
Categories
(Core :: DOM: Events, enhancement)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
5.37 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
7.84 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
3.79 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
7.86 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
It's an empty interface after bug 1444686 lands. Should be able to kill it.
Assignee | ||
Comment 1•7 years ago
|
||
MozReview-Commit-ID: DzLXJaTe4vx
Attachment #8958940 -
Flags: review?(nika)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
MozReview-Commit-ID: 1BW1ki7sdKZ
Attachment #8958941 -
Flags: review?(nika)
Assignee | ||
Comment 3•7 years ago
|
||
MozReview-Commit-ID: 21JCx8OeaR5
Attachment #8958942 -
Flags: review?(nika)
Assignee | ||
Comment 4•7 years ago
|
||
MozReview-Commit-ID: 6hQ7mHLaLcx
Attachment #8958943 -
Flags: review?(nika)
Updated•7 years ago
|
Attachment #8958940 -
Flags: review?(nika) → review+
Updated•7 years ago
|
Attachment #8958941 -
Flags: review?(nika) → review+
Updated•7 years ago
|
Attachment #8958942 -
Flags: review?(nika) → review+
Comment 5•7 years ago
|
||
Comment on attachment 8958943 [details] [diff] [review]
part 4. Remove nsIDOMDragEvent
Review of attachment 8958943 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/events/UIEvent.h
@@ +125,5 @@
> NS_FORWARD_NSIDOMUIEVENT(UIEvent::) \
> NS_FORWARD_TO_EVENT_NO_SERIALIZATION_NO_DUPLICATION \
> using Event::GetCurrentTarget; /* Forwarding shadows */ \
> + using UIEvent::GetRangeParent; \
> + using UIEvent::RangeOffset; \
NS_FORWARD_TO_UIEVENT isn't used in DragEvent AFAICT?
Why do we need to add these usings here?
Attachment #8958943 -
Flags: review?(nika) → review+
Assignee | ||
Comment 6•7 years ago
|
||
> NS_FORWARD_TO_UIEVENT isn't used in DragEvent AFAICT?
It's not, but it's used in MouseEvent, which is the superclass of DragEvent and a subclass of UIEvent.
> Why do we need to add these usings here?
Because otherwise when people do dragEvent->GetRangeOffset() they will get the nsIDOMUIEvent version on MouseEvent, which shadows the nice webidl version defined on UIEvent.
I could have stuck this directly on dragEvent, but I figure it might become an issue for other MouseEvent subclasses too.
Really, I should try to kill off nsIDOMUIEvent. Filed bug 1446527 on that.
Blocks: 1387169
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/596e1e047df8
part 1. Stop using nsIDOMDragEvent in nsIDroppedLinkHandler. r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/6438f1ffd6cb
part 2. Stop using nsIDOMDragEvent in nsIDragService. r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/003c353b9112
part 3. Stop using ndIDOMDragEvent in docshell and dom code. r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9a38fcd2c59
part 4. Remove nsIDOMDragEvent. r=mystor
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/596e1e047df8
https://hg.mozilla.org/mozilla-central/rev/6438f1ffd6cb
https://hg.mozilla.org/mozilla-central/rev/003c353b9112
https://hg.mozilla.org/mozilla-central/rev/a9a38fcd2c59
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•