1445807 - Remove unsafe CPOWs in Source Editor tests

Status: RESOLVED FIXED

(DevTools :: Source Editor, enhancement)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Source Editor tests are using unsafe CPOWs, which should be avoided where possible.

Bug 1445551 will soon add `uses-unsafe-cpows` annotations in test manifests where these are used.  We should aim to get rid of them.

See https://reviewboard.mozilla.org/r/227608/diff/#index_header for a preview of tests affected.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1445807 - Remove unsafe CPOWs in Source Editor tests

Review commit: https://reviewboard.mozilla.org/r/229552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229552/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8960816 [details]
Bug 1445807 - Remove unsafe CPOWs in Source Editor tests

https://reviewboard.mozilla.org/r/229552/#review235288

Looks great to me, thanks for working on this! :)

Comment 3

[Oriol Brufau [:Oriol]]

OK, try seems green enough

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aabe57081e03
Remove unsafe CPOWs in Source Editor tests r=jryans

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/aabe57081e03