1445804 - (dt-tests-cpows) [meta] Remove unsafe CPOWs in DevTools tests

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P5)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Various tests are using unsafe CPOWs, which should be avoided where possible.  This meta-bug will collect tool-specific bugs to clean these up.  (I'm ignoring panels that are slated for removal.)

Bug 1445551 will soon add `uses-unsafe-cpows` annotations in test manifests where these are used.  We should aim to get rid of them.

Comment 1

[Oriol Brufau [:Oriol]]

Shouldn't there be a bug about cpows in the debugger?
https://searchfox.org/mozilla-central/search?q=uses-unsafe-cpow&path=debugger

There are also 3 server tests.
https://searchfox.org/mozilla-central/search?q=uses-unsafe-cpow&path=server

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Oriol Brufau [:Oriol] from comment #1)
> Shouldn't there be a bug about cpows in the debugger?
> https://searchfox.org/mozilla-central/search?q=uses-unsafe-cpow&path=debugger

This is old debugger UI which is disabled by default and slated for removal in bug 1314057.  It doesn't seem worth the effort of repairing these tests.

> There are also 3 server tests.
> https://searchfox.org/mozilla-central/search?q=uses-unsafe-cpow&path=server

Yes, these look like they should be fixed.  Want to file a bug for it?

Comment 3

[Soledad Penades [:sole] [:spenades]]

I think this bug can be closed, am I right?

Comment 4

[Julian Descottes [:jdescottes]]

Yes should be ok now that we removed the old debugger tests.

Comment 5

[Alexandre Poirot [:ochameau] [PTO back August 21]]

uses-unsafe-cpow flag, used in test ini file has been removed in bug 1495885.
While tests still using CPOWs have been refactored in bug 1492482.

So yes, this has even been fixed before old debugger removal.