Closed Bug 1446009 Opened 3 years ago Closed 3 years ago

Remove groupbox-base binding by moving groupbox.css into components.css (or by flattening it into the groupbox binding)

Categories

(Core :: XUL, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bgrins, Assigned: timdream)

References

Details

Attachments

(1 file)

groupbox-base is only extended by groupbox, and only loads a css file: https://searchfox.org/mozilla-central/rev/8fa0b32c84f924c6809c690117dbd59591f79607/toolkit/content/widgets/groupbox.xml#12.

This would make it an easy candidate for flattening into groupbox, but since this CSS is also loaded by caption (same file), we may want to take the opportunity to move the CSS into components.css to make future Custom Element migration easier, and to add another data point for what this kind CSS move will entail. 

Looking at the groupbox.css files (https://searchfox.org/mozilla-central/search?q=groupbox.css&path=) I don't *think* we'd need to make any changes to them, unless if one of the selectors is used outside of the groupbox/caption bindings, in which case we'd now be applying that CSS to nodes that didn't used to get it.
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Attachment #8960465 - Flags: review?(enndeakin)
Attachment #8960465 - Flags: review?(enndeakin) → review+
For some reason, your review flag didn't register on MozReview. Could you do that on MozReview again?
Flags: needinfo?(enndeakin)
Comment on attachment 8960465 [details]
Bug 1446009 - Remove groupbox-base binding by moving groupbox.css into components.css

https://reviewboard.mozilla.org/r/229230/#review235464
Flags: needinfo?(enndeakin)
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9a32a6c5e7a7
Remove groupbox-base binding by moving groupbox.css into components.css r=enndeakin+6102
https://hg.mozilla.org/mozilla-central/rev/9a32a6c5e7a7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.