Remove groupbox-base binding by moving groupbox.css into components.css (or by flattening it into the groupbox binding)

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bgrins, Assigned: timdream)

Tracking

(Blocks 1 bug)

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

a year ago
groupbox-base is only extended by groupbox, and only loads a css file: https://searchfox.org/mozilla-central/rev/8fa0b32c84f924c6809c690117dbd59591f79607/toolkit/content/widgets/groupbox.xml#12.

This would make it an easy candidate for flattening into groupbox, but since this CSS is also loaded by caption (same file), we may want to take the opportunity to move the CSS into components.css to make future Custom Element migration easier, and to add another data point for what this kind CSS move will entail. 

Looking at the groupbox.css files (https://searchfox.org/mozilla-central/search?q=groupbox.css&path=) I don't *think* we'd need to make any changes to them, unless if one of the selectors is used outside of the groupbox/caption bindings, in which case we'd now be applying that CSS to nodes that didn't used to get it.
Assignee: nobody → timdream
Status: NEW → ASSIGNED

Updated

a year ago
Attachment #8960465 - Flags: review?(enndeakin) → review+
For some reason, your review flag didn't register on MozReview. Could you do that on MozReview again?
Flags: needinfo?(enndeakin)

Comment 4

a year ago
mozreview-review
Comment on attachment 8960465 [details]
Bug 1446009 - Remove groupbox-base binding by moving groupbox.css into components.css

https://reviewboard.mozilla.org/r/229230/#review235464

Updated

a year ago
Flags: needinfo?(enndeakin)

Comment 5

a year ago
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9a32a6c5e7a7
Remove groupbox-base binding by moving groupbox.css into components.css r=enndeakin+6102

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9a32a6c5e7a7
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.