1446163 - Remove the splitter binding

Status: RESOLVED FIXED

(Core :: XUL, task)

Description

[Brian Grinstead [:bgrins]]

This one doesn't do much - we should be able to move splitter.css into components.css and somehow move the [extends] portion out of XBL. https://searchfox.org/mozilla-central/rev/8976abf9cab8eb4661665cc86bd355cd08238011/toolkit/content/widgets/splitter.xml#11-15

Comment 1

[Brian Grinstead [:bgrins]]

Neil, do you have an idea how we can stop relying on `extends="xul:splitter"` in XBL?

Comment 2

[Neil Deakin]

Since the tagname is already splitter, the extends doesn't do anything here and could just be removed.

Comment 3

[Potch [:potch]]

Attachment: splitter.patch

Comment 4

[Brian Grinstead [:bgrins]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=400dfd17dba2632002ad2d33791d8f8a6da6d635
Waiting for screenshot comparison at: https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=61985f03214fac9c69c36b92da3e71008e0a1fc1&newProject=try&newRev=400dfd17dba2632002ad2d33791d8f8a6da6d635

Comment 5

[Brian Grinstead [:bgrins]]

Corrected screenshot compare URL: https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=61985f03214fac9c69c36b92da3e71008e0a1fc1&newProject=try&newRev=88d501cdc09537ece36a5ddc40183355666731eb

Comment 6

[Brian Grinstead [:bgrins]]

Patch just needs reviewer added to the commit message before landing (r=enn)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b42d97021503
Remove the splitter binding r=enn

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b42d97021503

Comment 9

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336