Closed
Bug 1446163
Opened 3 years ago
Closed 3 years ago
Remove the splitter binding
Categories
(Core :: XUL, task)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bgrins, Assigned: potch)
References
Details
(Whiteboard: [xbl-available])
Attachments
(1 file)
|
2.40 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
This one doesn't do much - we should be able to move splitter.css into components.css and somehow move the [extends] portion out of XBL. https://searchfox.org/mozilla-central/rev/8976abf9cab8eb4661665cc86bd355cd08238011/toolkit/content/widgets/splitter.xml#11-15
|
Reporter | |
Comment 1•3 years ago
|
||
Neil, do you have an idea how we can stop relying on `extends="xul:splitter"` in XBL?
Flags: needinfo?(enndeakin)
|
||
Comment 2•3 years ago
|
||
Since the tagname is already splitter, the extends doesn't do anything here and could just be removed.
Flags: needinfo?(enndeakin)
|
|
Reporter | |
Updated•3 years ago
|
Whiteboard: [xbl-available]
|
|
Reporter | |
Updated•3 years ago
|
Assignee: nobody → thepotch
Status: NEW → ASSIGNED
|
Assignee | |
Comment 3•3 years ago
|
||
|
|
Reporter | |
Comment 4•3 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=400dfd17dba2632002ad2d33791d8f8a6da6d635 Waiting for screenshot comparison at: https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=61985f03214fac9c69c36b92da3e71008e0a1fc1&newProject=try&newRev=400dfd17dba2632002ad2d33791d8f8a6da6d635
|
|
Reporter | |
Comment 5•3 years ago
|
||
Corrected screenshot compare URL: https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=61985f03214fac9c69c36b92da3e71008e0a1fc1&newProject=try&newRev=88d501cdc09537ece36a5ddc40183355666731eb
|
|
Reporter | |
Updated•3 years ago
|
Attachment #8959706 -
Flags: review?(enndeakin)
|
|
||
Updated•3 years ago
|
Attachment #8959706 -
Flags: review?(enndeakin) → review+
|
|
Reporter | |
Comment 6•3 years ago
|
||
Patch just needs reviewer added to the commit message before landing (r=enn)
Keywords: checkin-needed
Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b42d97021503 Remove the splitter binding r=enn
Keywords: checkin-needed
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b42d97021503
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Comment 9•3 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
|
||
Updated•2 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•