1446313 - Port |Bug 474043 - Get rid of mimeTypes.rdf|

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

I'll start with the package manifests, let's see what else is required.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1446313-nsHandlerService.patch

M-C removed nsHandlerService and then renamed nsHandlerService-json to nsHandlerService. So the net effect is to remove nsHandlerService-json.

Marco, what else do we need to do?
Looks like we have a few references to mimeTypes.rdf still:
https://dxr.mozilla.org/comm-central/search?q=mimeTypes.rdf&redirect=false

Aceman, any insight into mimeTypes.rdf?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6111e84d64ef
Port bug 474043: Adjust names of nsHandlerService in package manifests. rs=bustage-fix

Comment 3

[Marco Bonardo [:mak]]

nsHandlerService stopped using mimetypes.rdf some time ago, in Firefox 55. It moved to a json implementation. The old implementation was retained just to allow for migrating to the new store.
Bug 474043 is just removing leftover code, though if you need to upgrade from TB52 to this version, you may still need the old code. We landed this for Firefox 61 because we're past the 60 ESR, so I hope you are also past the TB60 merge point.
You can probably also remove any leftover at that point.

Comment 4

[:aceman]

Yeah, if this still works in TB60 the code should automatically migrate all users to the json file. We can then remove the migration code in 61.
Probably the test file at mailnews/test/resources/mailTestUtils.js may need some update.
And we need to know from SM guys what they plan to do in the future, so we can know what to do with https://dxr.mozilla.org/comm-central/source/mail/components/migration/src/nsSeamonkeyProfileMigrator.cpp#34 .

Comment 5

[Jorg K (CEST = GMT+2)]

Aceman, can you please handle the remaining removal.

Comment 6

[Jorg K (CEST = GMT+2)]

Damn, I got this wrong, the thing is now called "HandlerService" without the "ns" prefix :-((

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: Take 2 - rename HandlerService

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2a3870ccd7e1
Backed out changeset 6111e84d64ef. a=jorgk
https://hg.mozilla.org/comm-central/rev/76ab402c1342
Port bug 474043: Adjust name of nsHandlerService in package manifests. rs=bustage-fix

Comment 9

[Magnus Melin [:mkmelin]]

I think this was done already. The remaining work is bug 1456405.