Closed Bug 1446313 Opened 3 years ago Closed 2 years ago

Port |Bug 474043 - Get rid of mimeTypes.rdf|


(Thunderbird :: General, enhancement)

Not set


(Not tracked)

Thunderbird 61.0


(Reporter: jorgk-bmo, Assigned: jorgk-bmo)



(1 file, 1 obsolete file)

I'll start with the package manifests, let's see what else is required.
Attached patch 1446313-nsHandlerService.patch (obsolete) — Splinter Review
M-C removed nsHandlerService and then renamed nsHandlerService-json to nsHandlerService. So the net effect is to remove nsHandlerService-json.

Marco, what else do we need to do?
Looks like we have a few references to mimeTypes.rdf still:

Aceman, any insight into mimeTypes.rdf?
Flags: needinfo?(mak77)
Flags: needinfo?(acelists)
Pushed by
Port bug 474043: Adjust names of nsHandlerService in package manifests. rs=bustage-fix
nsHandlerService stopped using mimetypes.rdf some time ago, in Firefox 55. It moved to a json implementation. The old implementation was retained just to allow for migrating to the new store.
Bug 474043 is just removing leftover code, though if you need to upgrade from TB52 to this version, you may still need the old code. We landed this for Firefox 61 because we're past the 60 ESR, so I hope you are also past the TB60 merge point.
You can probably also remove any leftover at that point.
Flags: needinfo?(mak77)
Yeah, if this still works in TB60 the code should automatically migrate all users to the json file. We can then remove the migration code in 61.
Probably the test file at mailnews/test/resources/mailTestUtils.js may need some update.
And we need to know from SM guys what they plan to do in the future, so we can know what to do with .
Flags: needinfo?(acelists)
Aceman, can you please handle the remaining removal.
Damn, I got this wrong, the thing is now called "HandlerService" without the "ns" prefix :-((
Attachment #8959486 - Attachment is obsolete: true
Pushed by
Backed out changeset 6111e84d64ef. a=jorgk
Port bug 474043: Adjust name of nsHandlerService in package manifests. rs=bustage-fix
I think this was done already. The remaining work is bug 1456405.
Assignee: nobody → jorgk
Closed: 2 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.