1446314 - Rename mIsBusy to _isBusy

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Dão Gottwald [:dao]]

Affected files:

https://searchfox.org/mozilla-central/search?q=mIsBusy&case=true&path=

Comment 1

[Vivek]

Attachment: Bug 1446314 - Rename mIsBusy to _isBusy

Review commit: https://reviewboard.mozilla.org/r/228346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228346/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8959544 [details]
Bug 1446314 - Rename mIsBusy to _isBusy

https://reviewboard.mozilla.org/r/228346/#review234242

::: browser/base/content/tabbrowser.js:1033
(Diff revision 1)
>      const nsIWebProgressListener = Ci.nsIWebProgressListener;
> -    if (newTab.hasAttribute("busy") && !this.mIsBusy) {
> -      this.mIsBusy = true;
> +    if (newTab.hasAttribute("busy") && !this._isBusy) {
> +      this._isBusy = true;
>        this._callProgressListeners(null, "onStateChange",
>                                    [webProgress, null,
>                                    nsIWebProgressListener.STATE_START |

I just touched this in bug 1446332, so this might cause conflicts when trying to land this... You might have rebase after that bug.

Comment 3

[Vivek]

Okay thanks for letting me know! I have a quick question:

- Do I wait for bug 1446332 to be marked as resolved and then pull central and rebase? Or am I supposed to do something else?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Vivek from comment #3)
> Okay thanks for letting me know! I have a quick question:
> 
> - Do I wait for bug 1446332 to be marked as resolved and then pull central
> and rebase? Or am I supposed to do something else?

That's the easiest way, yes.

Comment 5

[Dão Gottwald [:dao]]

Would you mind updating the patch so we can land it? Thanks!

Comment 6

[Vivek]

Attachment: Bug 1446314 - Rename mIsBusy to _isBusy

Review commit: https://reviewboard.mozilla.org/r/232848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232848/

Comment 7

[Vivek]

Just pushed a new patch since I'm on a different machine now.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8964052 [details]
Bug 1446314 - Rename mIsBusy to _isBusy

https://reviewboard.mozilla.org/r/232848/#review238312

Looks good, thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed6b21793386
Rename mIsBusy to _isBusy r=dao

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ed6b21793386