1446442 - Ansible tables can render completely broken and iffy on latest nightly

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect, P3)

Description

[Clément Lefèvre]

Attachment: Screenshot from 2018-03-16 17-17-40.png

By going on this webpage (https://docs.ansible.com/ansible/devel/plugins/lookup/hashi_vault.html) with latest nightly, we can see that the table is completely broken and looks iffy.
Stable render the table normally, so that's a pure regression.

See joined screenshot.

Comment 1

[Clément Lefèvre]

The second table lower on the webpage also looks broken, even though that's broken in a different way.

Comment 2

[Pascal Chevrel:pascalc]

I can reproduce:

Last good revision: 4ad2150e73c0b19f1f6264a4b9ad6927986d43ce
17:40.30 INFO: First bad revision: 37e0bd919af057d44c5c1410458c0f00a3653c11
17:40.30 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ad2150e73c0b19f1f6264a4b9ad6927986d43ce&tochange=37e0bd919af057d44c5c1410458c0f00a3653c11

This was caused by bug 1035091 which sets layout.css.moz-document.content.enabled to false on nightly/Deved. If you set this value to true, the bug disappears.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Sigh...


@-moz-document url-prefix() {
    .return-value-column td {
        height: 100%
    }
}

Comment 4

[Julien Cristau [:jcristau]]

Is this fixed by bug 1446470?

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like this landed in 59 but is preffed off for anything but nightly and early beta. 
Emilio, can you take this on or help find an owner?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

What landed in 59 and is preffed off is the @-moz-document parsing. This is a longstanding table layout difference across browsers which would need more careful investigation and such.

Maybe jet can find someone that may be interested in looking into this? Don't know who knows our table layout code other than bz / dbaron.

Comment 8

[Jet Villegas (inactive)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #6)
> This is a longstanding table layout difference across browsers which would need more careful investigation and such.

Have you got a bug # for the .td { height:100% } issue?

Comment 9

[Clément Lefèvre]

(In reply to Julien Cristau [:jcristau] from comment #4)
> Is this fixed by bug 1446470?

No, this isn't, at least some tables like ansible's doc are still completely impossible to read by default on Nightly.

Switching either layout.css.moz-document.content.enabled to true or layout.css.moz-document.url-prefix-hack.enabled to true both fix the issue

Comment 10

[Julien Cristau [:jcristau]]

layout.css.moz-document.url-prefix-hack.enabled is only false in nightly and early beta, so this won't affect 61.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Meant to say... I filed bug 1461852 on the underlying issue.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Clearly ni on Jet as he no longer works at Mozilla.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 5 duplicates.
:dholbert, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 18

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 19

[Dennis Schubert [:denschub]]

This appears to be a bug about actual breakage on sites, and the underlying core issues are all linked in the dependencies. I'll move this bug over into the right WebCompat component for tracking purposes! If this is a mistake, please poke me.

Comment 20

[Daniel Holbert [:dholbert]]

This may have been fixed, both in Firefox and on the site.

I'm testing using:

• "current Nightly" 2024-04-09 vs "old Nightly" 2018-03-16 (from around when this was filed)
• "current website" from dupe bug 1449682, https://docs.ansible.com/ansible/latest/modules/user_module.html , and "archived website" from 2018 https://web.archive.org/web/20180401091614/https://docs.ansible.com/ansible/latest/modules/user_module.html

Current website:

• Fine in current Nightly
• Fine in old Nightly

Archived website:

• Fine in current Nightly
• Broken in old Nightly (similar to screenshot in comment 0 here)

So: the archived website still reproduces the bug in old Nightly, but that's the only matchup that has trouble.

Comment 21

[Daniel Holbert [:dholbert]]

Fix range for when we started rendering the archived website "good" (no overlap):
First good revision: e803948bb3cd52dae5566bfc517e3d04f06252e7 (2020-05-26)
Last bad revision: df5bfb667b9d2fee068861b5c6129bcbbff95cce (2020-05-25)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=df5bfb667b9d2fee068861b5c6129bcbbff95cce&tochange=e803948bb3cd52dae5566bfc517e3d04f06252e7

Unsurprisingly, that contains this commit:

Emilio Cobos Álvarez — Bug 1449753 - Remove the @-moz-document url-prefix() hack preference, enable it everywhere. r=jwatt
https://hg.mozilla.org/mozilla-central/rev/3461e2c375504317fd8718fd834299779e0a081c

which is where we added back support for -moz-document-guarded CSS, and that old snapshot of Ansible seems to have had some -moz-document-guarded CSS that we in fact needed (and still do) for proper rendering of the site.

So: as a WebCompat issue, this is no longer an issue, as of bug 1449753. (Side note to clear up possible confusion: bug 1449753 is "wontfix" but it did in fact have a patch land, which rolled back our attempt to turn off moz-document parsing, and that rollback is what fixed things here.)

The thing Ansible was working around with their -moz-document-guarded CSS was & still is a legitimate interop difference between us and Chrome; I'll spin off a separate bug about that.

Comment 22

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #21)

The thing Ansible was working around with their -moz-document-guarded CSS was & still is a legitimate interop difference between us and Chrome; I'll spin off a separate bug about that.

Spun off as bug 1890937.

Comment 23

[Dennis Schubert [:denschub]]

You are right! Thanks so much for checking! :)