1446644 - DebuggerProgressListener.prototype.onStateChange errors when hovering browserAction

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect)

Description

[Oriol Brufau [:Oriol]]

1. Install a webext with a browserAction, e.g. https://addons.mozilla.org/firefox/addon/umatrix/
2. Move the mouse in and out the browserAction icon

Result: the browser console shows errors like

Handler function DebuggerProgressListener.prototype.onStateChange threw an exception: [Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsIWebProgress.DOMWindow]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js :: _docShellToWindow :: line 768"  data: no]
Stack: _docShellToWindow@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js:768:9
_docShellsToWindows/<@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js:792:38
_docShellsToWindows@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js:792:12
_notifyDocShellsUpdate@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js:796:19
DebuggerProgressListener.prototype.onStateChange<@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js:1624:7
exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
Line: 768, column: 0

Handler function DebuggerProgressListener.prototype.onStateChange threw an exception: [Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsIWebProgress.DOMWindow]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js :: DebuggerProgressListener.prototype.onStateChange< :: line 1627"  data: no]
Stack: DebuggerProgressListener.prototype.onStateChange<@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js:1627:9
exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
Line: 1627, column: 0

Regression window: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c842abb7cfbf39e0c1cfb9a1f3a1d6415cd10744&tochange=84ea422093dd615bd191a3e579ed299d96c802f1

Bug 1439472 only skipped a test, so it seems it's bug 1193394.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: screencast.gif

It seems this only happens when e10s is disabled.

Comment 2

[Oriol Brufau [:Oriol]]

Effectively https://searchfox.org/mozilla-central/rev/6e96a3f1e44e286ddae5fdafab737709741d237a/uriloader/base/nsIWebProgress.idl#129-135 can throw (but supposedly is should be a NS_ERROR_FAILURE instead of NS_NOINTERFACE.

https://searchfox.org/mozilla-central/rev/6e96a3f1e44e286ddae5fdafab737709741d237a/devtools/server/actors/tab.js#768

Comment 3

[Jim Mathies [:jimm]]

(In reply to Oriol Brufau [:Oriol] from comment #1)
> Created attachment 8959843 [details]
> screencast.gif
> 
> It seems this only happens when e10s is disabled.

Not going to fix this if it's tied to non-e10s.

Comment 4

[Oriol Brufau [:Oriol]]

(In reply to Jim Mathies [:jimm] from comment #3)
> Not going to fix this if it's tied to non-e10s.

But nsIWebProgress.DOMWindow can throw even in e10s, so a try..catch would be good.

Comment 5

[Oriol Brufau [:Oriol]]

I guess bug 1451058 will mitigate this.