1446656 - Fix AboutPreferences.jsm and/or preferences tests

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ed Lee :Mardak]

jaws, any ideas for what would cause the missing "nothing found" -> "Should be in search results" failure in browser_search_within_preferences_1.js below? I.e., what would make it find nothing but fail to display the "nothing found"?

Bug 1446186 and bug 1446392 were most likely caused by the export of bug 1404890 (attempted to land in m-c in 1446053).

In the export, we did fix up a test in browser_search_within_preferences_1.js by adding "homeContentsGroup" to the expected id visible list:
https://hg.mozilla.org/mozilla-central/diff/b0af4c10b8bb/browser/components/preferences/in-content/tests/browser_search_within_preferences_1.js

Looks like browser_search_within_preferences_1.js has an intermittent test when it tries to search for "coach" expecting to find the "nothing found", but the screenshot from bug 1446186 shows nothing appears below the search header.

TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_search_within_preferences_1.js | Should be in search results - 

Separately bug 1446392 has unexpected network to getpocket.cdn.mozilla.net from browser_privacypane_8/4.js that seems to match up with the href added for the sponsored learn more link:
https://hg.mozilla.org/mozilla-central/diff/b0af4c10b8bb/browser/extensions/activity-stream/lib/AboutPreferences.jsm#l1.239

Although I thought sponsored shouldn't be set during these tests anyway, so maybe it's another link triggering it..

Comment 1

[Ed Lee :Mardak]

Looks like the "nothing found" failures were actually caused by bug 1445084. And network was from topstories custom false test pref being reset to the firefox default.

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/70fe801fb934