1446053 - Add about:preferences section, sidebar removal and bug fixes to Activity Stream

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1446053 - Add about:preferences section, sidebar removal and bug fixes to Activity Stream.

Review commit: https://reviewboard.mozilla.org/r/228104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228104/

Comment 2

[Ed Lee :Mardak]

Comment on attachment 8959221 [details]
Bug 1446053 - Add about:preferences section, sidebar removal and bug fixes to Activity Stream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228104/diff/1-2/

Comment 3

[Ursula Sarracini (:ursula)]

Comment on attachment 8959221 [details]
Bug 1446053 - Add about:preferences section, sidebar removal and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/228104/#review233978

Looks good, land when try is green. Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0af4c10b8bb
Add about:preferences section, sidebar removal and bug fixes to Activity Stream. r=ursula

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/b0af4c10b8bb

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for frequently causing forbidden connections e.g. during browser-chrome's browser_privacypane_3.js (bug 1446392):

https://hg.mozilla.org/mozilla-central/rev/991d04043b537d38fae8f5f12252ba3b547d86b3

See 1446392 for the issue. I stumbled upon it while testing central as beta, but the issue also applies to trunk.

Retriggers on a Try push based on the push directly before this patch landed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=59b58dcc2412ee2b452504236b7c1b3151e4d96c&selectedJob=168555986&filter-searchStr=bc4

Retriggers on a Try push based on the changeset of this bug: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d3c8d6fdea974138f470054f7f96373bd4d4b2d&selectedJob=168566610&filter-searchStr=bc4

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=168566610&repo=try

GECKO(7420) | FATAL ERROR: Non-local network connections are disabled and a connection attempt to getpocket.cdn.mozilla.net (54.192.193.183) was made.
491 ERROR TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_privacypane_3.js | application terminated with exit code 1

Comment 7

[Ed Lee :Mardak]

Comment on attachment 8959221 [details]
Bug 1446053 - Add about:preferences section, sidebar removal and bug fixes to Activity Stream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228104/diff/2-3/

Comment 8

[Ed Lee :Mardak]

Comment on attachment 8959221 [details]
Bug 1446053 - Add about:preferences section, sidebar removal and bug fixes to Activity Stream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228104/diff/3-4/

Comment 9

[Ed Lee :Mardak]

Rebased on autoland (in particular bug 1417155). The pgo failure triggering network connections was caused by the custom topstories test pref set as a `false` user pref was getting cleared to the firefox default instead of the test default.

Comment 10

[Ed Lee :Mardak]

Try looks good with pgo too! https://treeherder.mozilla.org/#/jobs?repo=try&revision=047a64a29e3990597ad071b6a317f499421c9cd4&filter-searchStr=(bc&group_state=expanded

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70fe801fb934
Add about:preferences section, sidebar removal and bug fixes to Activity Stream. r=ursula

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/70fe801fb934