1446809 - Remove some b2g leftover

Comment on attachment 8960026 [details] Bug 1446809 - Remove some b2g leftover in the devtools doc https://reviewboard.mozilla.org/r/228792/#review234530 Thanks! We also have related cleanup to do for mentions of Valence (deprecated) in our docs. I will file a follow up.

Attachment #8960026 - Flags: review?(jdescottes) → review+

Julian Descottes [:jdescottes]

Updated

•

7 years ago

Blocks: 1446901

Florian Quèze [:florian]

Comment 11

•

7 years ago

mozreview-review

Comment on attachment 8960022 [details] Bug 1446809 - Remove some b2g leftover in desktop/ https://reviewboard.mozilla.org/r/228784/#review234534 ::: browser/components/BrowserComponents.manifest:34 (Diff revision 1) > # Thus we restrict it to these apps: > # > -# b2g: {3c2e2abc-06d4-11e1-ac3b-374f68613e61} > # browser: {ec8030f7-c20a-464f-9b0e-13a3a9e97384} > # mobile/android: {aa3c5121-dab2-40e2-81ca-7ea25febc110} > # mobile/xul: {a23983c0-fd0e-11dc-95ff-0800200c9a66} Could you please also remove the references to mobile/xul while you are at it? It seems similarly dead (see bug 831236).

Florian Quèze [:florian]

Comment 12

•

7 years ago

mozreview-review

Comment on attachment 8960028 [details] Bug 1446809 - Remove some b2g leftover in a service worker test https://reviewboard.mozilla.org/r/228796/#review234536 This is outside the area where I normally do reviews, but it's straightforward (and as bug 1137683 is fixed, it should have been removed independently of removing b2g anyway), so r=me.

Attachment #8960028 - Flags: review?(florian) → review+

Comment hidden (mozreview-request)

Florian Quèze [:florian]

Comment 23

•

7 years ago

mozreview-review

Comment on attachment 8960115 [details] Bug 1446809 - Ride along: also remove some mobile/xul/ legacy declaration https://reviewboard.mozilla.org/r/228904/#review234562 Thanks!

Attachment #8960115 - Flags: review?(florian) → review+

Florian Quèze [:florian]

Comment 24

•

7 years ago

mozreview-review

Comment on attachment 8960022 [details] Bug 1446809 - Remove some b2g leftover in desktop/ https://reviewboard.mozilla.org/r/228784/#review234566

Attachment #8960022 - Flags: review?(florian) → review+

James Graham [:jgraham]

Comment 25

•

7 years ago

mozreview-review

Comment on attachment 8960024 [details] Bug 1446809 - Remove some b2g leftover in the testing/mozbase https://reviewboard.mozilla.org/r/228788/#review234592 I know nothing about this, but if the tests still pass then sure.

Attachment #8960024 - Flags: review?(james) → review+

Nathan Froyd [:froydnj]

Comment 26

•

7 years ago

mozreview-review

Comment on attachment 8960025 [details] Bug 1446809 - Remove some b2g leftover in widget/NativeKeyToDOMKeyName.h https://reviewboard.mozilla.org/r/228790/#review234618

Attachment #8960025 - Flags: review?(nfroyd) → review+

Dão Gottwald [:dao]

Updated

•

7 years ago

Attachment #8960021 - Flags: review?(dao+bmo) → review?(surkov.alexander)

Julian Descottes [:jdescottes]

Comment 27

•

7 years ago

mozreview-review

Comment on attachment 8960116 [details] Bug 1446809 - Remove some b2g leftover in devtools/shared/system.js https://reviewboard.mozilla.org/r/228906/#review234874

Attachment #8960116 - Flags: review?(jdescottes) → review+

Mike Hommey [:glandium]

Comment 28

•

7 years ago

mozreview-review

Comment on attachment 8960023 [details] Bug 1446809 - Remove some b2g leftover in the build https://reviewboard.mozilla.org/r/228786/#review234958 ::: build/unix/mozconfig.linux:12 (Diff revision 2) > > -# some b2g desktop builds still happen on i686 machines, and the tooltool > +# We deal with valgrind builds here, they don't use tooltool manifests at > -# toolchain is x86_64 only. > -# We also deal with valgrind builds here, they don't use tooltool manifests at > # all yet. > if [ -z "$no_tooltool" ] You can actually remove the no_tooltool case.

Attachment #8960023 - Flags: review?(mh+mozilla) → review+

Comment hidden (mozreview-request)

alexander :surkov (:asurkov)

Comment 39

•

7 years ago

mozreview-review

Comment on attachment 8960021 [details] Bug 1446809 - Remove some b2g leftover in accessible/ https://reviewboard.mozilla.org/r/228782/#review235088 ::: accessible/jsat/Utils.jsm (Diff revision 3) > var EXPORTED_SYMBOLS = ["Utils", "Logger", "PivotContext", "PrefCache"]; // jshint ignore:line > > var Utils = { // jshint ignore:line > _buildAppMap: { > - "{3c2e2abc-06d4-11e1-ac3b-374f68613e61}": "b2g", > - "{d1bfe7d9-c01e-4237-998b-7b5f960a4314}": "graphene", graphene is something bt2 related?

Attachment #8960021 - Flags: review?(surkov.alexander) → review+

Sylvestre Ledru [:Sylvestre]

Assignee

Comment 40

•

7 years ago

"Graphene is a build of B2G used in Browser.html281 and for Firefox OS testing." :)

Pulsebot

Comment 41

•

7 years ago

Noemi Erli[:noemi_erli]

Comment 42

•

7 years ago

Flags: needinfo?(sledru)

Comment hidden (mozreview-request)

Mozilla Autoland

Comment 50

•

7 years ago

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 16999c302ed167f29795c58e6fca063d24d749be -d e001dfa526ad: rebasing 453133:16999c302ed1 "Bug 1446809 - Remove some b2g leftover in accessible/ r=surkov" merging accessible/jsat/Presentation.jsm merging accessible/jsat/Utils.jsm merging accessible/tests/mochitest/hittest/a11y.ini merging accessible/tests/mochitest/jsat/jsatcommon.js merging accessible/tests/mochitest/jsat/test_content_integration.html rebasing 453134:de1f9f5358b8 "Bug 1446809 - Remove some b2g leftover in desktop/ r=florian" merging browser/components/BrowserComponents.manifest merging browser/components/feeds/BrowserFeeds.manifest merging browser/components/sessionstore/nsSessionStore.manifest merging browser/experiments/docs/manifest.rst rebasing 453135:aea38ca61677 "Bug 1446809 - Remove some b2g leftover in the build r=glandium" merging build/docs/mozinfo.rst merging build/unix/mozconfig.linux merging toolkit/nss.configure merging toolkit/toolkit.mozbuild rebasing 453136:76102fdcc9af "Bug 1446809 - Remove some b2g leftover in the testing/mozbase r=jgraham" merging testing/mozbase/moztest/tests/test.py merging testing/mozbase/mozversion/tests/manifest.ini merging testing/mozbase/packages.txt rebasing 453137:64a403d4d46d "Bug 1446809 - Remove some b2g leftover in widget/NativeKeyToDOMKeyName.h r=froydnj" merging widget/NativeKeyToDOMKeyName.h rebasing 453138:864d906bd08e "Bug 1446809 - Remove some b2g leftover in the devtools doc r=jdescottes" merging devtools/docs/backend/actor-registration.md rebasing 453139:b37c9e91dbdd "Bug 1446809 - Remove some b2g leftover in some webgl tests r=jgilbert" merging dom/canvas/test/webgl-conf/generated-mochitest.ini merging dom/canvas/test/webgl-conf/mochitest-errata.ini rebasing 453140:2c93a7faf040 "Bug 1446809 - Remove some b2g leftover in a service worker test r=florian" merging dom/cache/test/mochitest/serviceworker_driver.js rebasing 453141:59d7a060e4a3 "Bug 1446809 - Ride along: also remove some mobile/xul/ legacy declaration r=florian" merging accessible/jsat/Utils.jsm merging browser/components/BrowserComponents.manifest merging browser/components/feeds/BrowserFeeds.manifest merging browser/components/sessionstore/nsSessionStore.manifest merging devtools/shared/system.js merging mobile/android/modules/FormAssistant.jsm merging testing/mozharness/configs/multi_locale/standalone_mozilla-central.py warning: conflicts while merging testing/mozharness/configs/multi_locale/standalone_mozilla-central.py! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment hidden (mozreview-request)

Mozilla Autoland

Comment 61

•

7 years ago

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s d3a264d53d3179d4e19963ef1da4ae1417e495b6 -d 4cf36c1b89d5: rebasing 453220:d3a264d53d31 "Bug 1446809 - Remove some b2g leftover in accessible/ r=surkov" merging accessible/jsat/Presentation.jsm merging accessible/jsat/Utils.jsm merging accessible/tests/mochitest/hittest/a11y.ini merging accessible/tests/mochitest/jsat/jsatcommon.js merging accessible/tests/mochitest/jsat/test_content_integration.html rebasing 453221:275f9afa97ee "Bug 1446809 - Remove some b2g leftover in desktop/ r=florian" merging browser/components/BrowserComponents.manifest merging browser/components/feeds/BrowserFeeds.manifest merging browser/components/sessionstore/nsSessionStore.manifest merging browser/experiments/docs/manifest.rst rebasing 453222:e20a6e376080 "Bug 1446809 - Remove some b2g leftover in the build r=glandium" merging build/docs/mozinfo.rst merging build/unix/mozconfig.linux merging toolkit/nss.configure merging toolkit/toolkit.mozbuild rebasing 453223:520b6dd0726c "Bug 1446809 - Remove some b2g leftover in the testing/mozbase r=jgraham" merging testing/mozbase/moztest/tests/test.py merging testing/mozbase/mozversion/tests/manifest.ini merging testing/mozbase/packages.txt rebasing 453224:df87d8c6572b "Bug 1446809 - Remove some b2g leftover in widget/NativeKeyToDOMKeyName.h r=froydnj" merging widget/NativeKeyToDOMKeyName.h rebasing 453225:d56a0d0fd765 "Bug 1446809 - Remove some b2g leftover in the devtools doc r=jdescottes" merging devtools/docs/backend/actor-registration.md rebasing 453226:b124db3e50d2 "Bug 1446809 - Remove some b2g leftover in some webgl tests r=jgilbert" merging dom/canvas/test/webgl-conf/generated-mochitest.ini merging dom/canvas/test/webgl-conf/mochitest-errata.ini rebasing 453227:20caff3fb18d "Bug 1446809 - Remove some b2g leftover in a service worker test r=florian" merging dom/cache/test/mochitest/serviceworker_driver.js rebasing 453228:42025f0fe946 "Bug 1446809 - Ride along: also remove some mobile/xul/ legacy declaration r=florian" merging accessible/jsat/Utils.jsm merging browser/components/BrowserComponents.manifest merging browser/components/feeds/BrowserFeeds.manifest merging browser/components/sessionstore/nsSessionStore.manifest merging devtools/shared/system.js merging mobile/android/modules/FormAssistant.jsm merging testing/mozharness/configs/multi_locale/standalone_mozilla-central.py warning: conflicts while merging testing/mozharness/configs/multi_locale/standalone_mozilla-central.py! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

Sylvestre Ledru [:Sylvestre]

Assignee

Comment 62

•

7 years ago

Natalia Csoregi [:nataliaCs]

Comment 63

•

7 years ago

Backed out for failing on jsat/test_content_integration.html backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/83e91da1cdeef25e81f23de8c883948c58d248e6 push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=42146f3856d007bba68045f84a44090efed3c498&group_state=expanded failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=169390944&repo=mozilla-inbound&lineNumber=3885 [task 2018-03-21T08:29:27.372Z] 08:29:27 INFO - TEST-START | accessible/tests/mochitest/jsat/test_content_integration.html [task 2018-03-21T08:29:28.065Z] 08:29:28 INFO - GECKO(1054) | WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts). [task 2018-03-21T08:29:28.065Z] 08:29:28 INFO - GECKO(1054) | pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:26:14 [task 2018-03-21T08:29:28.067Z] 08:29:28 INFO - GECKO(1054) | windowPrivacyMatches@chrome://browser/content/browser-sidebar.js:235:12 [task 2018-03-21T08:29:28.068Z] 08:29:28 INFO - GECKO(1054) | startDelayedLoad@chrome://browser/content/browser-sidebar.js:248:10 [task 2018-03-21T08:29:28.069Z] 08:29:28 INFO - GECKO(1054) | _delayedStartup/<@chrome://browser/content/browser.js:1596:7 [task 2018-03-21T08:29:28.070Z] 08:29:28 INFO - GECKO(1054) | promise callback*_delayedStartup@chrome://browser/content/browser.js:1587:5 [task 2018-03-21T08:29:28.072Z] 08:29:28 INFO - GECKO(1054) | EventListener.handleEvent*onLoad@chrome://browser/content/browser.js:1406:5 [task 2018-03-21T08:29:28.073Z] 08:29:28 INFO - GECKO(1054) | onload@chrome://browser/content/browser.xul:1:1 [task 2018-03-21T08:29:29.508Z] 08:29:29 INFO - GECKO(1054) | [AccessFu] INFO content-script.js chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/doc_content_integration.html [task 2018-03-21T08:29:29.513Z] 08:29:29 INFO - GECKO(1054) | [AccessFu] DEBUG AccessFu:Start [task 2018-03-21T08:29:29.518Z] 08:29:29 INFO - GECKO(1054) | [AccessFu] DEBUG EventManager.start [task 2018-03-21T08:29:29.520Z] 08:29:29 INFO - GECKO(1054) | [AccessFu] DEBUG AccessibilityEventObserver.addListener. Total: 1 [task 2018-03-21T08:29:29.541Z] 08:29:29 INFO - GECKO(1054) | [AccessFuContent] INFO content-script.js data:text/html;charset=utf-8,<html><head><title>such%20app</title></head><body><h1>wow</h1><ul><li><label><input%20type="checkbox">many%20option</label></li></ul><label%20for="r">much%20range</label><input%20min="0"%20max="10"%20value="5"%20type="range"%20id="r"></body></html> [task 2018-03-21T08:29:29.542Z] 08:29:29 INFO - GECKO(1054) | [AccessFuContent] DEBUG AccessFu:Start [task 2018-03-21T08:29:29.557Z] 08:29:29 INFO - GECKO(1054) | [AccessFuContent] DEBUG EventManager.start [task 2018-03-21T08:29:29.559Z] 08:29:29 INFO - GECKO(1054) | [AccessFuContent] DEBUG AccessibilityEventObserver.addListener. Total: 1 [task 2018-03-21T08:29:29.587Z] 08:29:29 INFO - GECKO(1054) | [AccessFu] DEBUG ContentControl.receiveMessage AccessFu:MoveCursor {"action":"moveNext","rule":"Simple","inputType":"gesture","origin":"top"} [task 2018-03-21T08:29:29.603Z] 08:29:29 INFO - GECKO(1054) | [AccessFu] DEBUG A11yEvent virtual cursor changed ([ null ] -> [ text leaf | Phone status bar ]) [ document | Traversal Rule test document ] [task 2018-03-21T08:29:29.641Z] 08:29:29 INFO - TEST-INFO | started process screentopng [task 2018-03-21T08:29:30.151Z] 08:29:30 INFO - TEST-INFO | screentopng: exit 0 [task 2018-03-21T08:29:30.151Z] 08:29:30 INFO - Buffered messages logged at 08:29:28 [task 2018-03-21T08:29:30.161Z] 08:29:30 INFO - must wait for load [task 2018-03-21T08:29:30.161Z] 08:29:30 INFO - must wait for focus [task 2018-03-21T08:29:30.161Z] 08:29:30 INFO - Buffered messages finished [task 2018-03-21T08:29:30.162Z] 08:29:30 INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/jsat/test_content_integration.html | eventType [ expected "vc-change" got undefined ] data [ Expected something but got nothing -- undefined ] -- after {"name":"AccessFu:MoveCursor","json":{"action":"moveNext","rule":"Simple","inputType":"gesture","origin":"top"}} (0) (android) [task 2018-03-21T08:29:30.162Z] 08:29:30 INFO - ExpectedPresent.prototype.is@chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/jsatcommon.js:553:7 [task 2018-03-21T08:29:30.163Z] 08:29:30 INFO - receiveMessage@chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/jsatcommon.js:316:7 [task 2018-03-21T08:29:30.163Z] 08:29:30 INFO - GECKO(1054) | [AccessFu] DEBUG ContentControl.receiveMessage AccessFu:MoveCursor {"action":"movePrevious","rule":"Simple","inputType":"gesture","origin":"top"} [task 2018-03-21T08:29:30.164Z] 08:29:30 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-03-21T08:29:30.165Z] 08:29:30 INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/jsat/test_content_integration.html | eventType [ expected "no-move" got undefined ] -- after {"name":"AccessFu:MoveCursor","json":{"action":"movePrevious","rule":"Simple","inputType":"gesture","origin":"top"}} (1) (android) [task 2018-03-21T08:29:30.166Z] 08:29:30 INFO - ExpectedPresent.prototype.is@chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/jsatcommon.js:553:7 [task 2018-03-21T08:29:30.167Z] 08:29:30 INFO - receiveMessage@chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/jsatcommon.js:316:7 [task 2018-03-21T08:29:30.168Z] 08:29:30 INFO - GECKO(1054) | [AccessFu] DEBUG ContentControl.receiveMessage AccessFu:MoveCursor {"action":"moveNext","rule":"Simple","inputType":"gesture","origin":"top"} [task 2018-03-21T08:29:30.169Z] 08:29:30 INFO - GECKO(1054) | [AccessFu] DEBUG A11yEvent virtual cursor changed ([ text leaf | Phone status bar ] -> [ pushbutton | Back ]) [ document | Traversal Rule test document ] [task 2018-03-21T08:29:30.171Z] 08:29:30 INFO - Not taking screenshot here: see the one that was previously logged

Pulsebot

Comment 64

•

7 years ago

Arthur Iakab [arthur_iakab]

Comment 65

•

7 years ago

bugherder

Status: NEW → RESOLVED

Closed: 7 years ago

status-firefox61: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla61

Sylvestre Ledru [:Sylvestre]

Assignee

Comment 66

•

7 years ago

Created bug 1448367 for the change on accessibility/

Flags: needinfo?(sledru)

Bug 1446809 - Remove some b2g leftover in accessible/ 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	surkov : review+	Details
Bug 1446809 - Remove some b2g leftover in desktop/ 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	florian : review+	Details
Bug 1446809 - Remove some b2g leftover in the build 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	glandium : review+	Details
Bug 1446809 - Remove some b2g leftover in the testing/mozbase 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	jgraham : review+	Details
Bug 1446809 - Remove some b2g leftover in widget/NativeKeyToDOMKeyName.h 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	froydnj : review+	Details
Bug 1446809 - Remove some b2g leftover in the devtools doc 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	jdescottes : review+	Details
Bug 1446809 - Remove some b2g leftover in some webgl tests 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	jgilbert : review+	Details
Bug 1446809 - Remove some b2g leftover in a service worker test 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	florian : review+	Details
Bug 1446809 - Ride along: also remove some mobile/xul/ legacy declaration 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	florian : review+	Details
Bug 1446809 - Remove some b2g leftover in devtools/shared/system.js 7 years ago Sylvestre Ledru [:Sylvestre] 59 bytes, text/x-review-board-request	jdescottes : review+	Details