Closed Bug 1446901 Opened 5 years ago Closed 5 years ago

Remove references to Valence in DevTools codebase

Categories

(DevTools :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: jdescottes, Assigned: is2ei, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug])

Attachments

(1 file)

Follow up to Bug 1446809:

  https://searchfox.org/mozilla-central/search?q=Valence&case=true&regexp=false&path=devtools

There might also be mentions of Chrome/Safari debugging not directly mentioning Valence but that should be removed.
Mentor: sledru
Keywords: good-first-bug
Whiteboard: [good first bug]
Severity: normal → enhancement
Hi, I'm Issei.
Could I work on this issue?
Sure Issei, thanks! 

You can get the list of current mentions of Valence with https://searchfox.org/mozilla-central/search?q=Valence&case=true&regexp=false&path=devtools . Looks like all the references left are in the DevTools documentation files. 

Have a look at http://docs.firefox-dev.tools/ to setup your environment. Let us know if you have any question!
Assignee: nobody → is2ei.horie
Status: NEW → ASSIGNED
I attached a patch.
Could you review it, please?
Attachment #8973260 - Flags: review?(sledru)
Comment on attachment 8973260 [details] [diff] [review]
bug-1446901.patch

Julian is probably a better reviewer than I am :)
Attachment #8973260 - Flags: review?(sledru) → review?(jdescottes)
Comment on attachment 8973260 [details] [diff] [review]
bug-1446901.patch

Review of attachment 8973260 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks a lot for the cleanup. 

I will just add r=jdescottes at the end of your commit message and push this to our integration branch!
Attachment #8973260 - Flags: review?(jdescottes) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc161a91742c
Remove references to Valence in DevTools codebase;r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/fc161a91742c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Target Milestone: Firefox 61 → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.