1446901 - Remove references to Valence in DevTools codebase

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1446809:

  https://searchfox.org/mozilla-central/search?q=Valence&case=true&regexp=false&path=devtools

There might also be mentions of Chrome/Safari debugging not directly mentioning Valence but that should be removed.

Comment 1

[Issei Horie [:is2ei]]

Hi, I'm Issei.
Could I work on this issue?

Comment 2

[Julian Descottes [:jdescottes]]

Sure Issei, thanks! 

You can get the list of current mentions of Valence with https://searchfox.org/mozilla-central/search?q=Valence&case=true&regexp=false&path=devtools . Looks like all the references left are in the DevTools documentation files. 

Have a look at http://docs.firefox-dev.tools/ to setup your environment. Let us know if you have any question!

Comment 3

[Issei Horie [:is2ei]]

Attachment: bug-1446901.patch

I attached a patch.
Could you review it, please?

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8973260 [details] [diff] [review]
bug-1446901.patch

Julian is probably a better reviewer than I am :)

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8973260 [details] [diff] [review]
bug-1446901.patch

Review of attachment 8973260 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks a lot for the cleanup. 

I will just add r=jdescottes at the end of your commit message and push this to our integration branch!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc161a91742c
Remove references to Valence in DevTools codebase;r=jdescottes

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fc161a91742c