1446878 - If there's only one recipient, it can't be removed using the new delete icon button

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, enhancement)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1100103 +++

STR

1.) Write message with only one recipient (or delete all others)
2.) Try to delete that only recipient with the new delete icon (from hovering recipient type selector)

Actual result
- nothing happens

Expected result
- the email address should be removed, but the recipient input field with type selector should stay (and according to documentation of awDeleteHit(), that's exactly what should happen)

This looks like a pre-existing bug, but with Bug 1100103 it's now more exposed.

https://dxr.mozilla.org/comm-central/rev/a8eecfe6de793af00e98cb1488515199c5fb73fb/mail/components/compose/content/addressingWidgetOverlay.js#539-548

Comment 1

[:aceman]

Thanks for noticing.
It is new bug, because in the added call awDeleteHit(this), 'this' isn't the inputelement of the recipient address as the function would expect. That is why it does not clear the right field.

Comment 2

[:aceman]

Attachment: 1446878.patch

This works for me.
But I am not happy about hard-coding the element hierarchy in this way.

Comment 3

[:aceman]

Attachment: 1446878.patch v2

This could be safer.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8960089 [details] [diff] [review]
1446878.patch v2

Not super-nice but working, thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/67239778cb19
bug 1100103 follow-up: pass the right input element into awDeleteHit. r=jorgk

Comment 6

[Jorg K (CEST = GMT+2)]

Beta (TB 60):
https://hg.mozilla.org/releases/comm-beta/rev/3f6164d3285b9737c65a916e8bf8c7ef71f8f4c2