If there's only one recipient, it can't be removed using the new delete icon button

RESOLVED FIXED in Thunderbird 61.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: bugzilla2007, Assigned: aceman)

Tracking

Thunderbird 61.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird60 fixed, thunderbird61 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

Last year
+++ This bug was initially created as a clone of Bug #1100103 +++

STR

1.) Write message with only one recipient (or delete all others)
2.) Try to delete that only recipient with the new delete icon (from hovering recipient type selector)

Actual result
- nothing happens

Expected result
- the email address should be removed, but the recipient input field with type selector should stay (and according to documentation of awDeleteHit(), that's exactly what should happen)

This looks like a pre-existing bug, but with Bug 1100103 it's now more exposed.

https://dxr.mozilla.org/comm-central/rev/a8eecfe6de793af00e98cb1488515199c5fb73fb/mail/components/compose/content/addressingWidgetOverlay.js#539-548
Assignee

Comment 1

Last year
Thanks for noticing.
It is new bug, because in the added call awDeleteHit(this), 'this' isn't the inputelement of the recipient address as the function would expect. That is why it does not clear the right field.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Version: 31 Branch → 60
Assignee

Comment 2

Last year
Posted patch 1446878.patch (obsolete) — Splinter Review
This works for me.
But I am not happy about hard-coding the element hierarchy in this way.
Attachment #8960087 - Flags: review?(jorgk)
Attachment #8960087 - Flags: feedback?(richard.marti)
Assignee

Comment 3

Last year
This could be safer.
Attachment #8960087 - Attachment is obsolete: true
Attachment #8960087 - Flags: review?(jorgk)
Attachment #8960087 - Flags: feedback?(richard.marti)
Attachment #8960089 - Flags: review?(jorgk)
Attachment #8960089 - Flags: feedback?(richard.marti)

Comment 4

Last year
Comment on attachment 8960089 [details] [diff] [review]
1446878.patch v2

Not super-nice but working, thanks.
Attachment #8960089 - Flags: review?(jorgk) → review+

Comment 5

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/67239778cb19
bug 1100103 follow-up: pass the right input element into awDeleteHit. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 61.0

Updated

Last year
Attachment #8960089 - Flags: feedback?(richard.marti) → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.