Closed Bug 1446878 Opened 2 years ago Closed 2 years ago
If there's only one recipient, it can't be removed using the new delete icon button
+++ This bug was initially created as a clone of Bug #1100103 +++ STR 1.) Write message with only one recipient (or delete all others) 2.) Try to delete that only recipient with the new delete icon (from hovering recipient type selector) Actual result - nothing happens Expected result - the email address should be removed, but the recipient input field with type selector should stay (and according to documentation of awDeleteHit(), that's exactly what should happen) This looks like a pre-existing bug, but with Bug 1100103 it's now more exposed. https://dxr.mozilla.org/comm-central/rev/a8eecfe6de793af00e98cb1488515199c5fb73fb/mail/components/compose/content/addressingWidgetOverlay.js#539-548
Thanks for noticing. It is new bug, because in the added call awDeleteHit(this), 'this' isn't the inputelement of the recipient address as the function would expect. That is why it does not clear the right field.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Version: 31 Branch → 60
This works for me. But I am not happy about hard-coding the element hierarchy in this way.
This could be safer.
Comment on attachment 8960089 [details] [diff] [review] 1446878.patch v2 Not super-nice but working, thanks.
Attachment #8960089 - Flags: review?(jorgk) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/67239778cb19 bug 1100103 follow-up: pass the right input element into awDeleteHit. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Attachment #8960089 - Flags: feedback?(richard.marti) → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.