1446905 - [Linux] Toolbar button hover state and the pop-up menu should dismiss when click to another toolbar button with pop-up menu

Status: NEW

(Core :: Widget: Gtk, defect, P5)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: rec2-1.ogv

[Affected versions]:
Firefox 59.0.1
Firefox 60.0b4
Firefox Nightly 61.0a1 (2018.03.16)

[Affected platforms]:
Ubuntu 14.04 x64

[Steps to reproduce]:
1.Launch Firefox.
2.Click on "View history, saved bookmarks, and more" opened a pop-up menu then on "Hamburger" menu or "Overflow Menu" from toolbar opened another pop-up menu.

[Expected result]:
When you click to the second button (Hamburger menu button or Overflow menu) expect to dissmis the hover state and the pop-up menu of the first button. 

[Actual result]:
The hover state and the pop-up menu not dismissed when you click to another toolbar button witch opened a pop-up menu too.

[Additional Information]:
Please observe the attached video for more details. In attachment I change the theme but the issue is there using default theme or any other light theme.

Comment 1

[:Gijs (out for now; he/him)]

(In reply to Timea Zsoldos from comment #0)
> [Affected platforms]:
> Ubuntu 14.04 x64

Does this not reproduce on Ubuntu 16.04 ? Does the issue reproduce with esr52 ? What version of gnome/x11 is this running?

This and some of the other linux-specific issues you filed smell like issues with the window manager / linux platform stuff, rather than frontend, even if that's where the problems manifest themselves...

Also, you've checked that ui.popup.disable_autohide in about:config is turned off, right?

Comment 2

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

On Ubuntu 16.04 this issue does not reproduce, neither on esr52.7.2 this not reproduced.
About version of gnome: GNOME Shell 3.12.2.
The ui.popup.disable_autohide is turned off, both on Ubuntu 14.04 and Ubuntu 16.04.

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Timea Zsoldos from comment #2)
> neither on esr52.7.2 this not reproduced.

Can you find a Firefox regression window, then?

Based on this not reproducing on 16.04, I'm pretty sure this is a widget issue.

Comment 4

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Right now I verified on Firefox 54, 55, 56  the issue does not reproduce, but on 57, 58 the issue is reproduce. May be this help you, tomorrow I send you the regression window.

Comment 5

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Here is the pushlog from regression window: 

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5a63d8457a2a69a2ad54a50765bff412580df2a4&tochange=14db7c0bcf9ae86c9ec2cc9d3c249a42e459a2a9

Comment 6

[:Gijs (out for now; he/him)]

(In reply to Timea Zsoldos from comment #2)
> On Ubuntu 16.04 this issue does not reproduce, neither on esr52.7.2 this not
> reproduced.
> About version of gnome: GNOME Shell 3.12.2.
> The ui.popup.disable_autohide is turned off, both on Ubuntu 14.04 and Ubuntu
> 16.04.

What version of gtk3 and libxcb is the 14.04 machine running? Based on the pushlog, I expect this is related to bug 1397918.

Comment 7

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

(In reply to :Gijs from comment #6)
> (In reply to Timea Zsoldos from comment #2)
> > On Ubuntu 16.04 this issue does not reproduce, neither on esr52.7.2 this not
> > reproduced.
> > About version of gnome: GNOME Shell 3.12.2.
> > The ui.popup.disable_autohide is turned off, both on Ubuntu 14.04 and Ubuntu
> > 16.04.
> 
> What version of gtk3 and libxcb is the 14.04 machine running? Based on the
> pushlog, I expect this is related to bug 1397918.

libgtk-3-bin: 3.12.2-0ubuntu15.2~trusty1
libxcb1: 1.10-2ubuntu1

Comment 8

[Lee Salzman [:lsalzman]]

I tried forcing a hack into my build to have the same effect as using an older libxcb would by disabling XShm, and I am still not able to reproduce this issue. At least, I don't directly see how XShm usage would factor into this offhand. Any ideas, Karl?

Also, Timea, if you set the layers.acceleration.force-enabled pref to true, does the problem go away?

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

(In reply to Lee Salzman [:lsalzman] from comment #8)
> I tried forcing a hack into my build to have the same effect as using an
> older libxcb would by disabling XShm, and I am still not able to reproduce
> this issue. At least, I don't directly see how XShm usage would factor into
> this offhand. Any ideas, Karl?
> 
> Also, Timea, if you set the layers.acceleration.force-enabled pref to true,
> does the problem go away?

Really, if I set layers.acceleration.force-enabled pref to true the issue does not reproduced on Ubuntu 14.04 x64. 
I done some tests and the issue from bug https://bugzilla.mozilla.org/show_bug.cgi?id=1446970 is also resolved with this pref set to true.

Comment 10

[Karl Tomlinson (:karlt)]

No real ideas, sorry, except that this does seem related to bug 1446970.

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613