1446945 - [New Performance Panel] Focus the browser window after capturing a remote profile

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P1)

Description

[Julien Wajsberg [:julienw]]

Thanks to the fix to bug 1444124 we can now capture profiles from a remote Firefox. However when we open a new tab to perf-html.io, the browser window isn't focused, and this behavior is awkward because if WebIDE is full-screened it's easy to miss and thing something is broken.

So in this bug we want to focus the browser window when opening the tab to perf-html.io to show the captured profile.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1446945 - [New Performance Panel] Focus the browser window after capturing a remote profile.

Review commit: https://reviewboard.mozilla.org/r/231978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231978/

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

Comment on attachment 8963112 [details]
Bug 1446945 - [New Performance Panel] Focus the browser window after capturing a remote profile.

https://reviewboard.mozilla.org/r/231978/#review237536

The WebIDE window is still in front for me after capturing the profile. My assumption here would be the the WebIDE window would be in the background, and the perf-html.io window would be in the foreground.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8963112 [details]
Bug 1446945 - [New Performance Panel] Focus the browser window after capturing a remote profile.

https://reviewboard.mozilla.org/r/231978/#review237536

Although I test on Windows, this change is that perf-html.io's brwoser window becomes foreground.  Even if WebIDE is maxium size window, browser window becomes foreground by this change.

Comment 4

[Greg Tatum [:gregtatum] (REO Fx132)]

Comment on attachment 8963112 [details]
Bug 1446945 - [New Performance Panel] Focus the browser window after capturing a remote profile.

https://reviewboard.mozilla.org/r/231978/#review238264

Thanks, I re-tested and it's working. I think I pulled your patch without actually updating my code. It works great!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c16e35be859
[New Performance Panel] Focus the browser window after capturing a remote profile. r=gregtatum

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9c16e35be859