Flip the console sidebar flag to true in Nightly

RESOLVED FIXED in Firefox 62

Status

defect
P1
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Tracking

(Blocks 1 bug)

Trunk
Firefox 62
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

No description provided.
Depends on: 1419292
Whiteboard: [newconsole-mvp]
Priority: -- → P2
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8971575 [details]
Bug 1447235 - Enable the console sidebar in Nightly; .

https://reviewboard.mozilla.org/r/240346/#review246166
Attachment #8971575 - Flags: review?(bgrinstead) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd07ca1a922f
Enable the console sidebar in Nightly; r=bgrins.
Backed out changeset fd07ca1a922f (bug 1447235) for Devtools failures on devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=176010569&repo=autoland&lineNumber=8482

INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js | The context menu has the expected entries for a network message - Got #console-menu-copy-url (a)
[task 2018-04-27T20:21:27.823Z] 20:21:27     INFO - #console-menu-open-url (T)
[task 2018-04-27T20:21:27.824Z] 20:21:27     INFO - #console-menu-store (S) [disabled]
[task 2018-04-27T20:21:27.824Z] 20:21:27     INFO - #console-menu-copy (C)
[task 2018-04-27T20:21:27.824Z] 20:21:27     INFO - #console-menu-copy-object (o) [disabled]
[task 2018-04-27T20:21:27.824Z] 20:21:27     INFO - #console-menu-select (A)
[task 2018-04-27T20:21:27.825Z] 20:21:27     INFO - #console-menu-open-sidebar (V) [disabled], expected #console-menu-copy-url (a)
[task 2018-04-27T20:21:27.825Z] 20:21:27     INFO - #console-menu-open-url (T)
[task 2018-04-27T20:21:27.825Z] 20:21:27     INFO - #console-menu-store (S) [disabled]
[task 2018-04-27T20:21:27.825Z] 20:21:27     INFO - #console-menu-copy (C)
[task 2018-04-27T20:21:27.825Z] 20:21:27     INFO - #console-menu-copy-object (o) [disabled]
[task 2018-04-27T20:21:27.825Z] 20:21:27     INFO - #console-menu-select (A)
[task 2018-04-27T20:21:27.826Z] 20:21:27     INFO - Stack trace:
[task 2018-04-27T20:21:27.826Z] 20:21:27     INFO - chrome://mochikit/content/browser-test.js:test_is:1285
[task 2018-04-27T20:21:27.826Z] 20:21:27     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js:null:37
[task 2018-04-27T20:21:27.827Z] 20:21:27     INFO - Logging a text message in the content window
[task 2018-04-27T20:21:27.827Z] 20:21:27     INFO - Matched a message with text: "simple text message", all messages received.
[task 2018-04-27T20:21:27.828Z] 20:21:27     INFO - TEST-PASS | devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js | The context menu is displayed on a log message - 
[task 2018-04-27T20:21:27.829Z] 20:21:27     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-04-27T20:21:27.830Z] 20:21:27     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js | The context menu has the expected entries for a simple log message - Got #console-menu-store (S) [disabled]
[task 2018-04-27T20:21:27.831Z] 20:21:27     INFO - #console-menu-copy (C)
[task 2018-04-27T20:21:27.831Z] 20:21:27     INFO - #console-menu-copy-object (o) [disabled]
[task 2018-04-27T20:21:27.831Z] 20:21:27     INFO - #console-menu-select (A)
[task 2018-04-27T20:21:27.833Z] 20:21:27     INFO - #console-menu-open-sidebar (V) [disabled], expected #console-menu-store (S) [disabled]
[task 2018-04-27T20:21:27.834Z] 20:21:27     INFO - #console-menu-copy (C)
[task 2018-04-27T20:21:27.835Z] 20:21:27     INFO - #console-menu-copy-object (o) [disabled]
[task 2018-04-27T20:21:27.835Z] 20:21:27     INFO - #console-menu-select (A)
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - Stack trace:
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - chrome://mochikit/content/browser-test.js:test_is:1285
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js:null:56
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - Waiting for event: 'popuphidden' on [object XULElement].
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - Got event: 'popuphidden' on [object XULElement].
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - Leaving test bound 
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - Removing tab.
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - Got event: 'TabClose' on [object XULElement].
[task 2018-04-27T20:21:27.836Z] 20:21:27     INFO - Tab removed and finished closing
[task 2018-04-27T20:21:27.932Z] 20:21:27     INFO - GECKO(2642) | MEMORY STAT | vsize 20974077MB | residentFast 1269MB

Push with the fails:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fd07ca1a922fc89838ba3aac345d843d5e3fa082

Backout:
https://hg.mozilla.org/integration/autoland/rev/394644a72c8e71e648affdda38226a4883de1113
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4dbde138d630
Enable the console sidebar in Nightly; r=bgrins.
Tests updated (note to myself, there's no trivial changes that don't require try runs :D )
Flags: needinfo?(nchevobbe)
https://hg.mozilla.org/mozilla-central/rev/4dbde138d630
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Backed out to get test passing on beta https://hg.mozilla.org/mozilla-central/rev/35165f43d0b97f500dafb4f0f7b9ca8d91416812
Status: RESOLVED → REOPENED
Flags: needinfo?(nchevobbe)
Resolution: FIXED → ---
Target Milestone: Firefox 61 → ---
Whiteboard: [newconsole-mvp]
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea5f185258ba
Enable the console sidebar in Nightly; r=bgrins.
https://hg.mozilla.org/mozilla-central/rev/ea5f185258ba
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Backout by shindli@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/192d8e419259
Backed out changeset ea5f185258ba in hopes of fixing webconsole_split issues a=backout on a CLOSED TREE
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad016230e0bd
Enable the console sidebar in Nightly; r=bgrins.
https://hg.mozilla.org/mozilla-central/rev/ad016230e0bd
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → FIXED
Clearing the needinfo flag.
The backout of this patch did not improved the situation of the split test, so it was safe to re-land it
Flags: needinfo?(nchevobbe)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.