1447286 - Update webrender to 30cfecc343e407ce277d07cf09f27ad9dd1917a1

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1446358 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 2083e83d958dd4a230ccae5c518e4bc8fbf88009

https://treeherder.mozilla.org/#/jobs?repo=try&revision=085b66215d6a51082e5838288a7b23814ea82a8f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bbae524bb8debcf44d28115fe8da164fbf69d43

Green so far

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ 9c994b0cca8c1abc24fdf487df950954bebb62a7

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe23df91400668dd5ce3135f027d5d7a826a3865
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8717769f49ec711d8fdfc8c6ffbcd21db576196
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1ad48d27c84716a9ac2dd1b66b2f354e82f1e55
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2644a191251cca90da8a7140890e26c4b33e882

Green

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ b954383687eec47e598d2a5fd9939e3b27c587a9

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc4d5b57eaf8fbd805ecb2a88871de665f5c1b91
https://treeherder.mozilla.org/#/jobs?repo=try&revision=213fcb61cf394c70ccb8fee3965b5a55b3565c96

Basically green (orange/red stuff is unrelated)

WR @ 30cfecc343e407ce277d07cf09f27ad9dd1917a1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bd1cd9ee7ebb14009be2ee849a4103155cb4aa4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ec0b640fd101d5505b4509be32043aaeec792bc

Busted, from servo/webrender#2555

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 30cfecc343e407ce277d07cf09f27ad9dd1917a1 with build fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=191049bba117ece8259d74f63f0fccc4b23c8373
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ea6df5adf39905d2fa2f6ae042513596a69ece6

Still in progress, but looking good so far.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1447286 - Update audioipc to commit f6c4829.

Review commit: https://reviewboard.mozilla.org/r/230158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230158/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1447286 - Update webrender to commit 30cfecc343e407ce277d07cf09f27ad9dd1917a1.

Review commit: https://reviewboard.mozilla.org/r/230160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230160/

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1447286 - Update Cargo lockfiles and re-vendor rust dependencies.

Review commit: https://reviewboard.mozilla.org/r/230162/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230162/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1447286 - Add dummy callback implementation for API change in WR PR 2550.

Review commit: https://reviewboard.mozilla.org/r/230164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230164/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1447286 - Update for API changes in WR PR 2555.

Review commit: https://reviewboard.mozilla.org/r/230166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230166/

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8961382 [details]
Bug 1447286 - Update audioipc to commit f6c4829.

https://reviewboard.mozilla.org/r/230158/#review235788

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8961385 [details]
Bug 1447286 - Add dummy callback implementation for API change in WR PR 2550.

https://reviewboard.mozilla.org/r/230164/#review235792

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8961384 [details]
Bug 1447286 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/230162/#review235790

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8961386 [details]
Bug 1447286 - Update for API changes in WR PR 2555.

https://reviewboard.mozilla.org/r/230166/#review235794

::: gfx/webrender_bindings/src/bindings.rs:270
(Diff revision 1)
>                  None
>              },
>              format: self.format,
>              is_opaque: self.is_opaque,
>              offset: 0,
> +            allow_mipmaps: true,

We want this to be false. We don't need mipmaps in Gecko.

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8961383 [details]
Bug 1447286 - Update webrender to commit 30cfecc343e407ce277d07cf09f27ad9dd1917a1.

https://reviewboard.mozilla.org/r/230160/#review235796

Comment 15

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8961386 [details]
Bug 1447286 - Update for API changes in WR PR 2555.

https://reviewboard.mozilla.org/r/230166/#review235798

Comment 16

[Kartikaya Gupta (email:[e-mail])]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #13)
> 
> We want this to be false. We don't need mipmaps in Gecko.

For posterity: will do this in bug 1448006.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f599cec3e403
Update audioipc to commit f6c4829. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f5e00218c546
Update webrender to commit 30cfecc343e407ce277d07cf09f27ad9dd1917a1. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5889f5145de8
Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/95d435e00ff6
Add dummy callback implementation for API change in WR PR 2550. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/69de9f5b9068
Update for API changes in WR PR 2555. r=jrmuizel

Comment 18

[Matthew Gregan [:kinetik]]

Comment on attachment 8961382 [details]
Bug 1447286 - Update audioipc to commit f6c4829.

https://reviewboard.mozilla.org/r/230158/#review235902

Just be aware that Dan's trying to update audioipc to a later version in bug 1446233, so this might clash with that.

Comment 19

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f599cec3e403
https://hg.mozilla.org/mozilla-central/rev/f5e00218c546
https://hg.mozilla.org/mozilla-central/rev/5889f5145de8
https://hg.mozilla.org/mozilla-central/rev/95d435e00ff6
https://hg.mozilla.org/mozilla-central/rev/69de9f5b9068