Closed Bug 1447286 Opened 2 years ago Closed 2 years ago

Update webrender to 30cfecc343e407ce277d07cf09f27ad9dd1917a1

Categories

(Core :: Graphics: WebRender, enhancement, P3)

61 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [gfx-noted])

Attachments

(5 files)

+++ This bug was initially created as a clone of Bug #1446358 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Blocks: 1447245
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to 30cfecc343e407ce277d07cf09f27ad9dd1917a1
Version: unspecified → 61 Branch
Comment on attachment 8961382 [details]
Bug 1447286 - Update audioipc to commit f6c4829.

https://reviewboard.mozilla.org/r/230158/#review235788
Attachment #8961382 - Flags: review+
Comment on attachment 8961385 [details]
Bug 1447286 - Add dummy callback implementation for API change in WR PR 2550.

https://reviewboard.mozilla.org/r/230164/#review235792
Attachment #8961385 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8961384 [details]
Bug 1447286 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/230162/#review235790
Attachment #8961384 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8961386 [details]
Bug 1447286 - Update for API changes in WR PR 2555.

https://reviewboard.mozilla.org/r/230166/#review235794

::: gfx/webrender_bindings/src/bindings.rs:270
(Diff revision 1)
>                  None
>              },
>              format: self.format,
>              is_opaque: self.is_opaque,
>              offset: 0,
> +            allow_mipmaps: true,

We want this to be false. We don't need mipmaps in Gecko.
Attachment #8961386 - Flags: review?(jmuizelaar) → review-
Comment on attachment 8961383 [details]
Bug 1447286 - Update webrender to commit 30cfecc343e407ce277d07cf09f27ad9dd1917a1.

https://reviewboard.mozilla.org/r/230160/#review235796
Attachment #8961383 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8961386 [details]
Bug 1447286 - Update for API changes in WR PR 2555.

https://reviewboard.mozilla.org/r/230166/#review235798
Attachment #8961386 - Flags: review- → review+
(In reply to Jeff Muizelaar [:jrmuizel] from comment #13)
> 
> We want this to be false. We don't need mipmaps in Gecko.

For posterity: will do this in bug 1448006.
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f599cec3e403
Update audioipc to commit f6c4829. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f5e00218c546
Update webrender to commit 30cfecc343e407ce277d07cf09f27ad9dd1917a1. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5889f5145de8
Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/95d435e00ff6
Add dummy callback implementation for API change in WR PR 2550. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/69de9f5b9068
Update for API changes in WR PR 2555. r=jrmuizel
Comment on attachment 8961382 [details]
Bug 1447286 - Update audioipc to commit f6c4829.

https://reviewboard.mozilla.org/r/230158/#review235902

Just be aware that Dan's trying to update audioipc to a later version in bug 1446233, so this might clash with that.
Attachment #8961382 - Flags: review?(kinetik) → review+
Depends on: 1458223
You need to log in before you can comment on or make changes to this bug.