1446233 - Update audioipc to support cpupool stack size and thread size.

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P3)

Comment 1

[u480271]

Attachment: Bug 1446233 - P1: Update AudioIPC to commit b933866.

Review commit: https://reviewboard.mozilla.org/r/230030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230030/

Comment 2

[u480271]

Attachment: Bug 1446233 - P2: Update Cargo.lock for audioipc-client version.

Review commit: https://reviewboard.mozilla.org/r/230032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230032/

Comment 3

[u480271]

Attachment: Bug 1446233 - P1: Update AudioIPC to commit b933866.

Review commit: https://reviewboard.mozilla.org/r/230034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230034/

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8961253 [details]
Bug 1446233 - P1: Update AudioIPC to commit b933866.

https://reviewboard.mozilla.org/r/230034/#review235718

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8961251 [details]
Bug 1446233 - P1: Update AudioIPC to commit b933866.

https://reviewboard.mozilla.org/r/230030/#review235716

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Sorry for rotting your patches a bit, but I landed the update to bincode-1.0 (by updating both audioipc and webrender) in bug 1447286. If you rebase it should make your second patch a no-op.

Comment 7

[u480271]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #6)
> Sorry for rotting your patches a bit, but I landed the update to bincode-1.0
> (by updating both audioipc and webrender) in bug 1447286. If you rebase it
> should make your second patch a no-op.

No worries Kats. Thanks for landing the bincode 1.0 update.

Comment 8

[u480271]

Comment on attachment 8961251 [details]
Bug 1446233 - P1: Update AudioIPC to commit b933866.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230030/diff/1-2/

Comment 9

[u480271]

Comment on attachment 8961252 [details]
Bug 1446233 - P2: Update Cargo.lock for audioipc-client version.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230032/diff/1-2/

Comment 10

[u480271]

Comment on attachment 8961253 [details]
Bug 1446233 - P1: Update AudioIPC to commit b933866.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230034/diff/1-2/

Comment 11

[Matthew Gregan [:kinetik]]

Comment on attachment 8961252 [details]
Bug 1446233 - P2: Update Cargo.lock for audioipc-client version.

https://reviewboard.mozilla.org/r/230032/#review235970

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a71dd6219f8a
P1: Update AudioIPC to commit b933866. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/f5bec009a111
P2: Update Cargo.lock for audioipc-client version. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/ed217fb39a92
P3: Add prefs to control audioipc client thread pool. r=kinetik

Comment 13

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (bug 1446233) for Wr failures in /html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-two-cue-layout-after-first-end.html on a CLOSED TREE
Backed out: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=44b07396e0ac0c7f31a3feab50b9b791035fb7da&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&fromchange=f7fce0d85ccac6516de526f7e9a7ff358db38be7&filter-classifiedState=unclassified&selectedJob=169797444
Problematic push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ed217fb39a9232a167a1d5acaa71d73cbbcfea24&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=169797444&repo=autoland&lineNumber=1931
Relevant log content: 
18:51:24     INFO - TEST-UNEXPECTED-ERROR | /html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-two-cue-layout-after-first-end.html | No data received over socket

Comment 14

[u480271]

Comment on attachment 8961253 [details]
Bug 1446233 - P1: Update AudioIPC to commit b933866.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230034/diff/2-3/

Comment 15

[u480271]

Hold, on why did only one patch get refreshed?

Comment 16

[Matthew Gregan [:kinetik]]

Comment on attachment 8961253 [details]
Bug 1446233 - P1: Update AudioIPC to commit b933866.

https://reviewboard.mozilla.org/r/230034/#review235990

r+ on revision 3

Comment 17

[u480271]

Attachment: Bug 1446233 - P2: Add prefs to control audioipc client thread pool.

Review commit: https://reviewboard.mozilla.org/r/230498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230498/

Comment 18

[u480271]

Attachment: Bug 1446233 - P3: Add prefs to control audioipc client thread pool.

Review commit: https://reviewboard.mozilla.org/r/230500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230500/

Comment 19

[u480271]

Comment on attachment 8961253 [details]
Bug 1446233 - P1: Update AudioIPC to commit b933866.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230034/diff/3-4/

Comment 20

[Matthew Gregan [:kinetik]]

Comment on attachment 8961631 [details]
Bug 1446233 - P2: Add prefs to control audioipc client thread pool.

https://reviewboard.mozilla.org/r/230498/#review235992

Comment 21

[Matthew Gregan [:kinetik]]

Comment on attachment 8961632 [details]
Bug 1446233 - P3: Add prefs to control audioipc client thread pool.

https://reviewboard.mozilla.org/r/230500/#review235994

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20301e359a4e
P1: Update AudioIPC to commit b933866. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/6f3488ff7c60
P2: Update Cargo.lock for audioipc-client version. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/9b72102a99b3
P3: Add prefs to control audioipc client thread pool. r=kinetik

Comment 23

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/20301e359a4e
https://hg.mozilla.org/mozilla-central/rev/6f3488ff7c60
https://hg.mozilla.org/mozilla-central/rev/9b72102a99b3

Comment 24

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/d2bf7b9c80a7
Backed out 3 changesets for permafailing on dom/media/tests/mochitest/test_peerConnection_replaceTrack.html. a=backout

Comment 25

[Cosmin Sabou [:CosminS]]

Backed out for permafailing on dom/media/tests/mochitest/test_peerConnection_replaceTrack.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=4ad2f727b9b0dcefd72a3207998507caff8a0082&fromchange=9b72102a99b3a0177c7bd476c2d4ab96792520be&selectedJob=169817576

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=169853136&repo=mozilla-inbound&lineNumber=53338

Backout link: https://hg.mozilla.org/integration/autoland/rev/d2bf7b9c80a7f6a23f40d09f119d150e29a14d68

Please take a look also at this push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ed217fb39a9232a167a1d5acaa71d73cbbcfea24&filter-searchStr=4ad2f727b9b0dcefd72a3207998507caff8a0082&selectedJob=169796467

Comment 26

[u480271]

Try run was green here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=89f1d82280ad1eaf63a7f8b13526d92edd40a5fe

Comment 27

[u480271]

Bumped number of threads to 2, ran mda mochitests 20 times. 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2882974b1f186221dac8cba0727916c5470f50d4&selectedJob=170707035

Comment 28

[u480271]

Comment on attachment 8961253 [details]
Bug 1446233 - P1: Update AudioIPC to commit b933866.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230034/diff/4-5/

Comment 29

[u480271]

Comment on attachment 8961631 [details]
Bug 1446233 - P2: Add prefs to control audioipc client thread pool.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230498/diff/1-2/

Comment 30

[u480271]

Run all the mda tests 20x. This change only affects Linux.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=31b8b2ed5290f3acb0f65e08e8362c32453b45dd

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/706096f3276a
P1: Update AudioIPC to commit b933866. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/4e337c4c8c2f
P2: Add prefs to control audioipc client thread pool. r=kinetik

Comment 32

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/706096f3276a
https://hg.mozilla.org/mozilla-central/rev/4e337c4c8c2f