1447301 - Build stylo-only on automation.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

This allows us to remove the code of the old style system.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1447301: Disable the old style system by default.

This keeps --disable-stylo working and --enable-stylo=build with the same
semantics, but it makes also --enable-stylo / and the default to not build the
old style system at all.

This also removes the stylo-only platforms, since they're now the default.

Review commit: https://reviewboard.mozilla.org/r/229364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229364/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8960602 [details]
Bug 1447301: Disable the old style system by default.

https://reviewboard.mozilla.org/r/229364/#review235104

This is a little janky, but this is fine for now, since we'll be removing this code entirely soon.

::: toolkit/moz.configure:557
(Diff revision 1)
>              'runtime, and "only" means to exclude the old style system from ' +
>              'the build.')

Presumably we need to remove this part of the docstring now?

::: toolkit/moz.configure:566
(Diff revision 1)
>      # If nothing is specified, default to building and enabling Stylo,
>      # and building the old style system.

Maybe this comment should be moved up above the setting of the variables now?

::: toolkit/moz.configure:573
(Diff revision 1)
> -    elif len(value) and value[0] == 'build':
>          # Build but disable by request.
> -        build_stylo = True
> -    elif len(value) and value[0] == 'only':
> -        # Disable the old style system.
> -        build_stylo = True
> +        enable_stylo = None
> +        old_style = True
> +    elif value.origin != 'default' and not bool(value):
> +        # Disable

"Disable stylo entirely."?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4887ddbdaafa
Disable the old style system by default. r=froydnj

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4887ddbdaafa

Comment 5

[Ionuț Goldan [:igoldan]]

I don't know how relevant is this. Still, when this bug landed, we noticed these perf improvements, which held only for a short while (less than a day).

== Change summary for alert #12336 (as of Tue, 20 Mar 2018 15:11:49 GMT) ==

Improvements:

  3%  sessionrestore linux64 opt e10s stylo     287.79 -> 280.50
  2%  sessionrestore linux64 pgo e10s stylo     271.33 -> 266.25

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=12336