Closed Bug 1447301 Opened 2 years ago Closed 2 years ago
Build stylo-only on automation
59 bytes, text/x-review-board-request
This allows us to remove the code of the old style system.
Comment on attachment 8960602 [details] Bug 1447301: Disable the old style system by default. https://reviewboard.mozilla.org/r/229364/#review235104 This is a little janky, but this is fine for now, since we'll be removing this code entirely soon. ::: toolkit/moz.configure:557 (Diff revision 1) > 'runtime, and "only" means to exclude the old style system from ' + > 'the build.') Presumably we need to remove this part of the docstring now? ::: toolkit/moz.configure:566 (Diff revision 1) > # If nothing is specified, default to building and enabling Stylo, > # and building the old style system. Maybe this comment should be moved up above the setting of the variables now? ::: toolkit/moz.configure:573 (Diff revision 1) > - elif len(value) and value == 'build': > # Build but disable by request. > - build_stylo = True > - elif len(value) and value == 'only': > - # Disable the old style system. > - build_stylo = True > + enable_stylo = None > + old_style = True > + elif value.origin != 'default' and not bool(value): > + # Disable "Disable stylo entirely."?
Attachment #8960602 - Flags: review?(nfroyd) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/4887ddbdaafa Disable the old style system by default. r=froydnj
I don't know how relevant is this. Still, when this bug landed, we noticed these perf improvements, which held only for a short while (less than a day). == Change summary for alert #12336 (as of Tue, 20 Mar 2018 15:11:49 GMT) == Improvements: 3% sessionrestore linux64 opt e10s stylo 287.79 -> 280.50 2% sessionrestore linux64 pgo e10s stylo 271.33 -> 266.25 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=12336
You need to log in before you can comment on or make changes to this bug.