1447354 - Remove talos overlays

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Brendan Dahl [:bdahl]]

Talos currently uses three overlays to load some js:
 - tresize.overlay.xul
 - damp.overlay.xul
 - tart.overlay.xul

I think we can just use a JS component to load the scripts, similar to what I did in bug 1444973.

Comment 1

[Brendan Dahl [:bdahl]]

Testing underway:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f209da10923a2e2dd9833f3ed5491ea3d74780ab
https://treeherder.mozilla.org/#/jobs?repo=try&revision=02fccf3987cfdd21905ca818a854f7a9f5759ee9

Comment 2

[Brendan Dahl [:bdahl]]

Attachment: Bug 1447354 - Remove talos XUL overlays.

Move the scripts and bootstrapping code that was in the overlay into the
extension bootstrap file.

Review commit: https://reviewboard.mozilla.org/r/230336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230336/

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8961541 [details]
Bug 1447354 - Remove talos XUL overlays.

https://reviewboard.mozilla.org/r/230336/#review235910

some of this is over my head, I took 2 passes on this and nothing looked scary- thanks for doing this!

Comment 4

[Brendan Dahl [:bdahl]]

Comment on attachment 8961541 [details]
Bug 1447354 - Remove talos XUL overlays.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/230336/diff/1-2/

Comment 5

[Brendan Dahl [:bdahl]]

Comment on attachment 8961541 [details]
Bug 1447354 - Remove talos XUL overlays.

I completely missed the comment in the bootstrap file that there is one file that should be copied to all extensions. I've updated that file and now have it load a script to do all the extension specific code.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8961541 [details]
Bug 1447354 - Remove talos XUL overlays.

https://reviewboard.mozilla.org/r/230336/#review236040

some of this logic I have to admit I don't understand.  I do see an opportunity to refactor and have a single initalize_browser.js file if we make tresize have the proxied commands and support it for runtest- All that remains after that is passing in a name like damp|tart|tresize for the MM prefix and .js file to load (i.e. tart.js)

I am not sure if we can load from another directory- if we can then I would prefer if we could load profiler.js and initialize_browser.js from a central location.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00a9d9c4d542
Remove talos XUL overlays. r=jmaher

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/00a9d9c4d542