144740 - javascript strict warnings in pref-contentpacks.xul

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Henrik Gemal]

just going into Edit -> Prefs -> Apperance -> Language produces:

Warning: redeclaration of var selectedItem
Source File: chrome://content-packs/content/pref-contentpacks.xul
Line: 103, Column: 13
Source Code:
         var selectedItem = languageList.selectedItems.length ?
languageList.selectedItems[0] : null;

Warning: redeclaration of var chromeRegistry
Source File: chrome://content-packs/content/pref-contentpacks.xul
Line: 115, Column: 14
Source Code:
          var chromeRegistry =
Components.classes["@mozilla.org/chrome/chrome-registry;1"].getService(Components.interfaces.nsIXULChromeRegistry);

Warning: redeclaration of var observerService
Source File: chrome://content-packs/content/pref-contentpacks.xul
Line: 117, Column: 14
Source Code:
          var observerService =
Components.classes["@mozilla.org/observer-service;1"].getService(Components.interfaces.nsIObserverService);

Warning: function SwitchPacks does not always return a value
Source File: chrome://content-packs/content/pref-contentpacks.xul
Line: 124, Column: 4
Source Code:
    }


20020514

Comment 1

[Roy Yokoyama]

I am not sure if I am a right owner for this.
Try tao?

Comment 2

[[e-mail] (away - not reading bugmail)]

-> jbetak

Comment 3

[[e-mail] (away - not reading bugmail)]

Attachment: patch 1.0

first try at rolling up a patch, should be good to go

Comment 4

[[e-mail] (away - not reading bugmail)]

Naoki, Roy - I have a small patch to fix some strict JS warnings. Would you 
have a minute to review it? :-)

Comment 5

[Roy Yokoyama]

Comment on attachment 93356 [details] [diff] [review]
patch 1.0

/r=yokoyama

Comment 6

[[e-mail] (away - not reading bugmail)]

Thanks Roy!

Chris could you sr=?

Comment 7

[Christopher Blizzard (:blizzard)]

Comment on attachment 93356 [details] [diff] [review]
patch 1.0

sr=blizzard

Comment 8

[[e-mail] (away - not reading bugmail)]

thanks a bunch, Chris!

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 93356 [details] [diff] [review]
patch 1.0

a=asa (on behalf of drivers) for checkin to 1.1

Comment 10

[[e-mail] (away - not reading bugmail)]

checked in.

Kairo, could you please verify?

Comment 11

[Teruko Kobayashi]

Verified as fixed.

Comment 12

[Robert Kaiser]

This caused a regression: language switching is broken now! You changed the
called interface back from nsIXULChromeRegistry to nsIChromeRegistry :(

see bug bug 164496