javascript strict warnings in pref-contentpacks.xul

VERIFIED FIXED in mozilla1.1final

Status

()

Core
Internationalization
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Henrik Gemal, Assigned: jbetak@netscape.com (away - not reading bugmail))

Tracking

({intl})

Trunk
mozilla1.1final
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: has r/sr needs a=)

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
just going into Edit -> Prefs -> Apperance -> Language produces:

Warning: redeclaration of var selectedItem
Source File: chrome://content-packs/content/pref-contentpacks.xul
Line: 103, Column: 13
Source Code:
         var selectedItem = languageList.selectedItems.length ?
languageList.selectedItems[0] : null;

Warning: redeclaration of var chromeRegistry
Source File: chrome://content-packs/content/pref-contentpacks.xul
Line: 115, Column: 14
Source Code:
          var chromeRegistry =
Components.classes["@mozilla.org/chrome/chrome-registry;1"].getService(Components.interfaces.nsIXULChromeRegistry);

Warning: redeclaration of var observerService
Source File: chrome://content-packs/content/pref-contentpacks.xul
Line: 117, Column: 14
Source Code:
          var observerService =
Components.classes["@mozilla.org/observer-service;1"].getService(Components.interfaces.nsIObserverService);

Warning: function SwitchPacks does not always return a value
Source File: chrome://content-packs/content/pref-contentpacks.xul
Line: 124, Column: 4
Source Code:
    }


20020514

Updated

16 years ago
Keywords: intl
QA Contact: ruixu → teruko

Comment 1

16 years ago
I am not sure if I am a right owner for this.
Try tao?
Assignee: yokoyama → tao

Updated

16 years ago
Blocks: 154922

Updated

16 years ago
Blocks: 62177

Updated

16 years ago
No longer blocks: 154922
-> jbetak
Assignee: tao → jbetak
Created attachment 93356 [details] [diff] [review]
patch 1.0

first try at rolling up a patch, should be good to go
Naoki, Roy - I have a small patch to fix some strict JS warnings. Would you 
have a minute to review it? :-)
Status: NEW → ASSIGNED

Comment 5

16 years ago
Comment on attachment 93356 [details] [diff] [review]
patch 1.0

/r=yokoyama
Attachment #93356 - Flags: review+
Thanks Roy!

Chris could you sr=?
Comment on attachment 93356 [details] [diff] [review]
patch 1.0

sr=blizzard
Attachment #93356 - Flags: superreview+
thanks a bunch, Chris!
Whiteboard: has r/sr needs a=

Comment 9

16 years ago
Comment on attachment 93356 [details] [diff] [review]
patch 1.0

a=asa (on behalf of drivers) for checkin to 1.1
Attachment #93356 - Flags: approval+
checked in.

Kairo, could you please verify?
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 11

16 years ago
Verified as fixed.
Status: RESOLVED → VERIFIED

Updated

16 years ago
Keywords: nsbeta1+
Target Milestone: --- → mozilla1.1final

Comment 12

16 years ago
This caused a regression: language switching is broken now! You changed the
called interface back from nsIXULChromeRegistry to nsIChromeRegistry :(

see bug bug 164496
You need to log in before you can comment on or make changes to this bug.