164496 - Language switching broken (again), regression of 144740

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P1)

Description

[Robert Kaiser]

jbetak's checkin for bug 144740 regressed language switching. He changed the
called interface back from nsIXULChromeRegistry to nsIChromeRegistry :(

This is the checkin that caused the regression:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=pref-contentpacks.xul&root=/cvsroot&subdir=mozilla/extensions/content-packs/resources/content&command=DIFF_FRAMESET&rev1=1.20&rev2=1.21

I originally changed this to do the right thing (tm) in bug 140141, and I'll
attach a patch in a minute.

This even blocks 1.1 localization!!!

Comment 1

[Robert Kaiser]

Attachment: patch: changing interface to nsIXULChromeRegistry again

OK, this is the two-liner patch for this one.
Need r=/sr= very soon, even need last-minute a= for 1.1

Comment 2

[timeless]

Comment on attachment 96587 [details] [diff] [review]
patch: changing interface to nsIXULChromeRegistry again

jbetak's patch was for the 1.0 branch, there's no way it could possibly have
cleanly applied to the tip.

r=timeless

Comment 3

[[e-mail] (away - not reading bugmail)]

haste produces wate ->

alecf could you please help us out with a sr=?

Comment 4

[[e-mail] (away - not reading bugmail)]

While I'm sorry that this went unnoticed for some time now and is causing
aggravation, I don't agree with the blocker status. There is a functional
locale-switching UI on the Profile Manager, which can be used for testing until
this gets fixed. ETA is Monday, 08/26/2002

Kairo, thanks for noticing this.

Comment 5

[Alec Flett]

Comment on attachment 96587 [details] [diff] [review]
patch: changing interface to nsIXULChromeRegistry again

sr=alecf

Comment 6

[Robert Kaiser]

thanks alecf.

Checked into trunk:

Checking in pref-contentpacks.xul;
/cvsroot/mozilla/extensions/content-packs/resources/content/pref-contentpacks.xul,v
 <--  pref-contentpacks.xul
new revision: 1.22; previous revision: 1.21
done

still leaving the bug open to get a= and get it into 1.1 as well.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 96587 [details] [diff] [review]
patch: changing interface to nsIXULChromeRegistry again

a=asa (on behalf of drivers) for checkin to 1.1

Comment 8

[Robert Kaiser]

from checkin to 1.1 branch:

Checking in pref-contentpacks.xul;
/cvsroot/mozilla/extensions/content-packs/resources/content/pref-contentpacks.xul,v
 <--  pref-contentpacks.xul
new revision: 1.21.2.1; previous revision: 1.21
done

thanks all for getting this fixed that fast!

Comment 9

[Asa Dotzler [:asa]]

Verified on today's 1.1 branch builds win32, linux and OS X