1447460 - Add support for comm-central to taskcluster cron.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Comment 1

[Tom Prince [:tomprince]]

Attachment: Add support for creating comm-central cron hooks.

Comment 2

[Phabricator Automation]

Attachment: Bug 1447460: Don't create a dummy `pushlog-id` index for cron tasks; r?dustin

Comment 3

[Phabricator Automation]

Attachment: Bug 1447460: Add a slightly more descriptve owner for cron tasks; r?dustin

Comment 4

[Phabricator Automation]

Attachment: Bug 1447460: Mark some obsolete `mach taskgraph cron` parameters as ignored; r?dustin

Comment 5

[Phabricator Automation]

Attachment: Bug 1447460: Teach `mach taskgraph cron` to handle configuration in sub-repositories; r?dustin

Comment 6

[Phabricator Automation]

Attachment: Bug 1447460: Add cron tasks to comm-central; r?dustin

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8962794 [details] [diff] [review]
Add support for creating comm-central cron hooks.

Review of attachment 8962794 [details] [diff] [review]:
-----------------------------------------------------------------

::: src/make-gecko-cron-hook.js
@@ +79,5 @@
>    // set up hook
>  
> +
> +  var repo_env, checkout;
> +  if (!project.gecko_repo) {

This is a little confusing -- it reads as "if there's no gecko repo" yet it references a bunch of gecko repos..

Looking at the patch to project.yml, I see why, but maybe that could be made to read better?

Comment 8

[Phabricator Automation]

Comment on attachment 8962805 [details]
Bug 1447460: Don't create a dummy `pushlog-id` index for cron tasks; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D812

Comment 9

[Phabricator Automation]

Comment on attachment 8962806 [details]
Bug 1447460: Add a slightly more descriptve owner for cron tasks; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D813

Comment 10

[Phabricator Automation]

Comment on attachment 8962808 [details]
Bug 1447460: Teach `mach taskgraph cron` to handle configuration in sub-repositories; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D815

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8962807 [details]
Bug 1447460: Mark some obsolete `mach taskgraph cron` parameters as ignored; r?dustin

Altogether, this is OK, but if you squash it that's great too.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ff8ce674396
Don't create a dummy `pushlog-id` index for cron tasks; r=dustin
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3a59e1b1be5
Add a slightly more descriptve owner for cron tasks; r=dustin
https://hg.mozilla.org/integration/mozilla-inbound/rev/d87865851500
Mark some obsolete `mach taskgraph cron` parameters as ignored; r=dustin
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4730aaaf557
Teach `mach taskgraph cron` to handle configuration in sub-repositories; r=dustin

Comment 13

[Phabricator Automation]

Attachment: Bug 1447460: Add cron configuration to comm-central; r=Fallen

Comment 14

[Phabricator Automation]

Comment on attachment 8962807 [details]
Bug 1447460: Mark some obsolete `mach taskgraph cron` parameters as ignored; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has been removed from the revision.

https://phabricator.services.mozilla.com/D814

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3ff8ce674396
https://hg.mozilla.org/mozilla-central/rev/d3a59e1b1be5
https://hg.mozilla.org/mozilla-central/rev/d87865851500
https://hg.mozilla.org/mozilla-central/rev/c4730aaaf557

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8a23c06fd1c7
Add cron configuration to comm-central; r=me CLOSED TREE

Comment 17

[Tom Prince [:tomprince]]

Attachment: pr 18: Bug 1447460: Pass the correct repository to cron decision tasks for comm-* branches.

Comment 18

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/5ec55f7a95f9
Backed out changeset 3ff8ce674396 on request of tomprince a=backout

Comment 19

[Phabricator Automation]

Comment on attachment 8962812 [details]
Bug 1447460: Add cron tasks to comm-central; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has requested changes to the revision.

https://phabricator.services.mozilla.com/D818

Comment 20

[Phabricator Automation]

Attachment: Bug 1447460: [taskgraph] Use the graph config root to guess find the path to `.taskcluster.yml` in actions; r?dustin

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f824659695a
[taskgraph] Use the graph config root to guess find the path to `.taskcluster.yml` in actions; r=dustin

Comment 22

[Phabricator Automation]

Comment on attachment 8972961 [details]
Bug 1447460: [taskgraph] Use the graph config root to guess find the path to `.taskcluster.yml` in actions; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D1126

Comment 23

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2f824659695a